Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Feb 2022 06:37:23 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v6 net-next 5/5] net: mscc: ocelot: use bulk reads for
 stats
Message-ID: <20220210143723.GA354478@euler>
References: <20220210041345.321216-1-colin.foster@in-advantage.com>
 <20220210041345.321216-6-colin.foster@in-advantage.com>
 <20220210103636.gtkky2l2q7jyn7y5@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220210103636.gtkky2l2q7jyn7y5@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qMOAOk7qDGL27BuB0BSA7oFy2Wag8Wfu/rHT7sjMzMC/1Q0tlve503T9n0mm?=
 =?us-ascii?Q?/EQrH8bQu0XRY4MDdMlQI6rv489SUx+DNm3qZBySYU2ikNT2xXAOtKlCig3P?=
 =?us-ascii?Q?Z+lsFBjoDwahquYVEKStWE22tjcfZu1E+g7oejqLaUCTlYEu+9/wdXSST7y0?=
 =?us-ascii?Q?OXm4V/pyXkha92d0DBg6ha7NHiepZib3IeBcwjVSgs49RwHDj4y6D54xol9H?=
 =?us-ascii?Q?S/EqmhyMdUxUf+dW/ywfopXCaX5U+ZY3kn1nXjHDhshlWTpB8AaG+sPbVUEs?=
 =?us-ascii?Q?k/PkXFsE2ZKTDUu+SnngY2rS6M7YJ+eHfEbsrzQrqJSY1D/i5wBvwsq8tBRs?=
 =?us-ascii?Q?zvu7DKIRvS2OcA9ybqRV5v1LOLuqSiTT2U0IL1V4kSty4Hh9t7ahnhP4dJcL?=
 =?us-ascii?Q?5EFsqCAGi9JqYa/Gyz45WV+lPwkHHH6ss6Weu4NQPUNLwP69ZejixACjF+gi?=
 =?us-ascii?Q?ZtC7FUclyYekApllzf6p9TgvOZT4kvfQ0v1cfr0zDNuoMG7DwaI9irCy6vQg?=
 =?us-ascii?Q?SdFLV3yBB8MkjcViPoKw+GytVC6/ugyCwdPViNS1Q+8hlFIiHGXawEfeOBsE?=
 =?us-ascii?Q?0I7wdLG6NXnUgyIAf/B7v2Oz7gU/3YCuMFIus2zxTuhkOZeJt3vf7w2JSwIG?=
 =?us-ascii?Q?O/BY2JEAUNsE2kJVs5bb/ADcFkz/nybPSXBVm5zAEUNRgirSQ8zf7WhnnlZL?=
 =?us-ascii?Q?faN8XJO/OGIYJAFf5t4AgfMdo/aPhaka6AQyOFzlu5MxtGrzkWVVQW7jn90k?=
 =?us-ascii?Q?gMCYIHtwPEZ85haalRdVQ0XGgGzfSXM0idwuYkd3pvT2rAZaRRsIsTY6Zw5x?=
 =?us-ascii?Q?D0sSoD3NN8MaQvziBajSppRdofY90iMmqi/7mfEZw2tFws1ifSk08gQi8ah5?=
 =?us-ascii?Q?qvpKHIDMK45irjxt8hXT0zCtb0gd2VF6FHJHk7kOeUWUuzTKKoSc7dUEqlus?=
 =?us-ascii?Q?1oawzbAPlGcyL/jPE2QC+6ELwIZ19/Q6/IVugECh2MBy9VBAfwFZIYdu0Zfp?=
 =?us-ascii?Q?wK7oJTC/E+nfax9ceDcjY/00W8TK3DU3Mze7XrKAzCZuJCvvEeYDiJRs3wwz?=
 =?us-ascii?Q?N271qM1GLYwRrNmqEe0IyEiHHb4HbnHMKbP1h7rYb89ELoDk2t0LO5DuiZG0?=
 =?us-ascii?Q?PFwgyZCksCAMmVbMaz6bl3cd3ECMfgivjQP1C4pm02uXbVq0Ytw3PiSeD6Dw?=
 =?us-ascii?Q?TewwhqTvKX6hPC57wDrPeTbxxpnWomUGSnTzhnXfTfzWD/YkkhAZzchRssAk?=
 =?us-ascii?Q?8YvVKcB+03t0gyYn0UbdkTJbgieFVHFoV4VL43IEiUVtUC5rGb1JA8qBiiJ/?=
 =?us-ascii?Q?S71YDUYHd6HMfKnWbJK7cyAmTc5ZqJIm3WNy7zQ37jO3M7Gfx101+rbtZVKD?=
 =?us-ascii?Q?bHVjuAmfL4GfvYvaUECpMI0W1Ub+wyBPDVDR2kypvXYqtFBd+Pl4cqImKu0Q?=
 =?us-ascii?Q?vpbc5YFEcwJqUhDILrcHR+V/bKvSvCtTXnqv7rhrziszsRGid+wTAH/Sii4m?=
 =?us-ascii?Q?DAsCscxMP6YavblWVXav38vzouusHOsVrxrdp7Pz2yrodVQ+TwtVSNtNef1b?=
 =?us-ascii?Q?3+NDrjLQx4ixoNsgH64mrLGIRAvYuT66MKx92n0LjN7R4NRZ5OAxFGMdDSjF?=
 =?us-ascii?Q?wnviwiFTGxBLSBYgzzt+874kVslTJxveUYo3IdjAoAJP/y98NpzPIEosSN/h?=
 =?us-ascii?Q?IzBj7Q=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a34ee9db-9faa-4a2e-3216-08d9eca2dd5a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 14:37:29.7168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uzQii+rHtfS9bYmUOVfXmPc92onTJR8Oa4MOBYe5b/9axmMxpDIVEji7hRLEsWXjAlqGiBtpN5HTVg4WFQ6CJY2n9KzTgrv9ALCaeK2fBN4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5515
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 10, 2022 at 10:36:37AM +0000, Vladimir Oltean wrote:
> On Wed, Feb 09, 2022 at 08:13:45PM -0800, Colin Foster wrote:
> > Create and utilize bulk regmap reads instead of single access for gathering
> > stats. The background reading of statistics happens frequently, and over
> > a few contiguous memory regions.
> > 
> > High speed PCIe buses and MMIO access will probably see negligible
> > performance increase. Lower speed buses like SPI and I2C could see
> > significant performance increase, since the bus configuration and register
> > access times account for a large percentage of data transfer time.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> >  drivers/net/ethernet/mscc/ocelot.c | 79 +++++++++++++++++++++++++-----
> >  include/soc/mscc/ocelot.h          |  8 +++
> >  2 files changed, 75 insertions(+), 12 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> > index ab36732e7d3f..fdbd31149dfc 100644
> > --- a/drivers/net/ethernet/mscc/ocelot.c
> > +++ b/drivers/net/ethernet/mscc/ocelot.c
> > @@ -1738,25 +1738,36 @@ void ocelot_get_strings(struct ocelot *ocelot, int port, u32 sset, u8 *data)
> >  EXPORT_SYMBOL(ocelot_get_strings);
> >  
> >  /* Caller must hold &ocelot->stats_lock */
> > -static void ocelot_update_stats_for_port(struct ocelot *ocelot, int port)
> > +static int ocelot_update_stats_for_port(struct ocelot *ocelot, int port)
> >  {
> > -	int j;
> > +	unsigned int idx = port * ocelot->num_stats;
> > +	struct ocelot_stats_region *region;
> > +	int err, j;
> >  
> >  	/* Configure the port to read the stats from */
> >  	ocelot_write(ocelot, SYS_STAT_CFG_STAT_VIEW(port), SYS_STAT_CFG);
> >  
> > -	for (j = 0; j < ocelot->num_stats; j++) {
> > -		u32 val;
> > -		unsigned int idx = port * ocelot->num_stats + j;
> > +	list_for_each_entry(region, &ocelot->stats_regions, node) {
> > +		err = ocelot_bulk_read_rix(ocelot, SYS_COUNT_RX_OCTETS,
> > +					   region->offset, region->buf,
> > +					   region->count);
> > +		if (err)
> > +			return err;
> >  
> > -		val = ocelot_read_rix(ocelot, SYS_COUNT_RX_OCTETS,
> > -				      ocelot->stats_layout[j].offset);
> > +		for (j = 0; j < region->count; j++) {
> > +			u64 *stat = &ocelot->stats[idx + j];
> > +			u64 val = region->buf[j];
> >  
> > -		if (val < (ocelot->stats[idx] & U32_MAX))
> > -			ocelot->stats[idx] += (u64)1 << 32;
> > +			if (val < (*stat & U32_MAX))
> > +				*stat += (u64)1 << 32;
> > +
> > +			*stat = (*stat & ~(u64)U32_MAX) + val;
> > +		}
> >  
> > -		ocelot->stats[idx] = (ocelot->stats[idx] & ~(u64)U32_MAX) + val;
> > +		idx += region->count;
> >  	}
> > +
> > +	return err;
> >  }
> >  
> >  static void ocelot_check_stats_work(struct work_struct *work)
> > @@ -1777,12 +1788,14 @@ static void ocelot_check_stats_work(struct work_struct *work)
> >  
> >  void ocelot_get_ethtool_stats(struct ocelot *ocelot, int port, u64 *data)
> >  {
> > -	int i;
> > +	int i, err;
> >  
> >  	mutex_lock(&ocelot->stats_lock);
> >  
> >  	/* check and update now */
> > -	ocelot_update_stats_for_port(ocelot, port);
> > +	err = ocelot_update_stats_for_port(ocelot, port);
> 
> ocelot_check_stats_work() should also check for errors.

Worthy enough for a resend. I'll send the fix patch to net with your
correct email and send this update once that gets merged through.

Thanks!

> 
> > +	if (err)
> > +		dev_err(ocelot->dev, "Error %d updating ethtool stats\n", err);
> >  
> >  	/* Copy all counters */
> >  	for (i = 0; i < ocelot->num_stats; i++)
> > @@ -1801,6 +1814,41 @@ int ocelot_get_sset_count(struct ocelot *ocelot, int port, int sset)
> >  }
> >  EXPORT_SYMBOL(ocelot_get_sset_count);
> >  
> > +static int ocelot_prepare_stats_regions(struct ocelot *ocelot)
> > +{
> > +	struct ocelot_stats_region *region = NULL;
> > +	unsigned int last;
> > +	int i;
> > +
> > +	INIT_LIST_HEAD(&ocelot->stats_regions);
> > +
> > +	for (i = 0; i < ocelot->num_stats; i++) {
> > +		if (region && ocelot->stats_layout[i].offset == last + 1) {
> > +			region->count++;
> > +		} else {
> > +			region = devm_kzalloc(ocelot->dev, sizeof(*region),
> > +					      GFP_KERNEL);
> > +			if (!region)
> > +				return -ENOMEM;
> > +
> > +			region->offset = ocelot->stats_layout[i].offset;
> > +			region->count = 1;
> > +			list_add_tail(&region->node, &ocelot->stats_regions);
> > +		}
> > +
> > +		last = ocelot->stats_layout[i].offset;
> > +	}
> > +
> > +	list_for_each_entry(region, &ocelot->stats_regions, node) {
> > +		region->buf = devm_kcalloc(ocelot->dev, region->count,
> > +					   sizeof(*region->buf), GFP_KERNEL);
> > +		if (!region->buf)
> > +			return -ENOMEM;
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> >  int ocelot_get_ts_info(struct ocelot *ocelot, int port,
> >  		       struct ethtool_ts_info *info)
> >  {
> > @@ -2801,6 +2849,13 @@ int ocelot_init(struct ocelot *ocelot)
> >  				 ANA_CPUQ_8021_CFG_CPUQ_BPDU_VAL(6),
> >  				 ANA_CPUQ_8021_CFG, i);
> >  
> > +	ret = ocelot_prepare_stats_regions(ocelot);
> > +	if (ret) {
> > +		destroy_workqueue(ocelot->stats_queue);
> > +		destroy_workqueue(ocelot->owq);
> > +		return ret;
> > +	}
> > +
> >  	INIT_DELAYED_WORK(&ocelot->stats_work, ocelot_check_stats_work);
> >  	queue_delayed_work(ocelot->stats_queue, &ocelot->stats_work,
> >  			   OCELOT_STATS_CHECK_DELAY);
> > diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h
> > index 312b72558659..d3291a5f7e88 100644
> > --- a/include/soc/mscc/ocelot.h
> > +++ b/include/soc/mscc/ocelot.h
> > @@ -542,6 +542,13 @@ struct ocelot_stat_layout {
> >  	char name[ETH_GSTRING_LEN];
> >  };
> >  
> > +struct ocelot_stats_region {
> > +	struct list_head node;
> > +	u32 offset;
> > +	int count;
> > +	u32 *buf;
> > +};
> > +
> >  enum ocelot_tag_prefix {
> >  	OCELOT_TAG_PREFIX_DISABLED	= 0,
> >  	OCELOT_TAG_PREFIX_NONE,
> > @@ -673,6 +680,7 @@ struct ocelot {
> >  	struct regmap_field		*regfields[REGFIELD_MAX];
> >  	const u32 *const		*map;
> >  	const struct ocelot_stat_layout	*stats_layout;
> > +	struct list_head		stats_regions;
> >  	unsigned int			num_stats;
> >  
> >  	u32				pool_size[OCELOT_SB_NUM][OCELOT_SB_POOL_NUM];
> > -- 
> > 2.25.1
> >