Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3338719pxb; Thu, 10 Feb 2022 19:07:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMGFnkBVT1nKvRPuCPZIEOGSdmHnlkRXusVJ47x/EXpflide30s/mvaDM+/muGtJPRzp4p X-Received: by 2002:a17:907:d8d:: with SMTP id go13mr8510925ejc.440.1644548861722; Thu, 10 Feb 2022 19:07:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644548861; cv=none; d=google.com; s=arc-20160816; b=sykibZ4sNCWYt4UHgjoYCC8Bs2SLGlknjTXgYmf5G7/zsXpq+wHcAJYTAVe0KoGOG5 NLEPqWFjv3XLC8nkgPsg9t2E6Z/aGl02bD9CrftYWbt7YhI050gG2miY3oGDB4kPNtSR NwRbFGv6HMybtXakTMlojCywNAQaiQxtniuVVoEPBJiYoOWMYfVmPYmGc5p1BuvhWk+W 3+9sbSo8nmCwcIwT4VijnPcEuUoCy2/GeYQSw/gm/yzBdrxQ61N+HosWH7PVRr4wIZJ/ /J9bESIUDmx9hIr1GtBHlZ490nYZCKw1JBGkDXC8YLMqDnN3IA/CoMn0ThcuXn5D5W0G LtDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lunRwRN+SiCJa2wEJrevMXonarujWu7YJ/LP4m3SXXg=; b=M5Ueg73gyZNMJ0zKYJkE3gDB9qJoXRuKD/pOvUiSK2GVhPgou50gtwLYhenL6Vz1DA noJi26L5ZWCc6Q/cP6dafxJbjPwTRJ4WWHiQGSODrPmSmd1THQd1gn1UswIlt/cfnaIJ J0XNCiUGSobcvIHc56Cz2YaSPYy5xB8kL/7Bf/ViaOkubHMfGuhtYtF0qwMp7XI3NO89 K0xB1/z0lMlWSkheATU+4klfcfIrXaAVnt2fEU928YO4+ztrLge3MqNQSeq91tLpYMVu 3fK5Rb5panfLh7fVck62WL7zm8E+plBEm15Filmt3l22zJ3hcAcCx8DeVA1LFRKP3C6r i6Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hbXxrU39; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd3si16929481ejc.49.2022.02.10.19.07.14; Thu, 10 Feb 2022 19:07:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hbXxrU39; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347252AbiBKCU7 (ORCPT + 99 others); Thu, 10 Feb 2022 21:20:59 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238163AbiBKCU6 (ORCPT ); Thu, 10 Feb 2022 21:20:58 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5B59B30; Thu, 10 Feb 2022 18:20:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55DF060F95; Fri, 11 Feb 2022 02:20:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42180C004E1; Fri, 11 Feb 2022 02:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644546057; bh=+FnvOS9moFd3rgdNWficw5UDXxuDO088ELw6a4A8IrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hbXxrU39WoVx22J2ACoBBqN0D4fNQlo5THbYeZchIBsfxvhO8rp8l3csOX2QYlrrQ Cs+y5Ijn0ZAKjjnHKElDvvLZD1vdPDt3Pvaz8MZgQFRaU1YhTUwzkQ/xobsqTqk1Kj 3OlCci0KlBM1wRqqop6IOHUiARs0mEvwZYZORICTIsvRu/4eA54TTvVXDrR1X3sH6m RB+9pF1PDQX5WH63N7okw8XPRoOzY4jwYrAfjyYrBW8GAxk9MOj/4INu674beYQ+sb W4bpasyzBkzhUOTjy9TlQ5orNUEFYXZJdWz21SmJ330s1wuY4PoeH+cd3XOu/VJqk4 JtApKqhozjknA== Date: Thu, 10 Feb 2022 18:20:56 -0800 From: Jakub Kicinski To: Gatis Peisenieks Cc: chris.snook@gmail.com, davem@davemloft.net, hkallweit1@gmail.com, jesse.brandeburg@intel.com, dchickles@marvell.com, tully@mikrotik.com, antons@mikrotik.com, eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC Message-ID: <20220210182056.0a990e67@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220210081201.4184834-1-gatis@mikrotik.com> References: <20220210081201.4184834-1-gatis@mikrotik.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Feb 2022 10:12:01 +0200 Gatis Peisenieks wrote: > If NIC had packets in tx queue at the moment link down event > happened, it could result in tx timeout when link got back up. > > Since device has more than one tx queue we need to reset them > accordingly. > > Signed-off-by: Gatis Peisenieks Fixes: 057f4af2b171 ("atl1c: add 4 RX/TX queue support for Mikrotik 10/25G NIC") ?