Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Feb 2022 23:09:23 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Jan Dabros <jsd@semihalf.com>
Cc:     linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
        mika.westerberg@linux.intel.com, hdegoede@redhat.com,
        rrangel@chromium.org, mw@semihalf.com, jaz@semihalf.com,
        upstream@semihalf.com, thomas.lendacky@amd.com,
        alexander.deucher@amd.com, Nimesh.Easow@amd.com,
        mario.limonciello@amd.com
Subject: Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support
Message-ID: <YgWNE05eVK+LijL/@kunai>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Jan Dabros <jsd@semihalf.com>, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,
        hdegoede@redhat.com, rrangel@chromium.org, mw@semihalf.com,
        jaz@semihalf.com, upstream@semihalf.com, thomas.lendacky@amd.com,
        alexander.deucher@amd.com, Nimesh.Easow@amd.com,
        mario.limonciello@amd.com
References: <20220208141218.2049591-1-jsd@semihalf.com>
 <20220208141218.2049591-3-jsd@semihalf.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="TzVXNhoD/5i1HVBQ"
Content-Disposition: inline
In-Reply-To: <20220208141218.2049591-3-jsd@semihalf.com>
Precedence: bulk


--TzVXNhoD/5i1HVBQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 08, 2022 at 03:12:18PM +0100, Jan Dabros wrote:
> Implement an I2C controller sharing mechanism between the host (kernel)
> and PSP co-processor on some platforms equipped with AMD Cezanne SoC.
>=20
> On these platforms we need to implement "software" i2c arbitration.
> Default arbitration owner is PSP and kernel asks for acquire as well
> as inform about release of the i2c bus via mailbox mechanism.
>=20
>             +---------+
>  <- ACQUIRE |         |
>   +---------|   CPU   |\
>   |         |         | \      +----------+  SDA

Applied to for-next, thanks! I fixed the following checkpatch warnings:

CHECK: Please don't use multiple blank lines
#232: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:92:
+
+

WARNING: braces {} are not necessary for single statement blocks
#361: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:221:
+	if (ret) {
+		goto cleanup;
+	}

Please also use checkpatch next time.


--TzVXNhoD/5i1HVBQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmIFjRMACgkQFA3kzBSg
KbaLFQ/8DKZmeRjUSNfLZh6Kfbjk1tQaIbq2RFIvYtX6aDyJdr2WAfzwqYg4yDNZ
2lP1LlqgaAJfbUjw7MucblsRy96TBS5qa8DfzgSQ7CHd1kJ+4gJTrJipozmyt/0d
AWh88pnH+zTz0cfL9VXgzXMETLJl9NHar69mox5e9dunsEJphkr99sQCpAbVYgac
EyuplJGGGhqyTV2dB9Twtb7jx4mIN4JGbpP0HUJwbVscqrzgzc2ChK5eCYkwagZ8
H2+kLVs4DyEtmP0vI00xiB56k3xAXDCuj6TpZBq0W9kSUvDtrJHLVNi1yWbKomIH
nGSiN+xqz7Pcy9Od+95mgVCgZ1QyfvbghIGG2MwKn5OWAfcoSTOE7nyouGw+9Hku
ZcciytjnwuzMmFkWU3JRz/MoMrHljlekGE2mT1gnUL0DmVdumb5MZAskJurPTXYh
0Gine2IZCLRgokO4Dm8Z0qZslaRzVrByMggnU36nLX4auqV08LdhS3w0QrfCRKZc
lcvHdBNNoR2Uv1GnAbuhSRwHsDy4dcO4Ug1n7sVOJEZ5Dxmleqz8VME1RRFwjZhu
QftepRfZu5VKLlX57ELq6iWylDeY1m8/SmaRQjQK842QqhTyrKX7t2gW+d/WcO/k
MTiJ5tpwGsHqPdtbcJozfmGBPb5e2Qo6yPunc3xUAFDIVChYZTw=
=gemd
-----END PGP SIGNATURE-----

--TzVXNhoD/5i1HVBQ--