Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <da35c076-52e3-293b-fd36-f4572e369e51@oracle.com>
Date:   Thu, 10 Feb 2022 09:36:01 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] ACPI/IORT: Fix GCC 12 warning
Content-Language: en-US
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Hanjun Guo <guohanjun@huawei.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        trivial@kernel.org
References: <1644453141-1181-1-git-send-email-victor.erminpour@oracle.com>
 <CAMj1kXHUOJ-3CXFUJ9ULQuSoRh1=d3PJ15eFUsdGjQtUHozSpA@mail.gmail.com>
From:   Victor Erminpour <victor.erminpour@oracle.com>
In-Reply-To: <CAMj1kXHUOJ-3CXFUJ9ULQuSoRh1=d3PJ15eFUsdGjQtUHozSpA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFlTN0NISTQvNDgxdjY0R0hVSTJuc04xM2I1MDF4ck9iQm1RMllwQngvWFRs?=
 =?utf-8?B?WE1hanhDUzFqdzk2RnNmVHFUOUxNS1lqOHZSdjI5eUh3dXplMTBDK0N6VFRq?=
 =?utf-8?B?eVlldjdPUDBRcG01M3BMWnVzOFFjWm9WRFoxZUFYelA2VWN1ZVR1cG50dC92?=
 =?utf-8?B?TlVGREhWRXNaYWdBalFaVllEYzBKSnBndnBhU1ppNU5BZjNFWDVWRDY2emVj?=
 =?utf-8?B?L0Q5RkNTM3RxaVdqR0dMNWk5UUxhRWQwYWMxdXE1WGE1a3RaZ0hDU1JtMktX?=
 =?utf-8?B?TE5qSklSS21BcnRMVjFSNXhoSy9XdktQOTJjd3A0V3ZHbDNldDdOV1BVWlhB?=
 =?utf-8?B?andwaC9vemVlMmhQaHlkTEZJMER3UWtLQnBvNjV1Wm5iVFNCQnZ0RTFFUjNu?=
 =?utf-8?B?VEMzRjFmZ0RWWGtSNlJIc2xYemd2U214RHIvdXA1bU8zTUc3STVmWlF4a29L?=
 =?utf-8?B?OXdwd1hPNGdtdUlvbFJSY2hRMXJJT0VTM2s0a3VNYWVQOU1KZzMzc1FIdUlu?=
 =?utf-8?B?cllWOHA0SCtOSGRPR3RhUFFmcUtHbFVURHpxQWRoTVJqK2t0MGNnaWFVUyt1?=
 =?utf-8?B?WVVFRzBOaUxMenkrYWpXRDEwMk00eHlQS2xLRHdBNG9IOUZWcm94bHV0bWpU?=
 =?utf-8?B?L2JCL1d5MzJ2cXpFQi9zTGRTVTlHN2YwLzVwL0g2K09sSlRFUzZDWkUzdS9k?=
 =?utf-8?B?N0RrQWlhR2pQREtJcnMzL1ZTc0JmQjVDM1lJNkkwU1BDRmp4c0F5TmUzMHdB?=
 =?utf-8?B?b3pYMzc4VkVjbzVySy9LczFicEQ3UFA0b1pEd2xsMXhNRFVvVDV2SG9LODFK?=
 =?utf-8?B?Z0RwOEc1VytJMWs5WkRKaDR3VXFudmtZdW5lbk5nVjRIU2VUaWljd1pHUmVN?=
 =?utf-8?B?ZlVwdGxYWmhLQVcxa2xKTXUvbTRSOHhnT09ZclJDK05FM0pTZGpSSEY2V3dJ?=
 =?utf-8?B?RGUvRGR6UllGcG5pT2JyTWJCeHVqcVRvL3RZTVRMaXBDelJGc3Y5YXFnT3NI?=
 =?utf-8?B?RWdmQys1dDg1UmJXa3VwRFZOWWhyK2dLb3hKODMxZXdFNzV5OHRUWCtKUGt3?=
 =?utf-8?B?K0tWWjBSU2UwbVZjQnRSY0UzZVB4YmtIblhPT1UxU2w3eTdVNFNSR2N1UDVi?=
 =?utf-8?B?ZmRSK0ZKbFlYWkJYMzczWG5WYjNMNTZPTUoweWxSeU42Y0J4dmJobFZIUTV3?=
 =?utf-8?B?OFlGZENzNnduRG9ZM0NEY0FKNStkL29KTUVMWmdSRGxTUys3STR2N21YNW91?=
 =?utf-8?B?cjRHdHF5SkxiZy85RnByNkZhZ25KMk90bElXeHlmeWlKemdlRXNSYitKdnZG?=
 =?utf-8?B?OTN0UzlGY05LenZDdjF6K25OZERsMmpMRm5SaWNjeHQ1NFdCaUlOVEFaeS92?=
 =?utf-8?B?aGtPM2JVWlk5andBdi8vYnZQVjh1ODRvT0twWUZsY1VRYVZNVFE0OGFtU2hQ?=
 =?utf-8?B?b2RzQUp0K0JyM0ZFeTJCaldNUjlta1RpdGVYeXhqenVMWFpkenVkdXdBWVZy?=
 =?utf-8?B?K3E2MWZJQmNaWnFzOTgyc1ZDcGx5eXNYVmtNamR6WkhHenRNam5peXBvK0dU?=
 =?utf-8?B?SVgzV1lXVVQ0VnU3U241L3A5ZEpxdEpTQUFub3dmeURoVVNteXRNS0tnanhB?=
 =?utf-8?B?U2NEWVV5RHJRZG9ENTB0b2VHVEtYd1pBaU04RUE3SVp5WVFReURQWTVob0NE?=
 =?utf-8?B?eGVId2k3dWZhb3Q5ZTVRNTNFVzFvZUk0dE1SVFNBUmpacStackxEbDIvRW9m?=
 =?utf-8?B?R2FUYTBPN1kwWFZpQmtsaHlGYkdpYUdhUHI0eUo1cXlidDU2ZzBWL1pWWkpu?=
 =?utf-8?B?MEpnNXRxQ0xNZmltSUg3TVZiWG9kODJ3WVM3RGkrc2pvSmlzS09BRExhUnd4?=
 =?utf-8?B?MldmNU45VGVEbXFGRUg5WVpjaCtNd3Q0UHU1bkNNMXExTndDOWlOR0FXMUdP?=
 =?utf-8?B?bDlsSmExWHg1VjBSOGd4T3k0Mjh6eGNpZ3M0MGk5WTJDV1ZOVmc1Z0tZZi9W?=
 =?utf-8?B?UkNDRTRnY1Z2R3VtbnI4a0p3cXN2dUROTWtaR1lkZERMZ2orRWlUMGd5MXV3?=
 =?utf-8?B?bENWT3RSUlNtVnVoVGIvZ3BnTWZvQWQ1UzlMb3F5ZG40YXlXVVpYU2FMRFMz?=
 =?utf-8?B?ZTkzZHJUNUtyWlpYcDFQZFd5WWVZK3lDQ3Y4TU5EL0RPbGZEVE9DbThVMXJa?=
 =?utf-8?B?dkNyZnUwQmt3VWRWSGxmWVpPRGp4ck9mc1plTTAwZVlwbEVaRDMza1FUQm1w?=
 =?utf-8?B?c3c0LzduWFpac0Q4MHJRczZQNGgwaVpLQ0RzbXBCVUtjVkIycFlCVVIwSG5q?=
 =?utf-8?Q?s1CAU53Yo7Px7LxihG?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b8d4996-d62e-4526-9e30-08d9ecbbd33d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4477.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 17:36:09.9830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uHUl+jvcQUf5UVTAgSDyP7SANj4KuyG7bkElLkcdEsTCGLZGeSgHc3JNJ0gGrNMxy3H2ifSGX3lREOjpIklGDEuaretVer7Sz/Wz5+yJha4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2992
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10254 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100093
X-Proofpoint-GUID: rNNLXxkt0TR9VBeW9MsdhY-ArQvo9yeA
X-Proofpoint-ORIG-GUID: rNNLXxkt0TR9VBeW9MsdhY-ArQvo9yeA
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/10/22 1:11 AM, Ard Biesheuvel wrote:
> On Thu, 10 Feb 2022 at 01:34, Victor Erminpour
> <victor.erminpour@oracle.com> wrote:
>> When building with automatic stack variable initialization, GCC 12
>> complains about variables defined outside of switch case statements.
>> Move the variable into the case that uses it, which silences the warning:
>>
>> ./drivers/acpi/arm64/iort.c:1670:59: error: statement will never be executed [-Werror=switch-unreachable]
>>    1670 |                         struct acpi_iort_named_component *ncomp;
>>         |                                                           ^~~~~
>>
>> Signed-off-by: Victor Erminpour <victor.erminpour@oracle.com>
> GCC 12 is not released yet, and this is clearly a compiler bug (a
> declaration is not a statement, and the hidden offending statement
> [the zero-init] is emitted by the compiler itself), so please report
> this to the GCC folks instead.

Hi Ard,

Thanks for the reply.
This fix is similar to the following commits that have been integrated 
upstream:
https://lore.kernel.org/linux-hardening/20211209043456.1377875-1-keescook@chromium.org/
https://lore.kernel.org/linux-hardening/20211209043915.1378393-1-keescook@chromium.org/

You're not obligated to integrate this commit, but you may run into this 
issue once
upstream starts using GCC 12 (or a patched version of GCC 11 in my case) 
with the
CONFIG_INIT_STACK_ALL_ZERO option enabled.

Regards,
--Victor


>
>> ---
>>   drivers/acpi/arm64/iort.c | 8 +++-----
>>   1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
>> index 3b23fb775ac4..5c5d2e56d756 100644
>> --- a/drivers/acpi/arm64/iort.c
>> +++ b/drivers/acpi/arm64/iort.c
>> @@ -1645,7 +1645,7 @@ void __init acpi_iort_init(void)
>>    */
>>   phys_addr_t __init acpi_iort_dma_get_max_cpu_address(void)
>>   {
>> -       phys_addr_t limit = PHYS_ADDR_MAX;
>> +       phys_addr_t local_limit, limit = PHYS_ADDR_MAX;
>>          struct acpi_iort_node *node, *end;
>>          struct acpi_table_iort *iort;
>>          acpi_status status;
>> @@ -1667,17 +1667,15 @@ phys_addr_t __init acpi_iort_dma_get_max_cpu_address(void)
>>                          break;
>>
>>                  switch (node->type) {
>> -                       struct acpi_iort_named_component *ncomp;
>> -                       struct acpi_iort_root_complex *rc;
>> -                       phys_addr_t local_limit;
>> -
>>                  case ACPI_IORT_NODE_NAMED_COMPONENT:
>> +                       struct acpi_iort_named_component *ncomp;
>>                          ncomp = (struct acpi_iort_named_component *)node->node_data;
>>                          local_limit = DMA_BIT_MASK(ncomp->memory_address_limit);
>>                          limit = min_not_zero(limit, local_limit);
>>                          break;
>>
>>                  case ACPI_IORT_NODE_PCI_ROOT_COMPLEX:
>> +                       struct acpi_iort_root_complex *rc;
>>                          if (node->revision < 1)
>>                                  break;
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-arm-kernel__;!!ACWV5N9M2RV99hQ!dguMEUG-y4wN_Scw_dP1umWKxZKxiQA2Fv9sHuQx6Un9QIqSMbkQVxTeIZInR2h7YL-f$