Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3398753pxb; Thu, 10 Feb 2022 21:16:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhut8sm1uxrpsyRG0cUY32WWEe73I9n31fkXWfTAUP1X6z5/RV2zBn0kiXL7uEekgibzsC X-Received: by 2002:a62:1ec7:: with SMTP id e190mr9210pfe.66.1644556599762; Thu, 10 Feb 2022 21:16:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644556599; cv=none; d=google.com; s=arc-20160816; b=dCAkLsYimkMh37AmGPvaZ2fMFbncpwNRyM0xlwnD46v3F1pxYr3XeruLzOEXskQ3ZG SDXfPpL+CoAynq0j66Qd0coRrX4ptszMq+ei3qAYzLNaHrhmotINCKngcpoOXDdnpY0C N3jsz3XoOEzQCsSbxmKQaygPPuvJOrToYmtEolJKP6XPo+bkpzsI5R5LYOS9I4ifnKTx Y/1nbkAgDnGGaMsguSStKihG6lG+tQ0TDP66Uz3PU8kKb76/FzTP4EJiVNTg7ZaPXsLt x6xJTsFkzu7aS1+ogeB76U2x6+TMKE8hGkKoXHZRaQRrQIUQtYnPK/rJTEjU65BWBy63 +Bwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=aG7/QAXXbDC+3e0zVsPV3cyJND/8D9XnGfpQNFD9vrA=; b=iOmMP7VnaMDXfoEX/KbJ8iu/czx+AS7/Bz3cOA9aGczBUc4mByfj7cpwZTQnbZi41B S5c5QNV2HZPGmDs3E4q+5FUUHjLqFF/vNqdbP1tvQ+nZA6+chjbSKAFXKUmHr8m5oZzi EM28T2qNhTi7PQBVsr961o1Bu4+UEOEnW9ki2U+dHA33NGEXSWOcAYFdNpMaYnyK26v/ w3KmSXhiqnPxtzWdbCcfgeWjsg0OfefqTwmR2vseM4mwCvTvryibXdZQDUN5ysYgRLz/ 1uxW0cwI0f+Yq1OsonOR7ZYj6Vjii9K674j57bTdL8nZRmokkY5Ku7Bp9LVo++cIbCA4 xxOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v11si7728793pgk.121.2022.02.10.21.16.28; Thu, 10 Feb 2022 21:16:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242247AbiBKDxk (ORCPT + 99 others); Thu, 10 Feb 2022 22:53:40 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237395AbiBKDxd (ORCPT ); Thu, 10 Feb 2022 22:53:33 -0500 Received: from mail-m17664.qiye.163.com (mail-m17664.qiye.163.com [59.111.176.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64E8855BE; Thu, 10 Feb 2022 19:53:31 -0800 (PST) Received: from localhost.localdomain (unknown [58.22.7.114]) by mail-m17664.qiye.163.com (Hmail) with ESMTPA id 7CFE1140127; Fri, 11 Feb 2022 11:43:47 +0800 (CST) From: Jon Lin To: broonie@kernel.org Cc: heiko@sntech.de, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jon Lin Subject: [PATCH 2/6] spi: rockchip: Preset cs-high and clk polarity in setup progress Date: Fri, 11 Feb 2022 11:43:38 +0800 Message-Id: <20220211034344.4130-2-jon.lin@rock-chips.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220211034344.4130-1-jon.lin@rock-chips.com> References: <20220211034344.4130-1-jon.lin@rock-chips.com> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWRlLHUJWTR4YSEhCHkJDHk 9MVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWVVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MTo6ASo5Tj5JEh40CA8PF08w CRowFDpVSlVKTU9PTk5KS0lMQ0NNVTMWGhIXVREUFVUXEhU7CRQYEFYYExILCFUYFBZFWVdZEgtZ QVlOQ1VJSVVMVUpKT1lXWQgBWUFJQ09NNwY+ X-HM-Tid: 0a7ee6e13bd2da2fkuws7cfe1140127 X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After power up, the cs and clock is in default status, and the cs-high and clock polarity dts property configuration will take no effect until the calling of rockchip_spi_config in the first transmission. So preset them to make sure a correct voltage before the first transmission coming. Signed-off-by: Jon Lin --- drivers/spi/spi-rockchip.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 7ac07569e103..1738a2611a2b 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -711,6 +711,26 @@ static bool rockchip_spi_can_dma(struct spi_controller *ctlr, return xfer->len / bytes_per_word >= rs->fifo_len; } +static int rockchip_spi_setup(struct spi_device *spi) +{ + struct rockchip_spi *rs = spi_controller_get_devdata(spi->controller); + u32 cr0; + + pm_runtime_get_sync(rs->dev); + + cr0 = readl_relaxed(rs->regs + ROCKCHIP_SPI_CTRLR0); + + cr0 |= ((spi->mode & 0x3) << CR0_SCPH_OFFSET); + if (spi->mode & SPI_CS_HIGH) + cr0 |= BIT(spi->chip_select) << CR0_SOI_OFFSET; + + writel_relaxed(cr0, rs->regs + ROCKCHIP_SPI_CTRLR0); + + pm_runtime_put(rs->dev); + + return 0; +} + static int rockchip_spi_probe(struct platform_device *pdev) { int ret; @@ -837,6 +857,7 @@ static int rockchip_spi_probe(struct platform_device *pdev) ctlr->min_speed_hz = rs->freq / BAUDR_SCKDV_MAX; ctlr->max_speed_hz = min(rs->freq / BAUDR_SCKDV_MIN, MAX_SCLK_OUT); + ctlr->setup = rockchip_spi_setup; ctlr->set_cs = rockchip_spi_set_cs; ctlr->transfer_one = rockchip_spi_transfer_one; ctlr->max_transfer_size = rockchip_spi_max_transfer_size; -- 2.17.1