Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Feb 2022 18:50:41 -0600
From:   Jeff LaBundy <jeff@labundy.com>
To:     Markuss Broks <markuss.broks@gmail.com>
Cc:     linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Henrik Rydberg <rydberg@bitmath.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Input: add Imagis touchscreen driver
Message-ID: <20220211005041.GA51878@nixie71>
References: <20220210163708.162866-1-markuss.broks@gmail.com>
 <20220210163708.162866-3-markuss.broks@gmail.com>
 <20220211000103.GA51220@nixie71>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220211000103.GA51220@nixie71>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?twkcKjiBNqHJHHfTG1YYdOxR0DggD9b0EN0GJaKglAZ0bnwdpmlMTNflUDHj?=
 =?us-ascii?Q?Vy7yFcpdmNTlIhRS/RdVptFQBZ7p8g0OSelhXV+0xYpPkwCkpIkJduOspGaM?=
 =?us-ascii?Q?FE9ciwf4KCY1wRE7oidRgDn0M9yPB/QwQXX3LTotE1zx+v9yzNjJaKr1TtKl?=
 =?us-ascii?Q?atQ5y0LoRi4D0Yx168pVdxT4C70qONPRzRO01BnxqZbtX+7uu8damIY125lv?=
 =?us-ascii?Q?qMmL8T5i2f7Gqv44EOSSLI96WvNoAqNQpqd8zA7COEDAXk4fbIVh+6a3imI/?=
 =?us-ascii?Q?lTr7m4+Zr3aLntMPM0+41ymjTKxTexputScaDTrv81DFuVipYUJisNQ+Csnp?=
 =?us-ascii?Q?5nWGP5RlL0eZ7QHvYmu8+NTxyj962/Gv34yJNXUdj5300qaCXUdMqrT0XFEa?=
 =?us-ascii?Q?b6pZsMQUgqHLdzIrVh0tdlNrJVvxsuHc5YrhLBk3n0FUpgXEc1YEvaQA2Hcu?=
 =?us-ascii?Q?OxxG0jwCyjviTLjIsySsWW8B8/Ev3Vf9/xZ4ltwEOfZqhPzrTka3AHLyy5oz?=
 =?us-ascii?Q?n59dDlSafoy42g05XfPX5uFErd+ku2S2lUR90tOKxV3z3qRc1GZl2xNS0Ddo?=
 =?us-ascii?Q?OAEBYJPgaYr2hP+j/laiS3/jSh48iNEvGZPb2k/b03OsjweYcHyRC+w5ccCk?=
 =?us-ascii?Q?1V/rVf3C3RXi7YjsDb1AhGQhYCHVD/ZbXdxSXQsI6zcvVYgxUjMMqR6NUrkR?=
 =?us-ascii?Q?s0qSJx9LiG6dgv+52AYBNvp4uQpz987BOaq2xBZOQp1LR2gjuaIWQ/y/IFnr?=
 =?us-ascii?Q?aH8EEvQfP3e2uZDIXKY3Fg92mZP593hOV7oAnLzSSacYV+KM4EmxME0btyMz?=
 =?us-ascii?Q?gG+wwipthcxlIM3atLj1SHqqGYBjCUK+C5lrY2ePCwic6S8Lb+IE6bMgzC0s?=
 =?us-ascii?Q?fC75jd4xFcmTDKmkJPThGCZSnaHQFEXKdck/9MkdEWIorG4FnnfpXUmHU2q3?=
 =?us-ascii?Q?Ymi5InlQxnZl2RfWPqdHNZ3Tb7RCWhqV9PlTDKEig0Wccy1E/QpRFyq4lQ4U?=
 =?us-ascii?Q?wT5R9lAvklaXigQ1MWt6WqvMaiNkJ8k84OJOxvpAIHepLUCpZJvG3CvPtdlJ?=
 =?us-ascii?Q?PiUr16WcCzB09WrSS1MsZhA5YFm9P0qMhLZyn8AI9X4MSURsunos9pgY3o8I?=
 =?us-ascii?Q?HFfFjGDOWzZSzyv2UADM4mNAQdOMbUyX8cHk76jVElgMzDmwb/0g8BymKe6l?=
 =?us-ascii?Q?ZFl0jFn5lP4UFbMAoipprdtRi9q05K6rwohjsfkuzZmPcXffoGiDKr9424ig?=
 =?us-ascii?Q?6M73iL89gOx8XMd8EXcSXHkH/Jdb7Xn24s3AGCf7O3mh00EJX4HCg57HEmcE?=
 =?us-ascii?Q?D51qymunxBKum7yxa7UBu7ph46Fip31RKP9keoSfPs66P8EIZ3izs98rwUAY?=
 =?us-ascii?Q?xRczWGeu3icxxViVn0nTQvg706VUJaniBvwCe0tzcAWxx7KwXIzzLtG1rK2D?=
 =?us-ascii?Q?e5KbqpjfnXeWmkUCMkaBs9rYSXfosjSLZEdCUxW5x+Nhl0+MZ77UyB0hOQTc?=
 =?us-ascii?Q?zoA6+uxgzqrovdSKYCxv6iH/HnFuXosGdHXMV2Rksz/4709QdxuTLNH7zKs5?=
 =?us-ascii?Q?WOad7hL8s+F3TkWnXrobYht6JORSnCmPZT6HmgRHEWa7U48zJec67gNy2YfQ?=
 =?us-ascii?Q?Zx9FH59Xx1u/ayLmQCllCUc=3D?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 742be436-70ae-49c1-ce12-08d9ecf88aae
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR08MB6544.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 00:50:47.3954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Ya8qi/3tzdiAWNPcyF4z8TSB/p5HKozmrVFEQw2qRE3JYg5J4/iKc762Uiin05gvmy32zTr+Vaj2w6fV02dXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR08MB5569
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Markuss,

One tiny correction to my previous feedback.

On Thu, Feb 10, 2022 at 06:01:03PM -0600, Jeff LaBundy wrote:
> Hi Markuss,
> 
> Neat little driver! Some humble feedback below.
> 

[...]

> > +	error = input_register_device(input_dev);
> > +	if (error) {
> > +		dev_err(&ts->client->dev,
> > +			"Failed to register input device: %d", error);
> > +		return error;
> > +	}
> 
> I suggest using the device-managed version here, as you have no remove callback.
> 

Please ignore this bit :)

[...]

Kind regards,
Jeff LaBundy