Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Feb 2022 21:32:22 +0200
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Georgi Djakov <djakov@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>, linux-pm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: interconnect: imx8m-noc: Add
 fsl,icc-id property
Message-ID: <YgVoRols6AA5HAze@abelvesa>
References: <20220106164150.3474048-1-abel.vesa@nxp.com>
 <YeslLJqwhX668+oa@robh.at.kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YeslLJqwhX668+oa@robh.at.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tjlGChBVGclOhQrxkC8oLxbp2lUslL7XY2KtiledLbWFJ0javsuqDbNZHuZC?=
 =?us-ascii?Q?dyHQTQ/j7Kd5sBiaONxB4Afc2NRIl2/0dsg8RekRf+Hx/cJVJ6lqg5Do/agU?=
 =?us-ascii?Q?jAENE1Mj127+H3bHrY+8iNAEh/Nmn/eidLs2nizaJ///BVQF+QcF0xjrYRXr?=
 =?us-ascii?Q?Qh863n9nF+ZN/c4zZzKufdrlRn/VkwljnCSyw1x77ll2dmGDTKbZIMskEIdn?=
 =?us-ascii?Q?ROyaepbVdfajC8iyvO8YE3a6SumdDXIkvFN6VCZ5AloV8BkI/AfFEAxqXDWc?=
 =?us-ascii?Q?AyfxmeRCWz2ytI5kmvhrftBO15kjDQvYhyi0AkLgVeQKAsBtRDuf8FMzrxaK?=
 =?us-ascii?Q?gdm0DWbQS9Pfse66AslMsnJCYXjWM9ehHTxGBbUXjFqC4nQDdvU4tLYthq8H?=
 =?us-ascii?Q?Jg6rVxd9RAd0VpLh+gyOalI5SqG7pIR36GEiLgrn4AXsmD9y9OraLbfd5fTi?=
 =?us-ascii?Q?Q0mCe1Ggcb/Bls470saA6zrBBJtYp6oWUSxPwfczbW5aLUNoeuAHDKUIDfgH?=
 =?us-ascii?Q?vWE6OyYqUs0HUZE2GsOvvWIIjzjEGmmRXxwm/8WNN9HW8g0Ka72xbT6qOkii?=
 =?us-ascii?Q?X3x6/a9qyA5kfYiJ55avJhPI+UHl3FZLG3E9FE5Z6vY9Rbe/7rhaZ/aATOdq?=
 =?us-ascii?Q?G7JR7LymVVUrXMzphjHdO0tbU8KKuQDcWdDBc/SjelKqymOLK1Y/dVy8oadw?=
 =?us-ascii?Q?PAf/CcaFZ3w+niLS0sAAaDnb3Bkvmu2dOyfSiUokkWkrWWzd+O4Tsrd4pu0d?=
 =?us-ascii?Q?4/YvHSApdqmb4OFzvD8Zh7z0deEm0ps33F6whD0mZitoObESpT/+sbt100fA?=
 =?us-ascii?Q?B8onKOEjubGLLToIMJjxmL98t9La1NSGi/c8/RyKDN9H68ml/RRymIIhmHVQ?=
 =?us-ascii?Q?iDlWS/Su3ccJ4UgziCAdF1tCviGdy7ygec5qjTQm8nz60sJRLBHpWM0/pUtY?=
 =?us-ascii?Q?Jiu7N2cKPRQ5kDUkwP0+8hgnALzcJtDYoneGJZaIil8pXizu40raFl+W0xN9?=
 =?us-ascii?Q?FuIBJzYXU+7CNKdZuYYIKRUcHbmGkz/bsbKyH7tYRejRoqJXmKpPr+mf1siX?=
 =?us-ascii?Q?5edj1EXB7llb5Ph8vpN6e3qsbNa2Fq2kXOtKiD/18Zbs/D8vbaTVBK/x+NlN?=
 =?us-ascii?Q?Q1uXg7MFm3F5bBR5Ey3qPkIT5PCCc8ors1TR0rLVbfHvzLI8bQ38JolfzaEY?=
 =?us-ascii?Q?k5xQeorml0lrmnlT7tGTVad3hZDLDYD7/Q7nPtvQKZb/6DvcI3F5Cs03rRFX?=
 =?us-ascii?Q?WxkYBv3TxE9WEAeaZ3uGLEIycwMFzDYRZ5cD7m8GBZlfvH+nq0pA5snDrYkT?=
 =?us-ascii?Q?QoHE8CYmsv7KAYuuzc27lBHFXWnWEp0cp+dbeFHiVGCEmyhb3WfjCXRcqSyy?=
 =?us-ascii?Q?TOimUaddyrNogZWyyrmA/si8Jg0W2/LU/xUXgkExOGvOXyV0Af+/eLX+eZRX?=
 =?us-ascii?Q?cq8Yro5P1AMtowIp5qZLdxBa2xuWlPp/3XSbrXpRPiFpS2/V5jgQwx0UPC/M?=
 =?us-ascii?Q?FxdymtSiMQBR5l/OnUHkTJ5MCu5bETH4AlilkEAjQTtnp3QBBcPG/tSIo7KI?=
 =?us-ascii?Q?ndnqWZ23sycTHYq8E9HrJmwkrLbFm9jnGRZCsHv/95XCqOFEct7lNEcya7Xd?=
 =?us-ascii?Q?0+VlZP0RZOvcuueurPr7mIo=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66ecdca6-d404-4f42-0d8f-08d9eccc106e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 19:32:24.4485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8FLWkNcurk1LhYxUKq3oFptihKoHerfRbs5gUd5KHvZ6c/W4SJSgIXYdkHwNNKqiv633JN+zlKGHNw5Cg05bgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3763
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-01-21 15:27:08, Rob Herring wrote:
> On Thu, Jan 06, 2022 at 06:41:48PM +0200, Abel Vesa wrote:
> > Add documentation for fsl,icc-id property.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> > 
> > Changes since v3:
> >  * fixed typo in property description
> > 
> >  .../devicetree/bindings/interconnect/fsl,imx8m-noc.yaml      | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > index b8204ed22dd5..dc7f6b6f508a 100644
> > --- a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > +++ b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > @@ -47,6 +47,11 @@ properties:
> >    operating-points-v2: true
> >    opp-table: true
> >  
> > +  fsl,icc-id:
> > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> > +    description:
> > +      unique ID used for linking i.MX bus or ddrc node to interconnect
> 
> Where does this unique ID come from and how is it used? Why aren't cells 
> in 'interconnects' sufficient for this?

Sorry for the late reply.

Well, the 'inteconnects' property is documented as a pair of
interconnect nodes, specifically source and destination (endpoints).

The fsl,icc-id is used here to allow the the imx-bus and imx8m-ddrc
nodes to specify which icc node it belongs to.

Basically, the 'interconnects' property is used by an icc consumer
to specify a path towards the target, while the fsl,icc-id is used
here to specify which icc node (in this case, not an endpoint)
belongs to which imx-bus or imx8m-ddrc device.

> 
> > +
> >    fsl,ddrc:
> >      $ref: "/schemas/types.yaml#/definitions/phandle"
> >      description:
> > -- 
> > 2.31.1
> > 
> >