Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Feb 2022 14:58:53 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Hugh Dickins <hughd@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        SeongJae Park <sj@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for-mm 1/2 v2] mm/internal: Implement no-op
 mlock_page_drain() for !CONFIG_MMU
Message-ID: <20220211145853.329ff344@canb.auug.org.au>
In-Reply-To: <8eae6026-098-befb-92d3-b9ad2ad57776@google.com>
References: <20220209094158.21941-1-sj@kernel.org>
        <20220209094158.21941-2-sj@kernel.org>
        <715a8b2e-1048-c098-8b89-bcf3c13cbd75@google.com>
        <CAMuHMdV7EaHK5zJAbLU9eKwMYxFdAQ0TiS+Ydg56mGkBv09dHA@mail.gmail.com>
        <8eae6026-098-befb-92d3-b9ad2ad57776@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/uzV4b3Z7XYHDfaFovndMX.Y";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/uzV4b3Z7XYHDfaFovndMX.Y
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Hugh,

On Wed, 9 Feb 2022 20:44:02 -0800 (PST) Hugh Dickins <hughd@google.com> wro=
te:
>
> From: SeongJae Park <sj@kernel.org>
>=20
> Commit 4b3b8bd6c8287 ("mm/munlock: mlock_page() munlock_page() batch by
> pagevec") in -mm tree[1] implements 'mlock_page_drain()' under
> CONFIG_MMU only, but the function is used by 'lru_add_drain_cpu()',
> which defined outside of CONFIG_MMU.  As a result, below build error
> occurs.
>=20
>     /linux/mm/swap.c: In function 'lru_add_drain_cpu':
>     /linux/mm/swap.c:637:2: error: implicit declaration of function 'mloc=
k_page_drain' [-Werror=3Dimplicit-function-declaration]
>       637 |  mlock_page_drain(cpu);
>           |  ^~~~~~~~~~~~~~~~
>     cc1: some warnings being treated as errors
>     /linux/scripts/Makefile.build:289: recipe for target 'mm/swap.o' fail=
ed
>=20
> This commit fixes it by implementing no-op 'mlock_page_drain()' for
> !CONFIG_MMU case, similar to 'mlock_new_page()'.
>=20
> [1] https://www.ozlabs.org/~akpm/mmotm/broken-out/mm-munlock-mlock_page-m=
unlock_page-batch-by-pagevec.patch
>=20
> [hughd: add need_mlock_page_drain() stub too]
> Signed-off-by: SeongJae Park <sj@kernel.org>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
> Andrew, Stephen, please add as fix to
> mm-munlock-mlock_page-munlock_page-batch-by-pagevec.patch
> Thanks!
>=20
>  mm/internal.h |    2 ++
>  1 file changed, 2 insertions(+)
>=20
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -508,6 +508,8 @@ static inline void mlock_vma_page(struct page *page,
>  static inline void munlock_vma_page(struct page *page,
>  			struct vm_area_struct *vma, bool compound) { }
>  static inline void mlock_new_page(struct page *page) { }
> +static inline bool need_mlock_page_drain(int cpu) { return false; }
> +static inline void mlock_page_drain(int cpu) { }
>  static inline void vunmap_range_noflush(unsigned long start, unsigned lo=
ng end)
>  {
>  }

Added to linux-next from today.

--=20
Cheers,
Stephen Rothwell

--Sig_/uzV4b3Z7XYHDfaFovndMX.Y
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmIF3v0ACgkQAVBC80lX
0Gw6SAf/YdMw2mcK7OcCmFZERxK4VtcnUrURgP2yV67H8pWoh3aYufIiNrTX8QWK
IL6uVdq7lXdjUD5JWcvlu7LRBIHicNfcbqSaHtBQJJlCYDbBc+Vnuk0EkFz8ERJC
3LwUxJnzrwYDz2C0uDma8tm5OGYnVzyAQYRmLXHtVRVtn3inOltpGo261fCuCzlU
w3ojkVO09YGG1uF1tZoDQlx/vXSqyNLI7uvn8jAA1pgPDqM3KmypQn/ZINpwihT5
c8SUMvx9tkPUTkXsKBLsHFyvtXC0egOynMcRUs3BGjnZHNnCRWUxv0ZIRB3SyVUu
0xiKlfryatRYI9O1++ksAjlmlFa7IA==
=n70x
-----END PGP SIGNATURE-----

--Sig_/uzV4b3Z7XYHDfaFovndMX.Y--