Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Saleem, Shiraz" <shiraz.saleem@intel.com>
To:     Victor Erminpour <victor.erminpour@oracle.com>,
        "Ismail, Mustafa" <mustafa.ismail@intel.com>
CC:     "jgg@ziepe.ca" <jgg@ziepe.ca>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "trivial@kernel.org" <trivial@kernel.org>
Subject: RE: [PATCH] RDMA/irdma: Fix GCC 12 warning
Thread-Topic: [PATCH] RDMA/irdma: Fix GCC 12 warning
Thread-Index: AQHYHhXpIKGNtR9Qu0Cesy+E4ixcfayNV7Tw
Date:   Thu, 10 Feb 2022 22:09:18 +0000
Message-ID: <35240f17968242409a39427c303370df@intel.com>
References: <1644453235-1437-1-git-send-email-victor.erminpour@oracle.com>
In-Reply-To: <1644453235-1437-1-git-send-email-victor.erminpour@oracle.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

> Subject: [PATCH] RDMA/irdma: Fix GCC 12 warning
>=20
> When building with automatic stack variable initialization, GCC 12 compla=
ins about
> variables defined outside of switch case statements.
> Move the variable into the case that uses it, which silences the warning:
>=20
> ./drivers/infiniband/hw/irdma/hw.c:270:47: error: statement will never be=
 executed [-
> Werror=3Dswitch-unreachable]
>   270 |                         struct irdma_cm_node *cm_node;
>       |
>=20
> ./drivers/infiniband/hw/irdma/utils.c:1215:50: error: statement will neve=
r be executed
> [-Werror=3Dswitch-unreachable]
>   1215 |                         struct irdma_gen_ae_info ae_info;
>        |
>=20
> Signed-off-by: Victor Erminpour <victor.erminpour@oracle.com>
> ---
>  drivers/infiniband/hw/irdma/hw.c    | 2 +-
>  drivers/infiniband/hw/irdma/utils.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/ird=
ma/hw.c
> index 89234d04cc65..a41a3b128d0d 100644
> --- a/drivers/infiniband/hw/irdma/hw.c
> +++ b/drivers/infiniband/hw/irdma/hw.c
> @@ -267,8 +267,8 @@ static void irdma_process_aeq(struct irdma_pci_f *rf)
>  		}
>=20
>  		switch (info->ae_id) {
> -			struct irdma_cm_node *cm_node;
>  		case IRDMA_AE_LLP_CONNECTION_ESTABLISHED:
> +			struct irdma_cm_node *cm_node;
>  			cm_node =3D iwqp->cm_node;
>  			if (cm_node->accept_pend) {
>  				atomic_dec(&cm_node->listener-

This doesn't compile.

drivers/infiniband/hw/irdma/hw.c: In function \u2018irdma_process_aeq\u2019=
:
drivers/infiniband/hw/irdma/hw.c:271:4: error: a label can only be part of =
a statement and a declaration is not a statement
  271 |    struct irdma_cm_node *cm_node;

Seems like we are accommodating for gcc12 bug since this C code is legit?=20

Shiraz