Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030531AbXBLXtQ (ORCPT ); Mon, 12 Feb 2007 18:49:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030526AbXBLXtQ (ORCPT ); Mon, 12 Feb 2007 18:49:16 -0500 Received: from out5.smtp.messagingengine.com ([66.111.4.29]:33403 "EHLO out5.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030521AbXBLXtO (ORCPT ); Mon, 12 Feb 2007 18:49:14 -0500 X-Sasl-enc: TH8g5S0gj9uoxAp2aSdfSh/DakilSFESzVAcwKwoGjzH 1171324151 Message-ID: <45D0FD26.9030804@imap.cc> Date: Tue, 13 Feb 2007 00:49:58 +0100 From: Tilman Schmidt Organization: me - organized?? User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.8.0.9) Gecko/20061211 SeaMonkey/1.0.7 Mnenhy/0.7.4.666 MIME-Version: 1.0 To: Greg KH CC: Andrew Morton , Karsten Keil , Linux Kernel Mailing List , i4ldeveloper@listserv.isdn4linux.de, linux-serial@vger.kernel.org, Hansjoerg Lipp , Alan Cox Subject: Re: [PATCH] drivers/isdn/gigaset: new M101 driver References: <200702012112.l11LCOO4016557@lx1.pxnet.com> <20070201171345.bd98ce30.akpm@osdl.org> <20070203160932.GA32523@kroah.com> <45C52848.50705@imap.cc> <20070212184712.GC32607@kroah.com> In-Reply-To: <20070212184712.GC32607@kroah.com> X-Enigmail-Version: 0.94.1.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig416C1B2D87FC86DBF3955FA2" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2106 Lines: 60 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig416C1B2D87FC86DBF3955FA2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 12.02.2007 19:47 schrieb Greg KH: >>>>> +static void gigaset_device_release(struct device *dev) >>>>> +{ >>>>> + //FIXME anything to do? cf. platform_device_release() >>>>> +} > The memory of the platform device itself needs to be freed here, > otherwise, to do it earlier would cause race conditions and oopses. I don't do it earlier. I do it later. My platform_device structure is part of my driver's device state structure which is freed explicitly later after the call to platform_device_unregister(). Is that bad? > Look at how the other platform drivers do things. They do things differently from each other as well as from mine. block/floppy.c, for example, just has a call to complete() there. Anyway, in the latest version of my driver, its platform_device release function finally does something, too: it frees dev->platform_data and pdev->resource just in case something might have materialized there. I hope that's ok. Regards, Tilman --=20 Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Unge=F6ffnet mindestens haltbar bis: (siehe R=FCckseite) --------------enig416C1B2D87FC86DBF3955FA2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3rc1 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFF0P0uMdB4Whm86/kRAtUuAJ4/66YsinszZR3vd9tjFQD5xKzJigCdHE9w lBfcHwSZT9mBjjsUgBBmShQ= =q1e5 -----END PGP SIGNATURE----- --------------enig416C1B2D87FC86DBF3955FA2-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/