Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220210230819.3303212-1-frowand.list@gmail.com>
In-Reply-To: <20220210230819.3303212-1-frowand.list@gmail.com>
From:   Naresh Kamboju <naresh.kamboju@linaro.org>
Date:   Fri, 11 Feb 2022 16:59:25 +0530
Message-ID: <CA+G9fYvuk-vhRXU1ncz51WJfbR3CZ=VgY9SZmw9Qoub6P2NeWA@mail.gmail.com>
Subject: Re: [PATCH 1/1] of: unittest: print pass messages at PR_INFO level
To:     frowand.list@gmail.com
Cc:     Rob Herring <robh+dt@kernel.org>,
        Brendan Higgins <brendanhiggins@google.com>,
        Anders Roxell <anders.roxell@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 11 Feb 2022 at 04:38, <frowand.list@gmail.com> wrote:
>
> From: Frank Rowand <frank.rowand@sony.com>
>
> Printing the devicetree unittest pass message for each passed test
> creates much console verbosity.  The existing pass messages are
> printed at loglevel KERN_DEBUG so they will not print by default.
>
> Change default to print the pass messages at loglevel PR_INFO so
> they will print with the default console loglevel.
>
> The test community expects either a pass or a fail message for each
> test in a test suite.  The messages are typically post-processed to
> report pass/fail results.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

Test log link,
https://lkft.validation.linaro.org/scheduler/job/4529628#L1697

> ---
>
> One review comment to similar previous patch "of: unittest: print
> pass message as same lovlevel as fail" suggested to also change
> the text of the pass message to include "PASS" instead of "pass".
> I would rather leave the text unchanged to minimize churn for any
> existing users of the message.  It is my intention to change the
> pass and fail messages to KTAP version 2 format as soon as that
> version of the specification is completed.
>
>  drivers/of/unittest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 70992103c07d..9012e6900965 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -44,7 +44,7 @@ static struct unittest_results {
>                 pr_err("FAIL %s():%i " fmt, __func__, __LINE__, ##__VA_ARGS__); \
>         } else { \
>                 unittest_results.passed++; \
> -               pr_debug("pass %s():%i\n", __func__, __LINE__); \
> +               pr_info("pass %s():%i\n", __func__, __LINE__); \
>         } \
>         failed; \
>  })
> --
> Frank Rowand <frank.rowand@sony.com>


--
Linaro LKFT
https://lkft.linaro.org