Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Feb 2022 11:49:51 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Jon Lin <jon.lin@rock-chips.com>
Cc:     heiko@sntech.de, linux-spi@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] spi: rockchip: terminate dma transmission when slave
 abort
Message-ID: <YgZNX4ZuSumZ/Yie@sirena.org.uk>
References: <20220211034344.4130-1-jon.lin@rock-chips.com>
 <20220211034344.4130-6-jon.lin@rock-chips.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rmnoW3paj3umB6SM"
Content-Disposition: inline
In-Reply-To: <20220211034344.4130-6-jon.lin@rock-chips.com>
Precedence: bulk


--rmnoW3paj3umB6SM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 11, 2022 at 11:43:42AM +0800, Jon Lin wrote:

> After slave abort, all DMA should be stopped, or it will affect the
> next transmission:

Again, this is a fix and should be at the start of the series.

>=20
> [   31.693877] Unable to handle kernel paging request at virtual address =
ffffff8105a2a7c0
> [   31.694643] Mem abort info:
> [   31.694898]   ESR =3D 0x96000045
> [   31.695179]   EC =3D 0x25: DABT (current EL), IL =3D 32 bits
> [   31.695653]   SET =3D 0, FnV =3D 0
> [   31.695931]   EA =3D 0, S1PTW =3D 0

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

--rmnoW3paj3umB6SM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIGTV4ACgkQJNaLcl1U
h9C1KQf9GVPQqLpAYXPnTVXWv2GgFuiO3xWPa4fGn6NFNruqsC9kG0ILuIzo96nt
Rt7bz7N2dqWB0CuQHZnyAPMmIe97An8dmUZkb1o4DzJVrQyQteZ1X6YQekbpvpSO
kYS7IBZTqmQckxR0xKm9Wj9Sb6N+eZ3evbKgF+rGU1eIOeC0Qvaqd6QyNbddWEfB
PuU4UpH42zkWR/tzrTM2sdZy82aylHomTEHRn1f+/bhOrPna9bn6PbV2nuJ5nOeN
g4ARZsoRuFPYXn9dBvptd/YNinUyxuOLYgqyYl+r/XDgR7CPSH44s81EnsKNYO3N
9zmtydE+XHf6scVEtKuzSoilb26imw==
=5FlO
-----END PGP SIGNATURE-----

--rmnoW3paj3umB6SM--