Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17f233db-9591-3093-5e63-29e1c8f4b237@gmx.de>
Date:   Fri, 11 Feb 2022 10:39:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] video: s3c-fb: Use platform_get_irq() to get the
 interrupt
Content-Language: en-US
To:     zhaoxiao <zhaoxiao@uniontech.com>, jingoohan1@gmail.com
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220211032755.2271-1-zhaoxiao@uniontech.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220211032755.2271-1-zhaoxiao@uniontech.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 2/11/22 04:27, zhaoxiao wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypassed the hierarchical setup and messed up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>

applied.
Thanks!
Helge

> ---
>  drivers/video/fbdev/s3c-fb.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 3b134e1bbc38..6ead7d3e2312 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1360,7 +1360,6 @@ static int s3c_fb_probe(struct platform_device *pd=
ev)
>  	struct device *dev =3D &pdev->dev;
>  	struct s3c_fb_platdata *pd;
>  	struct s3c_fb *sfb;
> -	struct resource *res;
>  	int win;
>  	int ret =3D 0;
>  	u32 reg;
> @@ -1418,13 +1417,13 @@ static int s3c_fb_probe(struct platform_device *=
pdev)
>  		goto err_lcd_clk;
>  	}
>
> -	res =3D platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -	if (!res) {
> +	sfb->irq_no =3D platform_get_irq(pdev, 0);
> +	if (sfb->irq_no < 0) {
>  		dev_err(dev, "failed to acquire irq resource\n");
>  		ret =3D -ENOENT;
>  		goto err_lcd_clk;
>  	}
> -	sfb->irq_no =3D res->start;
> +
>  	ret =3D devm_request_irq(dev, sfb->irq_no, s3c_fb_irq,
>  			  0, "s3c_fb", sfb);
>  	if (ret) {
>