Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3759775pxb; Fri, 11 Feb 2022 07:11:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzAKGWKQqPK2O92zEYfoxjsgMxtTbcE2UEml7FWx5++PmHUU6ScoEasnNGO1mxqB7JiwjYN X-Received: by 2002:a17:902:c94c:: with SMTP id i12mr1896014pla.139.1644592311792; Fri, 11 Feb 2022 07:11:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644592311; cv=none; d=google.com; s=arc-20160816; b=eWUxoKnlD9uWoj4GLdLzV8qmCSk/OcS856lIciGbT/xgox10xlOPbRtcCiEPAhIFAt TMs+pxDi1nafyn+zXJ7Ti1EdFZAL6xHw1AGM5JjxY/f/PjHXx6mLcmRQzMUYICLAMWp7 trCuspsBgVINNNfGwxWWNXtFcdNKMB8pT7HtPqyaHPkd6WUxSoO89F1Fryv2Q6bWQbjQ wBuBPMoudwNTY9o3+ofEkCymmIuPMmJ48bvsy/M6VjFpIJbY3U7xRduiqktD6jITYndk Yv+JR8TkyQjttvwEL/CF6nDGF8tcpvjupBFlOCpQdoDliZ3uNKrqIR63TEaVOjCGQ+YM C14Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=HDmK2s/pTcFfYxRMuLAfrTftC0PiNZvTeDMfBY1FLuQ=; b=kkaOfNwk1AfJ/oRObeQOsz8b15Neia4sL3NB637RAIR7wgnJbKOzP2ywuvUaTi+Llr /zy3hZvnW18g1aB6yi3PEYqQBn7w5rkOM+MHyrmbzzHV6hZnTL4s5za+nnxPLgmLaZc0 KEhK/F8kv1Jv+5VyrLFNsx8qJrrZT6hWjkYLjL0tozesmicg86b4fjIMbTEkFpYctYUL Xthg5cqwV5wwe7/wVwRk5iVQwlh9RDcV3yotldPbMkI4xjX4oByhQ2MEe1XuhJm9fd90 jjq+QyEJJCRcKidpZqJtxiGGpZt64tU0+i82PEBy4jsSSF4O8cvoqh/rf8D3KJbXn7Hr KK/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 186si21519021pgc.174.2022.02.11.07.11.35; Fri, 11 Feb 2022 07:11:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241898AbiBKDxi (ORCPT + 99 others); Thu, 10 Feb 2022 22:53:38 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240594AbiBKDxd (ORCPT ); Thu, 10 Feb 2022 22:53:33 -0500 Received: from mail-m17664.qiye.163.com (mail-m17664.qiye.163.com [59.111.176.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94BAF5F75; Thu, 10 Feb 2022 19:53:31 -0800 (PST) Received: from localhost.localdomain (unknown [58.22.7.114]) by mail-m17664.qiye.163.com (Hmail) with ESMTPA id 3BDCC1401C9; Fri, 11 Feb 2022 11:43:53 +0800 (CST) From: Jon Lin To: broonie@kernel.org Cc: heiko@sntech.de, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jon Lin Subject: [PATCH 6/6] spi: rockchip: clear interrupt status in error handler Date: Fri, 11 Feb 2022 11:43:43 +0800 Message-Id: <20220211034344.4130-7-jon.lin@rock-chips.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220211034344.4130-1-jon.lin@rock-chips.com> References: <20220211034344.4130-1-jon.lin@rock-chips.com> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUJMGR5WSUlJT05DGEoZGB 1LVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWVVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OjI6TCo6SD5NTx4JTQ4IF0tK OhIwCjZVSlVKTU9PTk5KS0hITUxJVTMWGhIXVREUFVUXEhU7CRQYEFYYExILCFUYFBZFWVdZEgtZ QVlOQ1VJSVVMVUpKT1lXWQgBWUFKQkJMNwY+ X-HM-Tid: 0a7ee6e15238da2fkuws3bdcc1401c9 X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The interrupt status bit of the previous error data transmition will affect the next operation and cause continuous SPI transmission failure. Signed-off-by: Jon Lin --- drivers/spi/spi-rockchip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 3d4e95eda4a6..bc547b79a2a1 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -278,8 +278,9 @@ static void rockchip_spi_handle_err(struct spi_controller *ctlr, */ spi_enable_chip(rs, false); - /* make sure all interrupts are masked */ + /* make sure all interrupts are masked and status cleared */ writel_relaxed(0, rs->regs + ROCKCHIP_SPI_IMR); + writel_relaxed(0xffffffff, rs->regs + ROCKCHIP_SPI_ICR); if (atomic_read(&rs->state) & TXDMA) dmaengine_terminate_async(ctlr->dma_tx); -- 2.17.1