Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH bpf-next 1/2] bpf: Add some description about
 BPF_JIT_ALWAYS_ON in Kconfig
To:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>
Cc:     Xuefeng Li <lixuefeng@loongson.cn>, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1644569851-20859-1-git-send-email-yangtiezhu@loongson.cn>
 <1644569851-20859-2-git-send-email-yangtiezhu@loongson.cn>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <4b4431d4-4ad4-19b2-dd03-688165e3d470@iogearbox.net>
Date:   Fri, 11 Feb 2022 15:44:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <1644569851-20859-2-git-send-email-yangtiezhu@loongson.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/11/22 9:57 AM, Tiezhu Yang wrote:
> When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently
> set to 1 and setting any other value than that will return in failure.
> 
> Add the above description in the help text of BPF_JIT_ALWAYS_ON, and then
> we can distinguish between BPF_JIT_ALWAYS_ON and BPF_JIT_DEFAULT_ON.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>   kernel/bpf/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
> index d24d518..88409f8 100644
> --- a/kernel/bpf/Kconfig
> +++ b/kernel/bpf/Kconfig
> @@ -58,6 +58,9 @@ config BPF_JIT_ALWAYS_ON
>   	  Enables BPF JIT and removes BPF interpreter to avoid speculative
>   	  execution of BPF instructions by the interpreter.
>   
> +	  When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently
> +	  set to 1 and setting any other value than that will return in failure.

Small nit here: lets use the full path (/proc/sys/net/core/bpf_jit_enable) in order
to be consistent with the other descriptions in this Kconfig.

>   config BPF_JIT_DEFAULT_ON
>   	def_bool ARCH_WANT_DEFAULT_BPF_JIT || BPF_JIT_ALWAYS_ON
>   	depends on HAVE_EBPF_JIT && BPF_JIT
>