Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161006AbXBME4K (ORCPT ); Mon, 12 Feb 2007 23:56:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161018AbXBME4K (ORCPT ); Mon, 12 Feb 2007 23:56:10 -0500 Received: from raven.upol.cz ([158.194.120.4]:48059 "EHLO raven.upol.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161006AbXBME4J (ORCPT ); Mon, 12 Feb 2007 23:56:09 -0500 Date: Tue, 13 Feb 2007 06:05:03 +0100 To: Linus Torvalds Cc: Tony Luck , LKML , Andrew Morton , Jesper Juhl , Roman Zippel , Bastian Blank , Sam Ravnborg Subject: Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files Message-ID: <20070213050503.GA27441@flower.upol.cz> References: <20070206011819.160359000@flower.upol.cz> <20070206012208.050237000@flower.upol.cz> <12c511ca0702121409t30e126dfh445d13dd2f637e08@mail.gmail.com> <20070213003258.GA15534@flower.upol.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070213003258.GA15534@flower.upol.cz> Organization: Palacky University in Olomouc, experimental physics department. User-Agent: Mutt/1.5.13 (2006-08-11) From: Oleg Verych Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1065 Lines: 24 [] > > The old code did the same thing, but with the "make" $(sort ..) function, > > which apparently removes duplicates. We should use "sort -u" here. > > Heh. Why one ever going to bloat $(srctree) to add more "dontdiff" and > such, where build is supporting dirty output? I mean, all by-hand modifications must be in the $(srctree) (let's get this term), $(objtree) is output *only*. Thus, i would propose to remove it from the path. Even dynamic SCM mechanism of adding local version doesn't use `localversion' files. > any reasons to have multiple files for localversion(s), in $(objtree) > also? Exept one, that somebody used to use it, mm-tree doesn't btw. I know it maybe another my "change it all" proposition, but i can't find nothing against `GNU $(wildcard ..)' and `unnecessarily complex "find"'. ____ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/