Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Feb 2022 20:20:52 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Mark Hemment <markhemm@googlemail.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>,
        John Hubbard <jhubbard@nvidia.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        William Kucharski <william.kucharski@oracle.com>
Subject: Re: [PATCH 20/75] mm/gup: Convert gup_pte_range() to use a folio
Message-ID: <YgbFJCb/wwN+3+AV@casper.infradead.org>
References: <20220204195852.1751729-1-willy@infradead.org>
 <20220204195852.1751729-21-willy@infradead.org>
 <CANe_+Ugjtu2zw8i3CyCU3mu71L7Gh_etuj_5t64Bx7y7+fj2jA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANe_+Ugjtu2zw8i3CyCU3mu71L7Gh_etuj_5t64Bx7y7+fj2jA@mail.gmail.com>
Precedence: bulk

On Sun, Feb 06, 2022 at 02:52:46PM +0000, Mark Hemment wrote:
> On Fri, 4 Feb 2022 at 20:21, Matthew Wilcox (Oracle)
> <willy@infradead.org> wrote:
> V. Minor/nit: Above the "goto pte_unmap;" is the code block;
>            if (flags & FOLL_PIN) {
>                         ret = arch_make_page_accessible(page);
>                         if (ret) {
>                                 unpin_user_page(page);
>                                 goto pte_unmap;
>                         }
>                 }
> Other conditions which goto pte_unmap, after successful
> try_grab_folio(), call gup_put_folio() (rather than
> unpin_user_page()).
> No change in functionality, but suggest calling gup_put_folio() here
> too for consistency.

Thanks!  Changed.