Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c60c9fe4-cfb1-9df2-eb57-66b41149d7db@amd.com>
Date:   Fri, 11 Feb 2022 09:00:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: Terry.Bowman@amd.com
Subject: Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release
 code into functions
Content-Language: en-US
To:     Wolfram Sang <wsa@kernel.org>, Jean Delvare <jdelvare@suse.de>,
        linux@roeck-us.net, linux-watchdog@vger.kernel.org,
        linux-i2c@vger.kernel.org, andy.shevchenko@gmail.com,
        rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
        wim@linux-watchdog.org, rrichter@amd.com, thomas.lendacky@amd.com,
        sudheesh.mavila@amd.com, Nehal-bakulchandra.Shah@amd.com,
        Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com,
        Mario.Limonciello@amd.com
References: <20220209172717.178813-1-terry.bowman@amd.com>
 <20220209172717.178813-4-terry.bowman@amd.com>
 <20220211105322.180ad89d@endymion.delvare> <YgZ12hCMUlqtLKD3@kunai>
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <YgZ12hCMUlqtLKD3@kunai>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VG1yRFk1aXN6TkNYa2twYzlLV1BMelRuOVE5RkZkQWF2RmowNm1QWGNsZ3I5?=
 =?utf-8?B?cS9MenZLOHB3NnlVVFRxaUhmUEV5ZERVRjlMVStKOHY5bURIbmNJNzMwWkR3?=
 =?utf-8?B?YXlqNUpXV2lBQUxIL1NhL3czdWx5NE41QnJaMEVtUmxqVEhjbGxSaWIxSjVn?=
 =?utf-8?B?UWhLMzMwMHNvTVZpSFVqZ3pJaXZyL3MrcDR2bXBNb3kySmlVc0dqOUZRenJO?=
 =?utf-8?B?RVFKMXNiUHFKQUNnazVQZDNiWGtic04zbGJUdFIwV0NHb3pXYjV6bFFEdnR2?=
 =?utf-8?B?LzhuTVBNWjFCTXFCd1FVQ0ZHd2tGM3RYV3hhMThqZDhwT2JsTzJtY25Eb0to?=
 =?utf-8?B?RlVqMEg2bUxOOFhDL3lnbkI4amFTK2tCUWVsc0ZGWXB3TE9ZL0VvMk01M2da?=
 =?utf-8?B?dFNYM2pQQ3NZc0U4L0piL3Z5aDlYVnF3c2RQQ0ZqaWNQNzA1dW44QnB0RlVw?=
 =?utf-8?B?WVRCSko5M2M0NFRseldwbUtrSUkvZFQxZ1ZubXhCQVlVcW9IQzVRZG5SOXJN?=
 =?utf-8?B?NmdsNVNYbHRuNDZUSFMyYXhkTlE5WG5na0dia0xaWGtGSWVCcjg0azg5T1B6?=
 =?utf-8?B?T3llTE4zQmJLMzd3MHhvanM1SjNFNlRRVFVXM09NTVJXUFhvc0FYQnhKaHd6?=
 =?utf-8?B?S2JTQmVGWjQzTWw4Vjk2a1ZGSWo2aUptWVVZWWtMMHpFTlNNVTFadHVqVmc5?=
 =?utf-8?B?V1JQdjh0K2VidTl2bU8rdGVtQWhzMVNqaUpOYS9TL1pVZVFGMUxZdDZTVlRI?=
 =?utf-8?B?UHNJSW8xb1lwQzFnUENPUEhiYVIzQjJORTJjMHM3TVNPQmFPUmFBaG5BWEJZ?=
 =?utf-8?B?elRKcGRZTUgxdkxCZWM5TWdicDZkT1VSdHEzWHhuT2ErVGQweGJzY0dOem9K?=
 =?utf-8?B?aDVDNGwyL2djSHo4cFdMN0NKYzI5ZTlEdU04YW1nb1l5ZkdoMEI3QVBmam0w?=
 =?utf-8?B?OFphbmJKUzFCRDNTdEM0bUF3QkgyZFE5Z0lkNjRzN0tscXVLTkhjcWlDdDZS?=
 =?utf-8?B?bThDRlBmeFhQMUJWS3NsYVRSMVhtQU95OTdhN0Q5WXBvcDBPMjE2RTUxVGdQ?=
 =?utf-8?B?eGRsamdNNHpORmU5OXJXLzNJK1NCOWUzV2R4bGlyZVkxcDZJQVN2bEt0UlVZ?=
 =?utf-8?B?YWE5SHN1ampaQlFHS2lrVnhEVk91L054Nys1djRQbFBxeHNPWVNZaEk1V0sv?=
 =?utf-8?B?RnV2TEtBcytlQ2U5VXJGKzNLUWlxRjFlbkMzMllUYkoxTWMrRTBxWGlrUEov?=
 =?utf-8?B?OG45Q3VQd0tPUktBUHZiU29MQWNObFJJUTN2MklEcTNDN2pmN0M5cGo0UGxK?=
 =?utf-8?B?bmpFbFpyNGhHUnI0di9xb1B1Ykd4cDFQcUtQaVJacXRGQWFhc0dyNFpFOThr?=
 =?utf-8?B?czNWbTkrTFdZM3JnVFdHOXpCUFBVcXBJYnU3L0ROV0M3WFJnNzFzSCtPd0xL?=
 =?utf-8?B?RGhsR2hUM2V4UElBS2hCMTVmU1dTWVhtbC9KRzhrRVVJUXV6K2d1SStIcjFp?=
 =?utf-8?B?T1FFQnUwVlFrYXoydHNLMkQ3WnNEb3BUaFJxanMvOGxCSEtWOWJ3SmtmQXBs?=
 =?utf-8?B?ZXJTQ2tteGtwODdPZWc3TXp5YUZlTVlWck9Nb0psc2FUa3BmNUl1Z0tMdnAz?=
 =?utf-8?B?cnR1MWh0N1V5VXNpOXdMVmM0RldTZGVoYmJiSkpRUXZEaEpuT1dNWWNnVFd0?=
 =?utf-8?B?VnVEN01reUwxakk3MEUzUytZak55aWlnOW5EVXNUNDBXZmVBME9FWE1HR2VB?=
 =?utf-8?B?aU5oUHEvdU9pT2RMa21QRlZRRTdjV3l5blBHUk9mVHo3Q3Z4TXdmcFhhMEpE?=
 =?utf-8?B?WEFRV1QyUHIvTG4xWmI3VCs3RFdFNlovUmIxd0ZxZUV2cnk3RVVYUW1OOWhu?=
 =?utf-8?B?ZW40MFFrUlBUSGdDdXEyeXBtQ21KTmJmS0cwd0Q5dUtLNktJbEZSUk44dmUx?=
 =?utf-8?B?dUlXdmJLNHVsWXdqbklwTXpIaVZscjNQdWcrWWZOSFNscWxYVUU4VG13Z2FM?=
 =?utf-8?B?WGJ1Q3RDc1RCQVBwcXlOM0xMczlveWFIT3Y3eXNyR20yMVZtZ2lpSVlUT0o1?=
 =?utf-8?B?M0VkMy9JV05qaExZbFpkQ3hRWUlJZXlVbmtDMU1rWURNd0cwWkF4bk9YbnRw?=
 =?utf-8?B?K1haeVE3eGRnNGlwdTFGdWFWNWt3bmh5Y2ZuTWZ2QWZtMkY0ODRIeU4zbStu?=
 =?utf-8?Q?XNbmkjn0p90sIEUT4Da5ITE=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3111d7d0-b28c-4246-e982-08d9ed6f3a42
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5346.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 15:00:22.8938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PZ+nbcIUZu4VpkndB4WnZLkzgixmnw2XJ9wulrAeIP4+jHp46iumgS6Gc9dCYhWVWWecnm3hDQ1svfPZtZnc9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5358
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Wolfram and Jean,

On 2/11/22 08:42, Wolfram Sang wrote:
>>> +		if (retval)
>>
>> Missing curly brace here, breaks the build.
> 
> Bummer, need to check why this wasn't found by my build-testing.
> 
> I fixed it up and also rebased patch 6 to my change. Terry, please have
> a look that I did everything correctly once I push out later today.
> 
> Thanks everyone!
> 
I need to look at how I sent that out. I will look for the fix in 
i2c/for-next. Thanks for the help and review.