Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <955957ed-7201-71da-7a88-659da592fdb6@amd.com>
Date:   Thu, 10 Feb 2022 11:36:23 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: start sorting out the ZONE_DEVICE refcount mess v2
Content-Language: en-US
To:     Christoph Hellwig <hch@lst.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>
Cc:     nvdimm@lists.linux.dev, Ralph Campbell <rcampbell@nvidia.com>,
        Alistair Popple <apopple@nvidia.com>,
        dri-devel@lists.freedesktop.org, Karol Herbst <kherbst@redhat.com>,
        linux-mm@kvack.org, nouveau@lists.freedesktop.org,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, Jason Gunthorpe <jgg@ziepe.ca>,
        Ben Skeggs <bskeggs@redhat.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
References: <20220210072828.2930359-1-hch@lst.de>
From:   "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>
In-Reply-To: <20220210072828.2930359-1-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDVFOFdnekhzMXNwQURpbHl6NndTcllGUnBuSjBOeVk4RWx1OXdCeUdYL24y?=
 =?utf-8?B?TXNxMzVrcEgyRXVTTThyc0hFbWcwR09XeTBZcWNrRFliUnB3a0g0Rnp0eVlD?=
 =?utf-8?B?Q0haZ3FUTGY1ODM3WVUwMGpHV0pMRDEzcG5oV0FPakJnZzZ2NEZmUThXSkZQ?=
 =?utf-8?B?NVpPZkkvaThHV0U5QllIRHYzcWYxSklyenJELzRvMzNYeUxhcC9xbU91bUZr?=
 =?utf-8?B?dXdPbG9WRENYb01KSWg3bkgwWmtReC81Ukl1NmlpWGprRVY2YlBqSldlRXUw?=
 =?utf-8?B?VENpQ201N3l1WTJJS1E4dFIyLzN5R3JLQjdCNnBhUmk4c2IvbTVDVHlOZmxE?=
 =?utf-8?B?Q2VzR21LMEl6TGlDS2tlTTZsQWVEcjN1Y0JRUnJxMWNPdngrQkRWemtWb2xE?=
 =?utf-8?B?UmNrMURCRUovcU10UnJMUSs5RFpLS1A2Z01nb2JkNmFOMWVMT3kyL1FlS1Z6?=
 =?utf-8?B?emh6d0k5R1ZxSzdhZDVUelNxdDAwL0wvS0orUTNmS2RqUFdVanlWT0s0eDRi?=
 =?utf-8?B?azl1L0tWSm5nVWZGR1RpNDBlaEtzcG80NjI1Z1lndnQvQ2YrQlZ0Z1BnZUhx?=
 =?utf-8?B?SFlQYTVXS1Bha2NBRXdXcmQ3eGVWek5DWmVLTzhpSTdZNlhPRFQ5QURpd1RR?=
 =?utf-8?B?WnlXNFE5M2s1dEwyTVQ1ejBUYitHcUhWeFQ3Y0JjeEU3bUZXa1V6Qi94Zmor?=
 =?utf-8?B?NFlLemZ6aUxaWW10OFJHLy9CUGRlUHA2YVpjekdCbUVCbmo0Yk83VFViOGwv?=
 =?utf-8?B?TUJpTzMyR1FxQTFIcVFqSS8zbXVNSFJQSnhQWVhvK2t3SnE5S1BrS2VUZXBP?=
 =?utf-8?B?amt1MlAzMXBSVTdka2FJUjFlclJ6eGJhazh0RFpYTmNweStEeXd4TjdheDR5?=
 =?utf-8?B?VmQyeXlIMG12ZHo0MGR4dVJSSlM0ZUg3VEx0VDZ2alFJbUk4bllxNnFEcS8r?=
 =?utf-8?B?bjFXRXRYdmlKLzBHTlI3RUdlRkRGcit6cUUrK1VEYlcxWVk3S2xvRlZpcGg4?=
 =?utf-8?B?WkUzN1dxcUZxdTRhdWhUNm80cVBvUkZyZFl0aUc2eHV5WUFlMno4dzliQTNi?=
 =?utf-8?B?SUVEN2d3VUlXelVlcUtCczVPS3hWL1V3UllQYUI5YTMzMERpU0o4TzluZk5H?=
 =?utf-8?B?UFdLVEpHb0xuMnBLejcxcjQ5ay9nWHQvVENZOTlVNWNyV2duQmNROVZ5ZHN5?=
 =?utf-8?B?cmFUaXZITVdkWW5vUmpYTWhWZjh3a0J0UGJRamRlVU9ya0tNekpLeWlwUGRN?=
 =?utf-8?B?SW9iNXhiWDNFdmlpTkM1N0RTL0N4K1NBNk1oNk5ZM2RrRjNmcTNpL2RMUUw4?=
 =?utf-8?B?SnBNdEpaQlFHWUJmWWpjTnczRnVGUWd4NUtWUENXOE9LTDB5Rzg3eEhMTFN4?=
 =?utf-8?B?Y0R2SmxTcTI5ODE4MFpqRFJYbXMybE4wUVllS1BTTUVORmdMZFJpa3AxdFdu?=
 =?utf-8?B?THhFdVVhTlpCYXZNTktwOWxBVVBHbXNDSXhJUWZPaUhtekczZ3BHSWdWaFNn?=
 =?utf-8?B?bCswSmJiaFovMStiWW9CWTdUTDFBTzZCQnI2L2UvaGE0cktua0pFWmVjY0ZM?=
 =?utf-8?B?TXkrYkJ3ZEFCeW9pOW1BK3dSQVgvZ0RQVHBEUmhGMWRHZVZzc3I0VEhoSG1O?=
 =?utf-8?B?bytXUFlBZ25hWU5EZ1JtYkNNUm1vTi9YM2U5Mm5XRzJuZTBQcU1mUGpXNDdv?=
 =?utf-8?B?WVNYRzFtajY1bEJVTW1TWDNMaThPV3JIUmVjaHQ0RnRpTEFHWjUvTzVFcWRy?=
 =?utf-8?B?eFRPVk9sVHRValJGZi85Z3JNSStqM2w2YW8zV2wrZnc2OUc1aEhkSjdudjA0?=
 =?utf-8?B?bEdpREwrUGtMTnNHOG1JY0xsR3lEQTJIZWJOdzB6dHhOb0pqNE9XMHlzaWJi?=
 =?utf-8?B?ZDFrakhPWWkzNm1UWjVpbnM5Q25vU1lWSWRYY2lSSk9QcTNWVkxGOUFTRDh3?=
 =?utf-8?B?RVNKL2grSnpFU3BZTjlBNmEyV01uYTFJUUx3Z1lkNWdlbHdGSXRmbmJpSDRE?=
 =?utf-8?B?elhVeEJLMDFicnVqSzRrMFdVUGwzbXdXN21COHhzb3hsZlBjVGZtMWlJMU4z?=
 =?utf-8?B?aWNtcHFsVVhiRGJDcFlvL3hJSms5MWJ6Q3ZLWXgxWHJEQnBldjBoSzBFWVJt?=
 =?utf-8?B?Q0M4OVNFZHlzTTAySGF0MUV3anBGWTlnR2h6RzlWWURjRi9kQ3AvcCtYelJP?=
 =?utf-8?Q?Oa6uhltqDaXyGpcx1WguOJY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 195c0eed-55f4-43fd-3e28-08d9ecbbde7c
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2717.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 17:36:28.8171
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8WJ9ThEeLYiV9uVA2LtvY6tBQL/gPxmBYxfRzjvhN6Ed8vaxQGR9uM8BLrSlc977cY/4LKewtjbmEcQXzslvLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1706
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Christoph,
Thanks a lot for rebase our patches. I just ran our amdgpu hmm-tests 
with this series and all passed.

Regards,
Alex Sierra

On 2/10/2022 1:28 AM, Christoph Hellwig wrote:
> Hi all,
>
> this series removes the offset by one refcount for ZONE_DEVICE pages
> that are freed back to the driver owning them, which is just device
> private ones for now, but also the planned device coherent pages
> and the ehanced p2p ones pending.
>
> It does not address the fsdax pages yet, which will be attacked in a
> follow on series.
>
> Note that if we want to get the p2p series rebased on top of this
> we'll need a git branch for this series.  I could offer to host one.
>
> A git tree is available here:
>
>      git://git.infradead.org/users/hch/misc.git pgmap-refcount
>
> Gitweb:
>
>      http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/pgmap-refcount
>
> Changes since v1:
>   - add a missing memremap.h include in memcontrol.c
>   - include rebased versions of the device coherent support and
>     device coherent migration support series as well as additional
>     cleanup patches
>
> Diffstt:
>   arch/arm64/mm/mmu.c                      |    1
>   arch/powerpc/kvm/book3s_hv_uvmem.c       |    1
>   drivers/gpu/drm/amd/amdkfd/kfd_migrate.c |   35 -
>   drivers/gpu/drm/amd/amdkfd/kfd_priv.h    |    1
>   drivers/gpu/drm/drm_cache.c              |    2
>   drivers/gpu/drm/nouveau/nouveau_dmem.c   |    3
>   drivers/gpu/drm/nouveau/nouveau_svm.c    |    1
>   drivers/infiniband/core/rw.c             |    1
>   drivers/nvdimm/pmem.h                    |    1
>   drivers/nvme/host/pci.c                  |    1
>   drivers/nvme/target/io-cmd-bdev.c        |    1
>   fs/Kconfig                               |    2
>   fs/fuse/virtio_fs.c                      |    1
>   include/linux/hmm.h                      |    9
>   include/linux/memremap.h                 |   36 +
>   include/linux/migrate.h                  |    1
>   include/linux/mm.h                       |   59 --
>   lib/test_hmm.c                           |  353 ++++++++++---
>   lib/test_hmm_uapi.h                      |   22
>   mm/Kconfig                               |    7
>   mm/Makefile                              |    1
>   mm/gup.c                                 |  127 +++-
>   mm/internal.h                            |    3
>   mm/memcontrol.c                          |   19
>   mm/memory-failure.c                      |    8
>   mm/memremap.c                            |   75 +-
>   mm/migrate.c                             |  763 ----------------------------
>   mm/migrate_device.c                      |  822 +++++++++++++++++++++++++++++++
>   mm/rmap.c                                |    5
>   mm/swap.c                                |   49 -
>   tools/testing/selftests/vm/Makefile      |    2
>   tools/testing/selftests/vm/hmm-tests.c   |  204 ++++++-
>   tools/testing/selftests/vm/test_hmm.sh   |   24
>   33 files changed, 1552 insertions(+), 1088 deletions(-)