Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Feb 2022 17:27:58 +0100
From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     Richard Zhu <hongxing.zhu@nxp.com>
Cc:     l.stach@pengutronix.de, bhelgaas@google.com, broonie@kernel.org,
        lorenzo.pieralisi@arm.com, jingoohan1@gmail.com,
        festevam@gmail.com, linux-pci@vger.kernel.org, linux-imx@nxp.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH v6 5/8] PCI: imx6: Refine the regulator usage
Message-ID: <20220211162758.GA287827@francesco-nb.int.toradex.com>
References: <1644290735-3797-1-git-send-email-hongxing.zhu@nxp.com>
 <1644290735-3797-6-git-send-email-hongxing.zhu@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1644290735-3797-6-git-send-email-hongxing.zhu@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4hMLAUvnEUlKmDRpzb/b3CfqQd5Y2dOCo4tQT7NSFEd1W19hdhQc+FnCDc4O?=
 =?us-ascii?Q?zyyBNrfHoGs8bvr4UzGwNbHEYhHB/uNPH9utVavH+zrzZUUTjaIqyqJAxIpK?=
 =?us-ascii?Q?lpNTMRfPKVPZZdYJysTCOrvm1n9Tt/TVUrsQea2tdzEqMofGBCJGns7F85QL?=
 =?us-ascii?Q?RXyROIuS+UaQqDjDCbGbyPgdBorxNwM3pmYFr7fJ9wFGzpizlVqhb5xwaNzC?=
 =?us-ascii?Q?5Ydjo7WabhiE7+o0Ekjbo6krd5JY5lL4ggqHy3vNukRsL3q3rLDYqMeG8l8f?=
 =?us-ascii?Q?uv7o5mZ0IrxDCYYO8haYU07kkTLAjc3wkCe2wrGVa9ILnGfVgesdw3JRO3RI?=
 =?us-ascii?Q?jlJGWVgsfamt3JY0cdeUXBeQAPo6iOrEfV8A11EJS4KuDwC3ckNQa3/oEZg+?=
 =?us-ascii?Q?SOa5/WRx6h3WLWTJsJUEh3HtqEWAMTK93VkXzUj1UT6p6MENTwpnZmK6j9fe?=
 =?us-ascii?Q?b9YVC90+k7MJde8NrBlOWPccMwzy8gIIYuDkV5w03qI3WEmotGWVSxFYGKpl?=
 =?us-ascii?Q?Z7X8sjKTwGB/n1RfdFecgOWYnmILMC4Q451JSxsp6ZkqNtKiCsUIIAJTYAtB?=
 =?us-ascii?Q?qvUIu0ADPXeFhvl0ULDRE8NzdU1mou/M8vSrJ/LCaxSuNU/Wf9dUcyXkzq/h?=
 =?us-ascii?Q?di4+HROYW51WHkaEYiBIn2m45fKd/Kemy90EJvnmGuAG2P46QZJRQwLzwm67?=
 =?us-ascii?Q?kB5RjKRa9RREVGFu5pWEzX6XWWwPtrgLWwctCcsY97clDK7KziFj7M7BnfZB?=
 =?us-ascii?Q?jwGSfXHZgtG1cf52qhEQyC20ChH4NP7n8i9WdVMe0SHiOonfrd3ONJ4ez7Ks?=
 =?us-ascii?Q?my6lfqhcCEB9SME4+GXa7s3ljwvykjEtLts476stsFtH8AHSXjdfWaiApMfF?=
 =?us-ascii?Q?8l/256GEGQcugozYBiN8b5gFRaFyP/ZnaUN2P8s3vzxP0CHWKvEERBZsZrhP?=
 =?us-ascii?Q?Ns3sy+aSysg6cDKHXYRq+0IQuwUPBh2K7SBI9VUlarj5GuKsoSnXr5cE194n?=
 =?us-ascii?Q?YAm6nxpZzHpAaVstTknVWzf8QGhFs519sIvU78MzEWiXkSDsZ914c1+59dlF?=
 =?us-ascii?Q?B18pNtJ/l2Z8OmcS0H9XBQok9zmFJiFae+b/HoZ+6Emv0NVNzyw4DjdP9nM4?=
 =?us-ascii?Q?K7oWAKmrjFPjlSCcRStKKXgkYYWAvqD5RrisTJqUA7GIx1iHTluTb86OYCiR?=
 =?us-ascii?Q?/Wy25SZoldvB1netnJ1ODAXZtaqdO3cIVnT6gFPuwf6QJeFquZu/nv4jQvDB?=
 =?us-ascii?Q?5Xe2eBQ9B6ELdLunlLlH+TeT/gzVnfqqFA9plz6B4HKKEQtmraleMjhCwLRf?=
 =?us-ascii?Q?1lWQH9qnIYN87pQRwiKWzUiIPgrNy2Mqhlr8o6tLrftYgLER5VV7/6d3DsPw?=
 =?us-ascii?Q?aS7mBhi9gtMq3eFn8DTaMFvTyK338T09f68E/oDvoKGkWyezAlyhshOlMNN7?=
 =?us-ascii?Q?z3FuEvaGG4A54IuwSnsT3yrtWV3p1DEpAF8N8zav/bLYx+yr1PLRwEaUalbE?=
 =?us-ascii?Q?tN70o0hrFicFPeFBuNIIB/EBsRmCgan0z95S6xJMVQEydW2VAgb9aGUOtMOo?=
 =?us-ascii?Q?Ai7n4TICLIvtteA5Gsej+0t0ibLplAe9f7x/258smI9/iuRiITgiFKkcM9PI?=
 =?us-ascii?Q?siDA+K0LFkQzNU6XYC7J1sbK0VelWlSJCM6nfpj8RPxzNfnfVX5h5acNexJI?=
 =?us-ascii?Q?eCsUgg=3D=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d697451-32c3-4b59-c240-08d9ed7b7735
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0642.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 16:27:58.7345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 170q9f8ttYu4XgU9VeNLhqOMawkD6+SHfssMUmBHLA5afj7s7LkI8clF9/yONapwbLd7oaPlm2BMx6aHNbbj9N6rcKntjkm63eLfzNclMLg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVAP278MB0261
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Richard,

On Tue, Feb 08, 2022 at 11:25:32AM +0800, Richard Zhu wrote:
> The driver should undo any enables it did itself. The regulator disable
> shouldn't be basing decisions on regulator_is_enabled().
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
>  drivers/pci/controller/dwc/pci-imx6.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 0aca762d88a3..e165ad00989c 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -369,8 +369,6 @@ static int imx6_pcie_attach_pd(struct device *dev)
>  
>  static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)
>  {
> -	struct device *dev = imx6_pcie->pci->dev;
> -
>  	switch (imx6_pcie->drvdata->variant) {
>  	case IMX7D:
>  	case IMX8MQ:
> @@ -400,14 +398,6 @@ static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)
>  				   IMX6Q_GPR1_PCIE_REF_CLK_EN, 0 << 16);
>  		break;
>  	}
> -
> -	if (imx6_pcie->vpcie && regulator_is_enabled(imx6_pcie->vpcie) > 0) {
> -		int ret = regulator_disable(imx6_pcie->vpcie);
> -
> -		if (ret)
> -			dev_err(dev, "failed to disable vpcie regulator: %d\n",
> -				ret);
> -	}

This commit is not just cleaning up the regulator usage as you state in
the commit message, this is removing the vpcie regulator_disable
from imx6_pcie_assert_core_reset().

I would not do it, this is called for example on the shutdown callback
where it makes sense.

Francesco