Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     John Garry <john.garry@huawei.com>
Cc:     <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <artur.paszkiewicz@intel.com>, <jinpu.wang@cloud.ionos.com>,
        <damien.lemoal@opensource.wdc.com>, <chenxiang66@hisilicon.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <hch@lst.de>
Subject: Re: [PATCH 0/2] scsi: libsas: Drop SAS_TASK_AT_INITIATOR
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1pmntoyma.fsf@ca-mkp.ca.oracle.com>
References: <1644489804-85730-1-git-send-email-john.garry@huawei.com>
Date:   Fri, 11 Feb 2022 16:57:26 -0500
In-Reply-To: <1644489804-85730-1-git-send-email-john.garry@huawei.com> (John
        Garry's message of "Thu, 10 Feb 2022 18:43:22 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kSUGhLlpNT1MyI8dEcDiFzpfKuYUzTJmF8UI906t9PuTIEsdFnpW1RbfTJaB?=
 =?us-ascii?Q?w5zW7Pzs+guLu52QTTm8j4id2efX63KlGMlRRrGxZHQkykHWf7gsgtFjJOnL?=
 =?us-ascii?Q?uh/2toSOUbPxfGMAtGlBKb9IRQLIRdrhzQlVzU8g9jHz7NVnbDS/uet3v3mV?=
 =?us-ascii?Q?Wc/m38JTKNUUOLH0cC6BeJD+7t1W51KW8RzZ5RavWbiiMZPYt0FZgJksaPXV?=
 =?us-ascii?Q?lU8fm8vlf1SU+AN9ROCOskCGJMO9WPhFUr9gDF/bKhxph9Sb9ZoD03nfRXUR?=
 =?us-ascii?Q?GjvEbOtoixsf9dWERs+ApP0Tue3jta75iB4Kv25CkVKdnA1pWfAzF4IVkN44?=
 =?us-ascii?Q?dsdWrED/mZGw5xt3sPjxOfJBRJyHe68DQOhmdoamKXK7d2YT9U9AXVNrLdpw?=
 =?us-ascii?Q?zUXaYfBHO8Hoe9dtKfVVXF+btsFN9rnsVP5R07pmnRIqTjoqr/NEuQgngy+t?=
 =?us-ascii?Q?Q6yUNTeaF1RlFegR8Q7BckVM2OicgRng+BEZKo1HbAtuwB1gh807PhgBD1uI?=
 =?us-ascii?Q?e0I4ZHahZNVTKOs3h4GRMO4B+izV/t8tLLw0RQTgCi4lqU0uPqgJvIlc1047?=
 =?us-ascii?Q?w0vCOJ9MyRzel8Nk3tPSYHtugMAtq3V8B7pz8OAKqqKzWXfrJRiLMlIavRx0?=
 =?us-ascii?Q?zBFDnmSGv0BwslKEkDn9fgQK+qG39JhPjO+id0fEsGSof3BTrOWGc8rYeD7O?=
 =?us-ascii?Q?CeoFkVpKlbvdqls3tHEjWHrNG19ZI32tVsiUabBiPW2PpQ+j3hpKr7HKftJ4?=
 =?us-ascii?Q?O39fw3EOGJbeVcEETxBaOCVhJH3gLU0BqRaucK9TVZAciBP/+ZeenFg9Jy3l?=
 =?us-ascii?Q?DoTxMtb8aBKmGlOn0PgsDgdBBrHpsgaPzSJU6Ja3GQWSSunNB5DvGUfSge/A?=
 =?us-ascii?Q?mxl2THvM0DtLPx4hwoghrRoTxXCl3XNlO6+Fmkd7oNiYl1FSjgKBnlsYIoK9?=
 =?us-ascii?Q?Z87+LeBABYjfZlD08x8hjHIhkYK37CQatfk+ifgFdJNYe8X3ZWcVbREQ84Rv?=
 =?us-ascii?Q?EjTrM0s+SOmF3deZQvP0CWt30SvK1hH//j2QvDCtOwCYQadAjDSRciONNYNM?=
 =?us-ascii?Q?tzz3Poh0M3Z3O5NwILSq/V13pii6qFHaSxk5GUzqIr65FhOZjUruyTkokWws?=
 =?us-ascii?Q?oBGgdlZ/MVdbNxE1asUfZ/ubHfbEvTTkm0aIc88uWzhuA6mAfmX6v/tPq5d/?=
 =?us-ascii?Q?fVEi7JQGsGKjspTuNyqKyaL7SiKSk0811rqLjBFrj6jbCXqDO8YopJADqOLq?=
 =?us-ascii?Q?t0UG2PMt8HxB7HiqmFYritZI01mYJcbasOcXt8maj0R+rfgTNKnQcLC01TDo?=
 =?us-ascii?Q?tOgT4AejtobcHA59j+tFF+XMHEowOIIW8qQgqCI0LOEtcGgW0COU8gdMvUk+?=
 =?us-ascii?Q?WWQAAyOoDt46NtL7x/f9yidxytSvHFZ/cKnGADjbf4tE05zyRpiMaYTOaYHJ?=
 =?us-ascii?Q?Ol+8VmShpwVcJebp9515EuRQwLBjPZnH9m7HNWYGAj0MYw2u8DgYBxnsVYk6?=
 =?us-ascii?Q?c4N4GNujT/CkLvpA1WtVUrp0dLR993hJ7GzKCNLSzMz8LfrtLnJ762hj2n5K?=
 =?us-ascii?Q?JXKsFMh5AjqSd9h34upOC8H1qNMSwDmSPSUNEf59VkAC4EgQThFjSPCA7EqF?=
 =?us-ascii?Q?2che3Parfzi6fVteSfhduuBWFdoE57H8Gv8UDJw+2/OQQSgc/TiYjgvyqFx0?=
 =?us-ascii?Q?niOOsw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b70d1623-7dda-4bf8-b9d0-08d9eda97f48
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4754.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 21:57:29.1457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K/p8uvPBpogoecDVRQWQKwSs1pqmZPUYUNyODcnxI1+UrkOEYDMckD7EzX3+uuKvL+Qg2vO9qqjEm4dR6HWHs4T5irlM+lnULkOfO50YT8U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5831
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10255 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=878 phishscore=0
 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202110109
X-Proofpoint-GUID: DAGKnFIKTFnEl0XDTj6IAKUU0vofvzWB
X-Proofpoint-ORIG-GUID: DAGKnFIKTFnEl0XDTj6IAKUU0vofvzWB
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


John,

> Apart from some isci driver code, flag SAS_TASK_AT_INITIATOR is only
> set, so drop usage in that driver and then everywhere else.
>
> This solves a use-after-free in the pm8001 queue path.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering