Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Feb 2022 16:19:36 -0600
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Potin Lai <potin.lai@quantatw.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] arch: arm: dts: bletchley: cleanup redundant node
Message-ID: <Ygbg+KYK9qT90O2N@heinlein>
References: <20220211014347.24841-1-potin.lai@quantatw.com>
 <20220211014347.24841-11-potin.lai@quantatw.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="JisbnzQp48fIKCGa"
Content-Disposition: inline
In-Reply-To: <20220211014347.24841-11-potin.lai@quantatw.com>
Precedence: bulk


--JisbnzQp48fIKCGa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 11, 2022 at 09:43:47AM +0800, Potin Lai wrote:
> Remove redundant i2c1 node.
> Disable in-chip rtc, use external rtc (pcf85263) instead.

A bit of "why" on the RTC change might be useful.  I suspect it has to do
with where battery-backing is for the RTC in hardware.

>=20
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
>=20
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/a=
rm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> index 946107bd8bc7..fb62a67cfeed 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> @@ -205,10 +205,6 @@
>  	};
>  };
> =20
> -&rtc {
> -	status =3D "okay";
> -};
> -
>  &fmc {
>  	status =3D "okay";
>  	flash@0 {
> @@ -387,10 +383,6 @@
>  	};
>  };
> =20
> -&i2c1 {
> -	status =3D "okay";
> -};
> -
>  &i2c2 {
>  	status =3D "okay";
>  	ina230@45 {
> @@ -680,6 +672,7 @@
>  	};
> =20
>  	rtc@51 {
> +		/* in-chip rtc disabled, use this external rtc instead */
>  		compatible =3D "nxp,pcf85263";
>  		reg =3D <0x51>;
>  	};
> --=20
> 2.17.1
>=20

--=20
Patrick Williams

--JisbnzQp48fIKCGa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmIG4PgACgkQqwNHzC0A
wRkWMBAAqRxDw0dBdIcOs4dccrmlv1gPYZ2wzaS8rizHSpKm2gz1IIt7ConmzmSv
zYlkH4kioV4aBgP59r3CnyKObFARg7pTm4jelLYUoedzAidK6YgmpWDHslS835KG
OHza3ZFZpjROw+Yxc+Uj4d5SJ2eCva5znFvp1FukcmahTMXJDUT+OT1KeKoq3BoV
NVNlb1SXuXmJyCmooCiKQSO73xgW5KDUH3pVOzC9OsGc3xHq70uKIBmWd+1DD8ya
CgLf/s3mk2OKlFfz0tn8nq1oLdXxzjygm+ymXNtmr0NwdGVHoDLA6Irld9xfAjt/
mggDNLoYBcHw08eAydFYTRDkshEkxYiREWIK1Eb+b0Y7p0SWI8CYFE+eofdscwWt
RA6889EWvdWffOYJKKfBGHbYFGBbytSuwwyCYYc/wxJ3zgPgzcR/QtOUvVxLi17N
OpBnlyDZrPbpsVBGYoCL+ml+27UZAfVRtzkXTL05lMdZFVmg8lawiMcTtP7cb1FI
0JlT4xWFOPRhkr13eOUfHFVa3H9+TuSNAaUroHu0oAd7f77HNt06O85eSo8KndXd
nXsJkpnybmu29THPv2EHcvP1DUCbEpKL8I7ORwqigkLRnL21G+JwFJg7Y/sCDmpa
ZiHJoWWpEEnBkPrela3DH/bjBx6cNh8bkmleWg5mSm60K92A3tQ=
=CihP
-----END PGP SIGNATURE-----

--JisbnzQp48fIKCGa--