Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\))
Subject: Re: [RESEND v2 1/2] power: supply: Introduces bypass charging
 property
From:   "Rivera-Matos, Ricardo" <rriveram@opensource.cirrus.com>
In-Reply-To: <20220211204309.apzep7w233vh7iin@mercury.elektranox.org>
Date:   Fri, 11 Feb 2022 15:46:52 -0600
CC:     <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>
Content-Transfer-Encoding: quoted-printable
Message-ID: <7DD3FE07-445C-47BC-92AB-B281ABF67068@opensource.cirrus.com>
References: <20220210154108.641369-1-rriveram@opensource.cirrus.com>
 <20220210154108.641369-2-rriveram@opensource.cirrus.com>
 <20220211204309.apzep7w233vh7iin@mercury.elektranox.org>
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Precedence: bulk

Sebastian,

> On Feb 11, 2022, at 2:43 PM, Sebastian Reichel =
<sebastian.reichel@collabora.com> wrote:
>=20
> Hi,
>=20
> On Thu, Feb 10, 2022 at 09:41:07AM -0600, Ricardo Rivera-Matos wrote:
>> Adds a POWER_SUPPLY_CHARGE_TYPE_BYPASS option to the =
POWER_SUPPLY_PROP_CHARGE_TYPE
>> property to facilitate bypass charging operation.
>>=20
>> In bypass charging operation, the charger bypasses the charging path =
around the
>> integrated converter allowing for a "smart" wall adaptor to perform =
the power
>> conversion externally.
>>=20
>> This operational mode is critical for the USB PPS standard of power =
adaptors and is
>> becoming a common feature in modern charging ICs such as:
>>=20
>> - BQ25980
>> - BQ25975
>> - BQ25960
>> - LN8000
>> - LN8410
>>=20
>> Signed-off-by: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
>> ---
>=20
> Sorry for the wait. This needs to update the sysfs ABI documentation:
>=20
> Documentation/ABI/testing/sysfs-class-power

Ack
>=20
> I think your patch description is a good explanation for that file.
> Also I obviously missed to point this out for the "Long Life" charge
> type, so please also add a sentence for that so that the property
> is properly documented.

As I understand it =E2=80=9CLong Life=E2=80=9D means the charger reduces =
its charging rate in order to prolong the battery health.

Is this a fit explanation?
>=20
> (Otherwise the patchset looks fine to me)
>=20
> Thanks,
>=20
> -- Sebastian

Best Regards,
Ricardo

<snip>