Subject: Re: [PATCH mm] cfag12864b: fix crash when built-in and no parport
	present
From: Daniel Walker <dwalker@mvista.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Miguel Ojeda <maxextreme@gmail.com>, linux-kernel@vger.kernel.org
In-Reply-To: <20070212213557.4b28e567.akpm@linux-foundation.org>
References: <20070210205123.699abb9c.maxextreme@gmail.com>
	 <20070212213557.4b28e567.akpm@linux-foundation.org>
Content-Type: text/plain
Date: Tue, 13 Feb 2007 01:16:36 -0800
Message-Id: <1171358197.32073.182.camel@imap.mvista.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 726
Lines: 20

On Mon, 2007-02-12 at 21:35 -0800, Andrew Morton wrote:

> 
> This looks hacky.
> 

One other thing that could be added is a change in the initcalls .
ks0108 should be subsys_initcall() and the LCD devices
device_initcall(). That would make sure one runs before the other. I
don't think that alone would fix the crash tho. I didn't suggest it
before cause I think the order of the sources in the build system might
do this implicitly even if both are in device_initcall ..

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/