Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp4916767pxb; Sun, 13 Feb 2022 01:15:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxa2q09/NFoEOMMIBE1kAtZN8Iq361zsOYVs4Jom50gdwvZaxOT5NEKe3wtaDZteESLiS7o X-Received: by 2002:a17:902:e810:: with SMTP id u16mr9497427plg.10.1644743759223; Sun, 13 Feb 2022 01:15:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644743759; cv=none; d=google.com; s=arc-20160816; b=LDslWjRk1uYlNhnTFb6NxYMdvbVRC/NHaL2nqcUIAMcuEpRILSExquTYYPEWM5P1tc gdbixB+Cmu0MiVw9WREglkyTS5w2xo4L7C1azBFgXgUTakXeqeN0Sr1/lKc89oxhz0az EH97d+HaOotaCazjwCKLQjyzzEjW7qrR9ShBHEuC/neYzMZ2y3LFSQyktuMkcPlHXR8E yu/Hz1NlDHasXxOJBCL2DiD2I7SYzE/hr4RfBGj5Zvabiv/6ywjKJRKw5J9DJgvzXr/k g+1b+mSZ80GIZrPj3QqCe+ry4MJQ1wzrMzpkXfSDyKoa5gR8O/ZXSAXfC01ClbxEnY6N LTZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=FxR2tCd2kQ2slz4IkVSpQwFsX+MPwtsdOXOlbt9nOOY=; b=ZXgg1t0PspmvyhHTeXNLPP9yYEPxGNIGm7JO4jTnqFVLTNwVVi5ILDwiV/eA/OFe9u P9/Aozl+Vw5x52+A6dJqgdBeTlt2/jLo1maHLhTtKhiiiRP99AEbJo59BcE3d6ZHWBX6 L7f/bNwGcnOW98ce0+/OdGsd2Am0A4kv/tRvtY8mzEx/h+e8+fIp3yMu9PP1BFWOE8QX WHBrRgGUkwcFyP6A0lnod9dIcmooieENymVHj3RzezRvTJesyY/ftx6LXz3q0b8a9k5a lIbnmkl4jOLEHyl4WlRLE/LkCnvSJcWlXgbaAwVet143QaF7Y9hIRF0NEkACdtVdZzax bG7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UQnBoKSK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5si6624248pgs.859.2022.02.13.01.15.37; Sun, 13 Feb 2022 01:15:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UQnBoKSK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346733AbiBKBUY (ORCPT + 95 others); Thu, 10 Feb 2022 20:20:24 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:36664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243679AbiBKBUX (ORCPT ); Thu, 10 Feb 2022 20:20:23 -0500 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5564A2651 for ; Thu, 10 Feb 2022 17:20:23 -0800 (PST) Received: by mail-yb1-xb2f.google.com with SMTP id p5so20421456ybd.13 for ; Thu, 10 Feb 2022 17:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FxR2tCd2kQ2slz4IkVSpQwFsX+MPwtsdOXOlbt9nOOY=; b=UQnBoKSK7byn2I0KnUJSpQUYM33v2c1HGs/VbASBlEP3xui+kZkgyeCWVxp5XUdfx2 AHCPQcjBpxGE16zdapg1W5X8VEzI6TfhymRx0nBgsvzGJ1IOGwlPD8rn59ZxC0Fa0d25 3n2KxZYmaA/Xwu7CiH7povjf+KUmXmiOw4OgnjfEopvWVGYUGczJNe7Ir0zbFMC2Vhn3 3Y0yk0SeMEfqjl7X+OvgxEfW2jgPdi8BB1vmotBZMER7Fco/IGR9T7RrOPS/DyyJvKtU 0YfR/aJGhOxmpuDFWH+sf+g07IM9XxmI25DHNNX8WdX4LJvC3lDksGovzt+GUoka/84o x6Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FxR2tCd2kQ2slz4IkVSpQwFsX+MPwtsdOXOlbt9nOOY=; b=ZcOMfk4hR9UpQWXU7Y++He5g1bWSIevqTFoM2b3zoWfgAn7bPQfSTxnZkaR/T2ynVe lb8Aa9umcTobRgiHf5G97hSGx/ayjBzNIrdqzv6Q9UZh6O8XGJ5bNR7ILiMtUcjkQp7q hcwHRqTqhpwmUc2vK/dKZz0i6zdB8uYiJ/dnOjh77i/n8kjl+stMqx6fRQNVUC76ElWD ejDkdAoF9GSaozSZXOmQpiVQi7f3ola6xE9itkqls/co0/w/ps4erFXZXzQ0h7s4I8H1 tszcSogb6fbjPLjXW3WhIeaygq7HzVHbbUbMdZTSplBSSJtHMyf4WRZ3kKpH2y2GX0rv auGA== X-Gm-Message-State: AOAM530GcXYzQtQYVOed93X4A5430bIGsYqT+X7HHyUpr1S8469XLRs0 WiPzFLq4of/UPUcg62ncW+yGS04bH1U62yYyq38JJg== X-Received: by 2002:a25:5143:: with SMTP id f64mr10175550ybb.520.1644542422611; Thu, 10 Feb 2022 17:20:22 -0800 (PST) MIME-Version: 1.0 References: <20220209182822.640905-1-seanga2@gmail.com> In-Reply-To: <20220209182822.640905-1-seanga2@gmail.com> From: Linus Walleij Date: Fri, 11 Feb 2022 02:20:11 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: k210: Fix bias-pull-up To: Sean Anderson Cc: linux-gpio@vger.kernel.org, Damien Le Moal , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Carpenter Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 9, 2022 at 7:28 PM Sean Anderson wrote: > Using bias-pull-up would actually cause the pin to have its pull-down > enabled. Fix this. > > Signed-off-by: Sean Anderson Patch applied for fixes. Yours, Linus Walleij