Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5093054pxb; Sun, 13 Feb 2022 07:34:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJyCmcmIknPOjhQ48P+mp+KPpeyQHy7WTxztwTuv3nuRtYuVRjN6lhR0VN73wPaOg8WOD9KD X-Received: by 2002:a17:907:d9e:: with SMTP id go30mr8513630ejc.125.1644766443267; Sun, 13 Feb 2022 07:34:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644766443; cv=none; d=google.com; s=arc-20160816; b=Iqr3Fs6hnz/C1F3wckAMzM4dL7qvPbG/VgEt8Z7Rp6pbbHiuotsnW8glmKv0fODnRr Wc++3Yzg/zS78+LO2CDbaiMfGwXQkDej0F5iAPr7A2SA6oUkF3ieAGA++hxH3gNN6IUB piFKvWVb+tPsHYqCRCrZjW46FjY2+x+u/92UFZtpWyqKnlW7iqYlovhUgHLspOpA2wmQ O7S/HHWvstBp6issE8jGkiJS3BLYvp7CI2vHV10J7idEL943C622pfhcw/PJfcfd/3MJ XA/uVArHte7DdndMx13UzRAzl5qIgNcQEEDn4IItO7COoZgy4tTLlFaQyRhUaiZbPqs9 ghng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=DXrS5ll8pzRqnICTtAjgRa1ZRZSlwxZRxSjnB9LY+is=; b=iz7a34cyGfBaxt314Ca5SVbFQ8CFSZHwAgthj+qrjdSXdWHX0Pjl6PJjsSGk/xOWr5 I5oLIBbkP1SZNuJBEaeYkZ6L9RUtEuhPQCZsDKjNyD8RaGsOZyjpeYWoVlmv+Les57+A TcwlQXiUIWwD5gAdhv8UTFYal8uCxJaI6MiH8OpTy7psA8AKxW8vj/sEerSODq+QlDEx cc/KtKy0I16aMTNymRfcxXakhNO5xqYK4+qE38qfUfIyjZpBa0NxNk6LtxsG8ZK59hXo 0fStks7wErMDT8JUImmmAed1n6QymXa3weyTw32iZxufuUhaklsffSD2vl0YekNZ5Iyq tpNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w1si9617076edd.579.2022.02.13.07.33.40; Sun, 13 Feb 2022 07:34:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231194AbiBLTmv (ORCPT + 99 others); Sat, 12 Feb 2022 14:42:51 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230072AbiBLTmt (ORCPT ); Sat, 12 Feb 2022 14:42:49 -0500 Received: from cavan.codon.org.uk (irc.codon.org.uk [IPv6:2a00:1098:84:22e::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B53FA606CC; Sat, 12 Feb 2022 11:42:42 -0800 (PST) Received: by cavan.codon.org.uk (Postfix, from userid 1000) id 4E74840A64; Sat, 12 Feb 2022 19:42:40 +0000 (GMT) Date: Sat, 12 Feb 2022 19:42:40 +0000 From: Matthew Garrett To: Aditya Garg Cc: Ard Biesheuvel , Jeremy Kerr , "joeyli.kernel@gmail.com" , "zohar@linux.ibm.com" , "jmorris@namei.org" , "eric.snowberg@oracle.com" , "dhowells@redhat.com" , "jlee@suse.com" , "James.Bottomley@hansenpartnership.com" , "jarkko@kernel.org" , "mic@digikod.net" , "dmitry.kasatkin@gmail.com" , Linux Kernel Mailing List , "linux-efi@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "stable@vger.kernel.org" , "keyrings@vger.kernel.org" , "linux-integrity@vger.kernel.org" , Orlando Chamberlain , Aun-Ali Zaidi Subject: Re: [PATCH] efi: Do not import certificates from UEFI Secure Boot for T2 Macs Message-ID: <20220212194240.GA4131@srcf.ucam.org> References: <9D0C961D-9999-4C41-A44B-22FEAF0DAB7F@live.com> <20220209164957.GB12763@srcf.ucam.org> <5A3C2EBF-13FF-4C37-B2A0-1533A818109F@live.com> <20220209183545.GA14552@srcf.ucam.org> <20220209193705.GA15463@srcf.ucam.org> <2F1CC5DE-5A03-46D2-95E7-DD07A4EF2766@live.com> <20220210180905.GB18445@srcf.ucam.org> <99BB011C-71DE-49FA-81CB-BE2AC9613030@live.com> <20220211162857.GB10606@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,KHOP_HELO_FCRDNS,SPF_HELO_NEUTRAL, SPF_NEUTRAL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 12, 2022 at 05:53:47AM +0000, Aditya Garg wrote: > Feb 12 11:01:52 MacBook kernel: Reading EFI variable db-d719b2cb-3d3a-4596-a3bc-dad00e67656f Ok. With CONFIG_LOAD_UEFI_KEYS=n, can you run: cat /sys/firmware/efi/efivars/db-d719b2cb-3d3a-4596-a3bc-dad00e67656f and see whether it generates the same failure? If so then my (handwavy) guess is that something's going wrong with a firmware codepath for the d719b2cb-3d3a-4596-a3bc-dad00e67656f GUID. Someone could potentially then figure out whether the same happens under Windows, but the easiest thing is probably to just return a failure on Apple hardware when someone tries to access anything with that GUID.