Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Feb 2022 06:43:24 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Zhouyi Zhou <zhouzhouyi@gmail.com>,
        Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        Masahiro Yamada <masahiroy@kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        rcu <rcu@vger.kernel.org>
Subject: Re: Set environment variable `KVM` makes build fail
Message-ID: <20220213144324.GS4285@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <d3e6a461-5b37-ecfb-d63c-d35af27f2682@molgen.mpg.de>
 <CAABZP2yOA2n-xux8uUC72vVYc14JfCawoOzp_pnTGDvY8cRSnw@mail.gmail.com>
 <f63abe64-6d4f-1374-5fd3-874a34c1c22f@molgen.mpg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f63abe64-6d4f-1374-5fd3-874a34c1c22f@molgen.mpg.de>
Precedence: bulk

On Sun, Feb 13, 2022 at 10:45:11AM +0100, Paul Menzel wrote:
> Dear Zhouyi,
> 
> 
> Am 13.02.22 um 09:07 schrieb Zhouyi Zhou:, and
> 
> > Thank you for your trust in me.
> 
> Thank you for your help.
> 
> > I think the following patch has a good explanation of what happened ;-)
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/tools/testing/selftests/rcutorture/bin/torture.sh?id=a7d89cfb8e1269cb6d22453adba56b8d0218589f
> > "The torture-test scripting's long-standing use of KVM as the
> > environment variable tracking the pathname of the rcutorture directory
> > now conflicts with allmodconfig builds due to the
> > virt/kvm/Makefile.kvm file's use of this as a makefile variable"
> 
> Indeed. In my script I had added the remote for the rcu git archive, but
> forgot to actually fetch the objects and refs, and missed the error message
> in the output.
> 
> Sorry for the noise, though the variable name should probably namespaced, as
> at least for the name `KVM` the chance are higher (still very small) that
> it’s set in the environment.

In -rcu and -next, it is now named "RCUTORTURE".  But if there are
other rcutorture environment variables in need of namespacing, please
let me know.

							Thanx, Paul