Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5405916pxb; Sun, 13 Feb 2022 20:23:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJwIB9vvOFFDZVUL2liZ81bOZR+2HONqwZt9v0q0kJezOV9dHCe+Vtc7gNfbmkm9G2F7XrK+ X-Received: by 2002:a17:90b:17c3:: with SMTP id me3mr6459022pjb.202.1644812609867; Sun, 13 Feb 2022 20:23:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644812609; cv=none; d=google.com; s=arc-20160816; b=0F8779192jAgK7u4BXzN1EUiTVlM7jdvObwPjX3/5/EOFffN6NLpE6dyIUAxtKIKrO QPRdsW13qXugymQdNBcDTKZqlqXymBLd6P5K44CICs++kbVH2rmuWrjUpAtmrzstZKDA F0zjpOcr9wd9bWxH3i65w4qCYCoVfK7ITDwPDsga3BCYCdyz+boWe9RMmuT3pQuKJew1 jLaQJvhHqQ8dV76Dt6OTiqeVpQPk6ttOzJn7RI/KpFAlWoZ1dkiJ3aL9lx05pjJDI5Oe 3SW2mwIPMClbEm/hGB3ZV/3Jz+LwTBkWVzk3f3yENy7CLsNRviu3bbhlkSPXx7V6ru+M Snrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=An8sejACWdvpFe+0xRHo7AseACg3JQzOaIfRXUshpP4=; b=izQsPERA8wC4MHFsss7jFVkRMNbQgLD4bff2QtSq1K3rjZKTO4RxUu1oDJxWxPh1hx S5/Ybi0DRCTVnMVa1u/E76vKTfA31VPdUfUILA0F4nRcnSbqt6vwOCW2uAQYaZ9PsMga eSNRaBZynbf/rOq6XZPJ6aaqGgy9GSr6pWu8GQXstI5WN0OjkWvz34qMxJatn0lIw5Gd tskD6sshp+vGDB+zQGTsCvyhmtCuGciO52vP58C78kXJ1k+qgknrokhz7LfiqU3Vdjv/ 0IIXgJumsBqqmku03i0JhZrzaNu7GhsOe46JnBOsDfXMY88Y8HVyw9T9F4TRs2z7BAYr X/Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=NARq7CRK; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=0CgFF1kB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g15si36162675pgk.863.2022.02.13.20.23.16; Sun, 13 Feb 2022 20:23:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=NARq7CRK; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=0CgFF1kB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352595AbiBKSPk (ORCPT + 93 others); Fri, 11 Feb 2022 13:15:40 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352508AbiBKSPT (ORCPT ); Fri, 11 Feb 2022 13:15:19 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 880C8CF5; Fri, 11 Feb 2022 10:15:18 -0800 (PST) From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1644603317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=An8sejACWdvpFe+0xRHo7AseACg3JQzOaIfRXUshpP4=; b=NARq7CRKp2oDkLGnfeobnnJ29QT7pRs0iM8vCshdXDiq2e6YjM9Y1ieee/G3eZ3xDSy03b F7xRV+u0zfjsqL7bncoA90wNQSCqyI3dSDldvxTEBLZehwnQkIsXv+HIUqHgdw8BGUN0U/ YuNahORbgMxr/bxomwhFwhIHf0MQKyRibsi3wynm6uOKURGzNxOP2O08WQ+uQlKkVdb8u7 +DLPxuacNsZbex48IUoHVoRablVzvRbOBZMw/Mg29mwevrXD/shpZTp9icWuTYdYGZFZXa zTPGSV0V8ZhhnfSncBba9laxo4/vd56AgZpD0Y8PdwvD0crQCrnL5LZEvkTFxA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1644603317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=An8sejACWdvpFe+0xRHo7AseACg3JQzOaIfRXUshpP4=; b=0CgFF1kBSfhzXy7ccJmZkN1Vgek7S1AU9/rKcNKYR3KliKVCxVgRh/3fPhp897170McYhC M0I2VN41cyQJh0DQ== To: greybus-dev@lists.linaro.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, netdev@vger.kernel.org Cc: "David S. Miller" , Alex Elder , Arnd Bergmann , Greg Kroah-Hartman , Hans de Goede , Jakub Kicinski , Johan Hovold , Lee Jones , Rui Miguel Silva , Thomas Gleixner , UNGLinuxDriver@microchip.com, Wolfram Sang , Woojung Huh , Sebastian Andrzej Siewior Subject: [PATCH v4 6/7] net: usb: lan78xx: Use generic_handle_irq_safe(). Date: Fri, 11 Feb 2022 19:14:59 +0100 Message-Id: <20220211181500.1856198-7-bigeasy@linutronix.de> In-Reply-To: <20220211181500.1856198-1-bigeasy@linutronix.de> References: <20220211181500.1856198-1-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of manually disabling interrupts before invoking use generic_handle_irq_safe() which can be invoked with enabled and disabled interrupts. Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/usb/lan78xx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index b8e20a3f2b84e..415f16662f88e 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1537,11 +1537,8 @@ static void lan78xx_status(struct lan78xx_net *dev, = struct urb *urb) netif_dbg(dev, link, dev->net, "PHY INTR: 0x%08x\n", intdata); lan78xx_defer_kevent(dev, EVENT_LINK_RESET); =20 - if (dev->domain_data.phyirq > 0) { - local_irq_disable(); - generic_handle_irq(dev->domain_data.phyirq); - local_irq_enable(); - } + if (dev->domain_data.phyirq > 0) + generic_handle_irq_safe(dev->domain_data.phyirq); } else { netdev_warn(dev->net, "unexpected interrupt: 0x%08x\n", intdata); --=20 2.34.1