Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Feb 2022 20:23:13 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 02/24] EDAC/amd64: Define functions for DramOffset
Message-ID: <Yga3oWKqg7TK6lWZ@zn.tnic>
References: <20220127204115.384161-1-yazen.ghannam@amd.com>
 <20220127204115.384161-3-yazen.ghannam@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220127204115.384161-3-yazen.ghannam@amd.com>
Precedence: bulk

On Thu, Jan 27, 2022 at 08:40:53PM +0000, Yazen Ghannam wrote:
> @@ -1099,22 +1140,13 @@ static int umc_normaddr_to_sysaddr(u64 norm_addr, u16 nid, u8 umc, u64 *sys_addr
>  	ctx.nid = nid;
>  	ctx.inst_id = umc;
>  
> -	/* Read D18F0x1B4 (DramOffset), check if base 1 is used. */
> -	if (df_indirect_read_instance(nid, 0, 0x1B4, umc, &ctx.tmp))
> +	if (remove_dram_offset(&ctx)) {
> +		pr_debug("Failed to remove DRAM offset");

You don't need that pr_debug - remove_dram_offset() already has one for
the single error case.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette