Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e9f1166d-78a0-1806-42bb-03f2e1671128@redhat.com>
Date:   Fri, 11 Feb 2022 18:37:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH V2] selftests: kvm: Remove absent target file
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>,
        Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Shuah Khan <shuah@kernel.org>, Peter Gonda <pgonda@google.com>
Cc:     kernel@collabora.com, kernelci@groups.io,
        "kernelci.org bot" <bot@kernelci.org>, kvm@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220210172352.1317554-1-usama.anjum@collabora.com>
 <f9893f6a-b68b-e759-54f5-eef73e8a9eef@linuxfoundation.org>
 <eb4e24c6-41d0-4f3a-2af0-3008db408da6@redhat.com>
 <9198c43b-e5e2-fa58-5862-598dc7019ad6@linuxfoundation.org>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <9198c43b-e5e2-fa58-5862-598dc7019ad6@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/11/22 18:34, Shuah Khan wrote:
> On 2/10/22 11:56 AM, Paolo Bonzini wrote:
>> On 2/10/22 19:02, Shuah Khan wrote:
>>>
>>> I am fine with the change itself. For this patch:
>>>
>>> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
>>>
>>> However, are we missing a vmx_pi_mmio_test and that test needs to be 
>>> added.
>>>
>>> Just in case the test didn't make it into the 6a58150859fd and the 
>>> intent
>>> was to add it - hence the Makefile addition? This can be addressed in
>>> another patch. Just want to make sure we aren't missing a test.
>>
>> This was probably a rebase resolution issue.  The vmx_pi_mmio_test 
>> fails in the mainline tree, and is lingering in my tree together with 
>> the fix because somebody promised a better fix for it.  I included the 
>> TEST_GEN_PROGS_x86_64 line by mistake when rebasing Peter Gonda's test 
>> below vmx_pi_mmio_test.
>>
>> Thanks for the fix,
>>
>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>
> 
> Paolo,
> 
> Thank you for explaining the discrepancy. Would you like take
> this through your tree? This patch depends on
> 
> commit: de1956f48543e90f94b1194395f33140898b39b2

Yes, of course.  Queued now.

Paolo