Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5531688pxb; Mon, 14 Feb 2022 01:01:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3eemhx9FzFhI2YmYtowuEtnlQuWf1KEhA04warS6y/MWFsnJl/3UrRyQqRN0+Kiyiu9WJ X-Received: by 2002:a17:90b:3148:: with SMTP id ip8mr10047009pjb.191.1644829293569; Mon, 14 Feb 2022 01:01:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644829293; cv=none; d=google.com; s=arc-20160816; b=G7yulIzJeXR4rMlr8jXbbFvHWCHnT6RQkYsMlqYgT3EH61dOisuAc4BM/g96bBbon7 DmqMULEoIW/TBp/M6HvmN2Z958ZY2r56V5M3eQpkOLxEcNp0kFjEk+EIKv1cvjm9m3Xb FsjhFl56Ldl/JUez5Iqqykb7BznaLqFoaT98WKQEwGPbOfcgrjdU1DWE7dtx8oUC53E2 Vs5X2WHf5AGS14kg71lMGJ0ykv3/G0L+U6ZGY/vKKnqWrlKtxu5jUCoBvf3hZRUqCemd 2QTAHf2erUMOILwREavIeOQwcqklpb+YrLZnDAmthq4VludqAwSCii4qXS7pTU+5S/Tr XfxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=2x1aJhG1xmYIfZnGIalvIAgLXEpAWQyV04ILeNRwUTE=; b=pUKykNjv4Gllz6uVisarF78ntVEH4PcvytpcVooNsUAgpN0e8yf3/G6rB/qWWOhuL9 9r/iH7uF0f5Ti2fvnkhbq/1xCSATkBoeI+0JYQZFZ4w1hYSsIfpxqyPGbo2nae9Rmegc UANNlXuNGJfEBHPhTxAqNktHP1UThHBKLHe0+vAO/LhJpSR/MCwBTLZyCLtloSAKH7Qe cAAIXazKtnIkZ8OQEvEyqruq9hdMYPIUdYHbOFLLighLs7VnvySt7g4ngA0dFgPP4e0h nKAjWsk+SgUJAuFtSdYHjvtBgd6S+AXxZQnq7R5XVhk/CJz0kTKZWV14uXWIORQExkdL DURQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=J+5ewe5y; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j193si610937pge.772.2022.02.14.01.01.17; Mon, 14 Feb 2022 01:01:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=J+5ewe5y; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242327AbiBNIpc (ORCPT + 99 others); Mon, 14 Feb 2022 03:45:32 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242294AbiBNIpa (ORCPT ); Mon, 14 Feb 2022 03:45:30 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 788F64EA0F for ; Mon, 14 Feb 2022 00:45:22 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 37EF6210E5; Mon, 14 Feb 2022 08:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644828321; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2x1aJhG1xmYIfZnGIalvIAgLXEpAWQyV04ILeNRwUTE=; b=J+5ewe5y7qKikUaNfaMUdQdzQcsICf954ZNUoxM3blMAVm61/38A8p7Q5ZRl77IT+5riOb 8CpfiNKDnTGc1h3+d2tFgAwJ/POZv2jtGRW7dmDaw/ZWeM5JQqpgGSc+tiKxc8GPMEPt6K f4UG6wlaPphdW3cqC2zfzxqi9MMBU0c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644828321; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2x1aJhG1xmYIfZnGIalvIAgLXEpAWQyV04ILeNRwUTE=; b=ET/VjbHHObt9CwBYc2l3K56eqmnEA0gz83nFm03IiM7Cmzxdzky33o8XgwUz1lzXqeMaIx VD4/03+VEqt5nFCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 1F0FCA3B8F; Mon, 14 Feb 2022 08:45:21 +0000 (UTC) Date: Mon, 14 Feb 2022 09:45:21 +0100 Message-ID: From: Takashi Iwai To: Matteo Martelli Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ALSA: usb-audio: revert to IMPLICIT_FB_FIXED_DEV for M-Audio FastTrack Ultra In-Reply-To: <20220211224913.20683-2-matteomartelli3@gmail.com> References: <20220211224913.20683-1-matteomartelli3@gmail.com> <20220211224913.20683-2-matteomartelli3@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Feb 2022 23:49:13 +0100, Matteo Martelli wrote: > > Commit 83b7dcbc51c930fc2079ab6c6fc9d719768321f1 introduced a generic > implicit feedback parser, which fails to execute for M-Audio FastTrack > Ultra sound cards. The issue is with the ENDPOINT_SYNCTYPE check in > add_generic_implicit_fb() where the SYNCTYPE is ADAPTIVE instead of ASYNC. > The reason is that the sync type of the FastTrack output endpoints are > set to adaptive in the quirks table since commit > 65f04443c96dbda11b8fff21d6390e082846aa3c. > > Signed-off-by: Matteo Martelli Thanks, applied now. Takashi