Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5558545pxb; Mon, 14 Feb 2022 01:53:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJzad2vC7oQYzHqqFbDXTCPLVVxuW+4Xj4i/k9y+drRWWGLmaVKe7KZjxn1XM+1fLZD8vOld X-Received: by 2002:a63:894a:: with SMTP id v71mr5069476pgd.600.1644832427372; Mon, 14 Feb 2022 01:53:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644832427; cv=none; d=google.com; s=arc-20160816; b=blBesbuBcNhaZ+zk3zKbpGz4aNv4YBly5P6PZ38IV52wIKmqxEN5vUeOezknDx/GkJ Gmms2syoB267cPcHdmrMBGQu2SnFcpK0vnBwJ11ceqIkQaMbQxD5+pWq9WxRL8mzADtu O44/NmOsVOrEooJjOZSbaYs4hJYp/pWHZwga44I0cUkvoXcP1jEYshQsxz8iZObcjBXS nvPPTDYm4vYniSnS45wMLv27UEjYGxKUDud4qFUsD2qtj9ZnjlLJUY4Xter6DpJmA5o6 D9OQuX1yzvni2JgJwTAEYd3NmP97yi5aoqW32j/JZ7nt0fCMjkIZNHBan+GfBDMfG/uH TJbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=v7wP/J61DHU5XGuWz8JqmjvQXm6VSa7ghh84hWJp5OI=; b=vhezERP2XxZ6HUKnQtYuwcfZQpE+UjKcmJr4UHbNBAue1DX8xQb5NwW5iRo6o5xt62 F0gtq6s3Cm/sZPQ18H86OA6Ot2fXPu/azpE76F7D4MTIeqUkVto1c+/at550I6Voei3Z HSATozHMP1Ba+Fy30YD90KDSP/usy6sYpbY5TtZNhe/ENaAveeL++dNLv9qnT9twjcoK aOkeMsZ5VyhrJUMl5BPQ0VZHIxaZ5dp3qGqeTwzZXnAGue6slRzmQ1hojgIUQ5UqCIsL zzWHnfMxUO6eU4dm7lGCpIpBobxcs2cgCuw+esnODBDCKvZnig2QRlu3b5+Aq4fn18/f OBDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7si28848633pgq.295.2022.02.14.01.53.33; Mon, 14 Feb 2022 01:53:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242231AbiBNIoN (ORCPT + 99 others); Mon, 14 Feb 2022 03:44:13 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242233AbiBNIoI (ORCPT ); Mon, 14 Feb 2022 03:44:08 -0500 Received: from mail-m17664.qiye.163.com (mail-m17664.qiye.163.com [59.111.176.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A2814EF59; Mon, 14 Feb 2022 00:44:01 -0800 (PST) Received: from localhost.localdomain (unknown [58.22.7.114]) by mail-m17664.qiye.163.com (Hmail) with ESMTPA id 3C344140158; Mon, 14 Feb 2022 16:43:59 +0800 (CST) From: Jon Lin To: broonie@kernel.org Cc: heiko@sntech.de, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jon Lin Subject: [PATCH v2 2/6] spi: rockchip: terminate dma transmission when slave abort Date: Mon, 14 Feb 2022 16:43:35 +0800 Message-Id: <20220214084339.18996-3-jon.lin@rock-chips.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220214084339.18996-1-jon.lin@rock-chips.com> References: <20220214084339.18996-1-jon.lin@rock-chips.com> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWRofSh9WHRkZShkeT0MfGE tPVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWVVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OUk6SDo4LD5PKBEQGT0NGR4w UU4aFAxVSlVKTU9PQ0lDSUhCQkhCVTMWGhIXVREUFVUXEhU7CRQYEFYYExILCFUYFBZFWVdZEgtZ QVlOQ1VJSVVMVUpKT1lXWQgBWUFJSkpINwY+ X-HM-Tid: 0a7ef767262fda2fkuws3c344140158 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After slave abort, all DMA should be stopped, or it will affect the next transmission and maybe abort again. Signed-off-by: Jon Lin --- Changes in v2: - Fix patches should be at the start of the series - Delete useless messages Changes in v1: None drivers/spi/spi-rockchip.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 4f65ba3dd19c..c6a1bb09be05 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -585,6 +585,12 @@ static int rockchip_spi_slave_abort(struct spi_controller *ctlr) { struct rockchip_spi *rs = spi_controller_get_devdata(ctlr); + if (atomic_read(&rs->state) & RXDMA) + dmaengine_terminate_sync(ctlr->dma_rx); + if (atomic_read(&rs->state) & TXDMA) + dmaengine_terminate_sync(ctlr->dma_tx); + atomic_set(&rs->state, 0); + spi_enable_chip(rs, false); rs->slave_abort = true; spi_finalize_current_transfer(ctlr); -- 2.17.1