Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Feb 2022 10:59:50 +0200
From:   Pekka Paalanen <ppaalanen@gmail.com>
To:     Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc:     <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
        <tzimmermann@suse.de>, <airlied@linux.ie>, <daniel@ffwll.ch>,
        <corbet@lwn.net>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] drm/doc: Clarify what ioctls can be used on render
 nodes
Message-ID: <20220214105950.7e399705@eldfell>
In-Reply-To: <1644433047-20753-1-git-send-email-quic_jhugo@quicinc.com>
References: <1644433047-20753-1-git-send-email-quic_jhugo@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/=kW+PCAj.SVDDFlVSKplH9l";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/=kW+PCAj.SVDDFlVSKplH9l
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Wed, 9 Feb 2022 11:57:27 -0700
Jeffrey Hugo <quic_jhugo@quicinc.com> wrote:

> The documentation for render nodes indicates that only "PRIME-related"
> ioctls are valid on render nodes, but the documentation does not clarify
> what that means.  If the reader is not familiar with PRIME, they may
> beleive this to be only the ioctls with "PRIME" in the name and not other
> ioctls such as set of syncobj ioctls.  Clarify the situation for the
> reader by referencing where the reader will find a current list of valid
> ioctls.
>=20
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> ---
>=20
> I was confused by this when reading the documentation.  Now that I have
> figured out what the documentation means, I would like to add a clarifica=
tion
> for the next reader which would have helped me.
>=20
>  Documentation/gpu/drm-uapi.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.=
rst
> index 199afb5..ce47b42 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -148,7 +148,9 @@ clients together with the legacy drmAuth authenticati=
on procedure.
>  If a driver advertises render node support, DRM core will create a
>  separate render node called renderD<num>. There will be one render node
>  per device. No ioctls except PRIME-related ioctls will be allowed on
> -this node. Especially GEM_OPEN will be explicitly prohibited. Render
> +this node. Especially GEM_OPEN will be explicitly prohibited. For a
> +complete list of driver-independent ioctls that can be used on render
> +nodes, see the ioctls marked DRM_RENDER_ALLOW in drm_ioctl.c  Render
>  nodes are designed to avoid the buffer-leaks, which occur if clients
>  guess the flink names or mmap offsets on the legacy interface.
>  Additionally to this basic interface, drivers must mark their

Hi,

I think this is correct, but I didn't actually check the code, so

Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>


Thanks,
pq

--Sig_/=kW+PCAj.SVDDFlVSKplH9l
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAmIKGgYACgkQI1/ltBGq
qqcfSBAAi7KZBj4UfBbRpE+DZy55fcnl4riq7F9On+Dv7toIXXlgYEJw8EW22vct
kCgVOHsNE2aL6qheIfk1p8QZysm8xYVByaM+w/qSBQLwAJHxmJsN12YsDohYQVgX
C64vtWfUPo1Ckf9dWjNKVMv+xpjMB0O4WkpFluzi4hNC4QnycbdROLvgOwnlhfdA
u53H9Nn3egNd9pkaXp3nS6yncUilzp6XPiR8PnXaCdYddLMAlC0TuCBjpkhP5hKN
ELamOUEY7lhuJHon7xz5HCCB2NbXW2+CleHBole3L65Tloju+Kw2kMc8F4e4wIze
gGAMD4/D4dri6F9tErrYaRSLg9Bps19qauCCxAdowfRZ7VHgsJYHMg5OBWwnHXb+
ytwCHC3NP9vHav3AcTSUdzpa5Oj6mHQR4Bq+BAcy78Cz2jbqA51ReyCZ7wZC7rmJ
aVVp4/ZY7iqbCSVqa0YwPadvEIgpJoxZrwzQnhZ6pPtfABYYyY6lUXr/wCpQBNPo
QOSEDdPQK2LReDWVpu/2pO8jF4fbhy0m2hoWJns+YeKhn1RAIhZwEeftFnkp6s6t
Q4oNnwehLaUIImAJre2IKRtWThwIVJIJD0Fc+XhNQENVHB11TFEzSWkrxAIVM3wd
glZ7Fb61Z6hupf3ZJkB8ErtdGqTskaTNHse71qcAmVl+4AcNFfg=
=nqHa
-----END PGP SIGNATURE-----

--Sig_/=kW+PCAj.SVDDFlVSKplH9l--