Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Feb 2022 00:14:23 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     "Brown, Len" <len.brown@intel.com>
Cc:     "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Len Brown <lenb@kernel.org>,
        Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] tools/power turbostat: Support thermal throttle
 count print
Message-ID: <20220211161423.GA55414@chenyu-dev>
References: <20211112115159.725357-1-yu.c.chen@intel.com>
 <PH0PR11MB4887077D94A30A5F757F01B4E0309@PH0PR11MB4887.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PH0PR11MB4887077D94A30A5F757F01B4E0309@PH0PR11MB4887.namprd11.prod.outlook.com>
Precedence: bulk

Hi Len,
On Fri, Feb 11, 2022 at 10:14:12AM +0800, Brown, Len wrote:
> What is the scope of this counter -- per-core or per-CPU?
>
The counter is read from
/sys/devices/system/cpu/cpu0/thermal_throttle/core_throttle_count,
which is calculated from MSR_IA32_THERM_STATUS (0x19c) in therm_throt.c.
According to sdm, this MSR is of core scope.

thanks,
Chenyu
> -----Original Message-----
> From: Chen, Yu C <yu.c.chen@intel.com>
> Sent: Friday, November 12, 2021 6:52 AM
> To: linux-pm@vger.kernel.org; Len Brown <lenb@kernel.org>
> Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>; Rafael J. Wysocki <rafael@kernel.org>; Brown, Len <len.brown@intel.com>; linux-kernel@vger.kernel.org; Chen, Yu C <yu.c.chen@intel.com>
> Subject: [PATCH 1/2] tools/power turbostat: Support thermal throttle count print
> 
> The turbostat data is collected by end user for power evaluationit. However it looks like we are missing enough thermal context there. Already a couple of time we found that power management developer asking something like this:
> grep -r . /sys/devices/system/cpu/cpu*/thermal_throttle/*
> 
> Print the per core thermal throttle count so as to get suffificent thermal context.
> 
> turbostat -i 5 -s Core,CPU,CoreThr
> Core    CPU     CoreThr
> -       -       104
> 0       0       61
> 0       4
> 1       1       0
> 1       5
> 2       2       104
> 2       6
> 3       3       7
> 3       7
> 
> Suggested-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>