Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5581727pxb; Mon, 14 Feb 2022 02:35:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJyeAuZlAbKsGcPxf5boFfQ3KLIYg4YDmF89CipIP4qJ4MibVSR+zY+PJ4Eq4iBUsm4ez2S1 X-Received: by 2002:a05:6402:d0d:: with SMTP id eb13mr14370319edb.83.1644834926589; Mon, 14 Feb 2022 02:35:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644834926; cv=none; d=google.com; s=arc-20160816; b=POcwWymyzBUz67ARHB6xBslWc/OTAE6nMRmT5Tuze5XYq/6zbyu1qnqcxHLu1cByo5 6E11KVgDUXMcFZ5h+LQ6u4awrSN3y8JVef/l55s9+iL6cYUqiEa6axwEp7KnT/ynkl5V PrgbCSUYb+leMcd50OgV7IpqqpGEtma5JCT+/t7FCWw6PUJ5uWwJmJBEoWHniDXHMupD eJckLfgRAf7vgCTLB/I+ERpqPxhPMSr++DTZEwtFRJbu0BseBJLY6cGlRZDtvzdTVYUB 1Ysuiw14foFtvus857XfdeOjzv9i6YgrDX/j33RpO2foN1Ob2U+2eS6voCqcOxx85dyu tQdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VLB9fpU2NYiq+Vn73wOgvQtRhP6Nxjn1CfGHP3oGUIg=; b=aHbfe1lfVwY8oCYV62TEw/oaLbSaJydapfsuC6UTNEOmTdcsg6JFVWnQ65AU5XE4VG R7qzTzZe5xjo/x0tKLlqoR6aa7Q0GN3Nfuw/kE7olm612aUvN+uJAxvKip3TSc7jPkie N3hWGtTjDmsh4NfPUxQJx8n7EZ+GFP2NnYB2DfygTcxrDjcXdsw71SB5AttKoCFFFyu6 rMolZrYzjleQ5q5q2nM5s+xM27nuepxHa7l5L6/uP+pd9oyqpSqtNzjEywK7uiJA/ITu exztagY0wkkgyUE+LXHhCa7ddLqLrUiJZTbsoUYREmQ6mH9+bYCbjc0I2NnZjpTgjz1a 46qA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=c3CoH1y1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a73si20964817edf.274.2022.02.14.02.35.03; Mon, 14 Feb 2022 02:35:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=c3CoH1y1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242862AbiBNJYu (ORCPT + 99 others); Mon, 14 Feb 2022 04:24:50 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbiBNJYt (ORCPT ); Mon, 14 Feb 2022 04:24:49 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21FFE60A87; Mon, 14 Feb 2022 01:24:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644830682; x=1676366682; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Ed8p7wZmfq9qaecYJ91WYD/Rtq61LoHJ4xgf1YjcwCc=; b=c3CoH1y1hvC3f7K38/iFAfUx3ifQbvWjuZYaLUxtA+GXdoAN590Gmx5+ RkblPnQcWYe8dnDgFRJf/KXq0IIVNZyq6cGlVg9OoeWIlXEyvAs1SjYjy iUVP/F8VFabTi5DpNYwcJ6kSEnA+Nil0diX7W+aej+hf6WpUY2Y4TQHp/ PRK9DI+lJoz57xNqNCeGsbohBYlRYVDy2UAwNmWRbLobVhF3eAGRmSdKy vya111AdTOc4ectwcqH1i75XyW0sCfmBxFu3Xg90emVW7e2H+Pz4p5MiF iTTuouFi3AcTFiRQZ0qckEfgYdk6J2wjoe4t9AtaNQKuecXR6kgXiZOgb g==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="250256698" X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="250256698" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 01:24:41 -0800 X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="635042341" Received: from smile.fi.intel.com ([10.237.72.61]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 01:24:40 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nJXaC-004OMi-AY; Mon, 14 Feb 2022 11:23:44 +0200 Date: Mon, 14 Feb 2022 11:23:44 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nuno =?iso-8859-1?Q?S=E1?= , Lars-Peter Clausen Subject: Re: [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Message-ID: References: <20220210135522.26562-1-andriy.shevchenko@linux.intel.com> <20220213175559.46e8dee2@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220213175559.46e8dee2@jic23-huawei> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 13, 2022 at 05:55:59PM +0000, Jonathan Cameron wrote: > On Thu, 10 Feb 2022 15:55:20 +0200 > Andy Shevchenko wrote: > > > In a couple of messages the constants, which have their definitions, > > are hard coded into the message text. Unhardcode them. > > > > While at it, add a trailing \n where it's currently missing. > > > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Nuno S? > > Mostly so I can remember what is going on with this patch, > Nuno is OoO and planning to test this series when he returns. > > Given that I'll wait on Nuno's testing. Me too :-) -- With Best Regards, Andy Shevchenko