Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6712a07b-d1ac-520d-8bbb-7539476ec679@nvidia.com>
Date:   Fri, 11 Feb 2022 16:24:15 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v5 0/5] mm/gup: some cleanups
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>,
        Peter Xu <peterx@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>
Cc:     David Hildenbrand <david@redhat.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
References: <20220207062213.235127-1-jhubbard@nvidia.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220207062213.235127-1-jhubbard@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OG5hNGlNSlpMVS9US0h2S0c3eHJ6QjBXYlJFbjN2dzZOS3dEM094SUFSdG5G?=
 =?utf-8?B?cXBENTVLa1NLN01UdmNsbTRucE84UjRuVGpiQjBlQ2F4U3ljenpQU3NwdFIw?=
 =?utf-8?B?SlZtQWs1N2ZsRkdpWDJudE41alA2OTdpS2tZcU55UzBKNWYxRW95d2FyRWw2?=
 =?utf-8?B?YjBFdG1lOUMvdU1hOE1UQlNLZXltZC9OeWlaWWpINEE2VzMzT0VNaE1iaVZm?=
 =?utf-8?B?cERQQWJYSUFEVGJDdU94RkxRTHVTQTBTbXdUTHFZWXdQMXJqdGJ0bkRxcDRW?=
 =?utf-8?B?Y3FWa2dTWTlxWWFoaFZBUFFyZjNMcklvaXlLVzBHK0VVUkx4Z1E4cjBxTHBR?=
 =?utf-8?B?WWZvNDVKeFZIalYzWTVMUmFWWFh4VjVCLzAxZUNDRVc3d1RFT3BDWk5qblhD?=
 =?utf-8?B?RVViZ3RnazdpTkE5dXdXb3ZrMkkwc2swTnp1QVUyUGRKSk9zMGFrQSs2VkxZ?=
 =?utf-8?B?TnUxdDFhVVM5UGVpd2tCcGs4ZWJvOTRGUUo1Nk5rUUNwMTNUTVpQM2c4L0tO?=
 =?utf-8?B?VWwrUzJMbXFsZ0lRUHpjcTNqZlV4enZjWmNTZzRKMlJVTDVySGlKN2JZd1JY?=
 =?utf-8?B?Zlh2M1NKdVFLZWpyRU96Z1RGNjlOamZVTHl5ZFRmZFJqaE80TlJRUlJTb1Zk?=
 =?utf-8?B?bmRDdmMxa0FsTU1oTkI4RWhHNmk4TDA0Nk5jOGx1TnUvaS9pMFpocnVhcVBy?=
 =?utf-8?B?cFJ2RFY4QlVybVNrNkQwOE9uSEw4WjNrdlRlc1ZzMmtqSXdRZE4rQkllWkNY?=
 =?utf-8?B?NE9vZFY0SncyT3BWYmdUVmpxSWk4Qks1REp6WmVIUUNkWU4rbVhZZlRoRHpU?=
 =?utf-8?B?OHpNWU9DWHF6K1JHOUdQb0w1Q0FOZEZNWWRZbk5nOVNnNW1iMXJub0pjYTVl?=
 =?utf-8?B?QzZGbnRycVI0WmNSVWppMzRIYkxmbG5TUDg1OE45KzZyZk1TdWMyQXNFQmFS?=
 =?utf-8?B?VWhycXcvb1pVb0tCK00yQVBQN2xBOVU3VFM3UFhMMzBxWHFaM1pXaW9aRlR2?=
 =?utf-8?B?NlVFN25TYVNUalhyQmVhRGxxS2xnUmRndUFoVnF0c2VCV0p0NXk0UWUwRmRE?=
 =?utf-8?B?ZDhBRzRkOWE3QytRRnlYank0SFRTbkNwL1FRNTFmdFZRY3NNcU9ha0pxbCti?=
 =?utf-8?B?ZWxZemtORXFhNGh5MUU0YXpsL3lkY1ZZZUtMS05WbDhjLzkwdTV3SEZFK1BK?=
 =?utf-8?B?T0VmZGxOVm9ROGVZQ21HRCtyU3RPZ0ozdTErN2s3R2VNVzJndEdJT3hmeEVY?=
 =?utf-8?B?VTJ1bWFPbmE2WG1jNkVzRXpYeno0Tnp6ZXpBbjMzWlNCWWU2cjZ0YmlmR1hJ?=
 =?utf-8?B?MW5Gdk9sQk50SkNUMkx2MmpWOElrK25ybnIvcUNrZm9wS1NiZ0xiU0tqT1Q2?=
 =?utf-8?B?QmQxeisrbFZGbXpXR3NnRGRST1Z1OVhUekxKY3ZFSWM3TUNMU0dWSG5RcUJI?=
 =?utf-8?B?QnpXV1hEbWdPbkhPcFF5VktLY2hhZkZmODVsYWlkb1JtRTF3UHhRVEtFNVNN?=
 =?utf-8?B?d3dTdDhDQ215T2VmWkpndVc4ODlRSjRKUEh4TkhKb3d6aGdqcjYzeTMwWlUw?=
 =?utf-8?B?UWt1NUNjY2JYVElsdU5SUUVEUGhZNFM3S3FCV1U3c2c4c2pwaXI5ektucGFG?=
 =?utf-8?B?Z3VVTk5Ld0Q0dUVnU1lQV213bHhxSCtaa3huMXZsTnVwMkEzYVQwT1gxcmJK?=
 =?utf-8?B?OHZCdk9FZ2F5eHN4RGcyQWFlK3U2Unp1T1psWHBpOXZQMzhIUU9ZN21vTzZI?=
 =?utf-8?B?ZEdrZVphWGdYTDM0NGw5Y3JMbE53Z2FqRGRGeTBaVzVNcWgyL2J2T2Vucmk5?=
 =?utf-8?B?ZkV4OFRJMFg3T0NjZ1RHS2YyRXZweXZxSDB6UGw1MmxJL2dSOTdBWEJoZ0Mx?=
 =?utf-8?B?eEtiQlMxdHNxb1lHSVZvZzVFUm5PVGVSclNpZC9tN295U2xRS290a2hjYnNz?=
 =?utf-8?B?Ti9INjFuRVBLTW5sb28vR2Vpb0VzbTB4eVZlMEZCNkRLcTJubTB2MFVXbDNW?=
 =?utf-8?B?bnVnUko4bE5Na2VqNk0zUzNwWU81NWMxZytFYmN2K1d6L1RTTnIvdUpvWnNr?=
 =?utf-8?B?RDd6UGJUcU5UdzZsdGdFMjRSM1I3cmVFV3FiN3VucEpsOFZUN2xDZks3aGF0?=
 =?utf-8?B?dUNGODBKa2daUzNpcnFnTFZ0TUltcVNlOWpwbEtwN25nOEIrR0c5SWE5bU54?=
 =?utf-8?Q?ppmIlOK8sJkKi9BAIhVWni0=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f90f26e3-4edf-42b2-7779-08d9edbe0115
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2022 00:24:17.0182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6HPtxR8c7BE9GSq0TOHXKpul1xUM+/ay4ATctO6CyRDAG0EwhksDElQkibNFawRAp7I2jEH2g3Gw4oGYlAofyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3743
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/6/22 22:22, John Hubbard wrote:
> Hi,
> 
> Here's an update, mainly just collecting reviewed-by tags:
> 
> Changes since v4:
> 
>      * Patch 1: reflowed the commit description to 72 columns.
> 
>      * Added reviewed-by's from Christoph and Jan for remaining patches.
> 
>      * Rebased onto 5.17-rc3.
> 

Hi Andrew,

Is this OK to put in mmotm yet? All the patches here have been reviewed.
And this small series also does not conflict with Willy's "[PATCH 00/75]
MM folio patches for 5.18" series.


thanks,
John Hubbard

> 
> Changes since v3:
> 
>      * Patch 1: Commit log: removed a reference to an out of tree module,
>        and updated tags and added a short note to that effect.
> 
>      * Patch 2: Fixed up do_move_pages(), to squash -EEXIST returns from
>        follow_page() into something that move_pages() allows: -EFAULT.
>        This is from reviews by Jan Kara, Matthew Wilcox, Jason Gunthorpe.
> 
>        Removed all Reviewed-by tags for this patch, due to that update.
> 
>      * Patch 4: Split into two patches, as recommended by Christoph
>        Hellwig. Left the Reviewed-by tags intact because no code changes
>        were required.
> 
>      * Added Reviewed-by tags from Claudio Imbrenda.
> 
> Changes since v2:
> 
>      * Patch 2: Removed an unnecessary line that was causing a
>        clang-analyzer complaint, as reported by Lukas Bulwahn
>        [1] (thanks!), and retested locally.
> 
>        Jason: I've boldly left your Reviewed-by tag on this patch,
>        because I am predicting you'll agree with it...
> 
>      * Added Reviewed-by tags from Jan Kara, Christoph Hellwig, and
>        Jason Gunthorpe that have collected since v2.
> 
> 
> Changes since v1:
>      * Patch 4: changed from get_user_pages(), to get_user_pages_fast().
> 
>      * Patch 4: Rewrote the commit description--thanks to Jan Kara for
>                 that feedback.
> 
>      * Patch 1: Removed Jerome's Cc from patch 1, due to a stale email
>                 address.
> 
>      * Added Reviewed-by's from David Hildenbrand and Jason Gunthorpe.
> 
> Original cover letter, updated as necessary:
> 
> I'm including Peter's patch as the first one in this tiny series. (The
> commit description has my r-b tag in place of my Cc, and removes
> Jerome's Cc because he is no longer at redhat.com) The second patch is
> what I had in mind for a follow-up to that, when we were discussing that
> fix [2].
> 
> Plus, a couple more small removals that I had queued up:
> 
> The third patch removes a completely unused routine:
> pin_user_pages_locked().
> 
> The forth patch removes a similar routine, get_user_pages_locked(), that
> only has one caller. It now calls get_user_pages_fast(), instead.
> 
> v1 of this patchset is here:
> https://lore.kernel.org/all/20220131051752.447699-1-jhubbard@nvidia.com/
> 
> v2:
> https://lore.kernel.org/r/20220201101108.306062-1-jhubbard@nvidia.com
> 
> v3:
> https://lore.kernel.org/r/20220203093232.572380-1-jhubbard@nvidia.com
> 
> v4:
> https://lore.kernel.org/r/20220204020010.68930-1-jhubbard@nvidia.com
> 
> 
> [1] https://lore.kernel.org/r/CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com
> 
> [2] https://lore.kernel.org/all/20220125033700.69705-1-peterx@redhat.com/
> 
> 
> John Hubbard (4):
>    mm/gup: follow_pfn_pte(): -EEXIST cleanup
>    mm/gup: remove unused pin_user_pages_locked()
>    mm: change lookup_node() to use get_user_pages_fast()
>    mm/gup: remove unused get_user_pages_locked()
> 
> Peter Xu (1):
>    mm: Fix invalid page pointer returned with FOLL_PIN gups
> 
>   include/linux/mm.h |   4 --
>   mm/gup.c           | 101 ++++-----------------------------------------
>   mm/mempolicy.c     |  21 ++++------
>   mm/migrate.c       |   7 ++++
>   4 files changed, 24 insertions(+), 109 deletions(-)
> 
> 
> base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566