Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Feb 2022 10:07:11 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Changming Huang <jerry.huang@nxp.com>
Cc:     leoyang.li@nxp.com, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jianchao Wang <jianchao.wang@nxp.com>
Subject: Re: [PATCH] arm64: dts: fsl-ls1028a: add dspi2 support
Message-ID: <20220213020710.GH4909@dragon>
References: <20220208042610.2026531-1-jerry.huang@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220208042610.2026531-1-jerry.huang@nxp.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Tue, Feb 08, 2022 at 12:26:10PM +0800, Changming Huang wrote:
> Enable MikroBUS SPI port.
> 
> Signed-off-by: Jianchao Wang <jianchao.wang@nxp.com>
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index 68c31cb8eead..af2c7eb07eaf 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -93,6 +93,19 @@ simple-audio-card,codec {
>  	};
>  };
>  
> +&dspi2 {

Sort the labeling node alphabetically.

> +	bus-num = <2>;
> +	status = "okay";
> +
> +	mikrobus@0 {
> +		compatible = "semtech,sx1301";

Did you run dtbs_check?

Shawn

> +		reg = <0>;
> +		spi-max-frequency = <2000000>;
> +		fsl,spi-cs-sck-delay = <1000000>;
> +		fsl,spi-sck-cs-delay = <50>;
> +	};
> +};
> +
>  &can0 {
>  	status = "okay";
>  
> -- 
> 2.25.1
>