Date: Tue, 13 Feb 2007 08:10:23 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andi Kleen <ak@suse.de>, Christoph Hellwig <hch@infradead.org>,
       Segher Boessenkool <segher@kernel.crashing.org>, patches@x86-64.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension
Message-Id: <20070213081023.1fc951ff.randy.dunlap@oracle.com>
In-Reply-To: <200702131611.15172.arnd@arndb.de>
References: <20070212551.664370000@suse.de>
	<200702131611.15172.arnd@arndb.de>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 960
Lines: 25

On Tue, 13 Feb 2007 16:11:14 +0100 Arnd Bergmann wrote:

> On Monday 12 February 2007 17:51, Andi Kleen wrote:
> > setcc() in math-emu is written as a gcc extension statement expression
> > macro that returns a value. ?However, it's not used that way and it's not
> > needed like that, so just make it a do-while non-extension macro so that we
> > don't use an extension when it's not needed.
> > 
> 
> The patch looks good but it doesn't match the description any more, since
> you now use a function...

Hi Arnd,
Someone else had that same comment, so I sent a corrected patch
(description change only) to that mail.

Thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/