Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5709572pxb; Mon, 14 Feb 2022 05:56:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTgyiM8/N3GIiZgnlm1HSztm6dF57sXejftOhhsUZDQ1MsQEP8+7hA+Abzdig1AcJUcLNU X-Received: by 2002:a17:90b:2153:: with SMTP id kt19mr6384032pjb.207.1644847018257; Mon, 14 Feb 2022 05:56:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644847018; cv=none; d=google.com; s=arc-20160816; b=ukvD0npF/7yAPKT23CL023/JVxEuLLrr66GtcRtj8Knnd+F6dOHsIiy6tngEqczzDQ WaCiEVBOkrdpF8MbKeSGlaBxmHIDZgCJUr40QAzq0ATiKYsO3MLVR0MXPjUFC+04Lbnt r7Do9KeICL4p8hz/zLkc4rON2ghQGJly/n6anahs3gLsknqEBpRJUJJy7OPUyDXLzp+i 5p0lgVPlGqp7zoqo1lRnn03wQudF/h3AHH/449QEzoMv80s1NA9RQyDQqkxSBGGqnDYG LGV/iO7KoYW54EENiXS2USG7W0Baet2uB1x3QucT1XJREggzx3Jq07ajmgh93OalWAN6 NCTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=U4KPTW8dlpRn7woKQYxVoiIsn2GlSXxEY0wYq7cQZUg=; b=ogtDunqQ/nuwDkgRyXFMbKQYACh67cWCALkVCxlM0dyJqi8Mq6a9/J70bsUePKKol7 ER5QcBHv2kjkyrQcd3AEkWD91kRfCp3DhSvik1g07s3u020pr3S0yj/s5u9J82irffdA 04G60OUZiEBWk828GIRODRczSTY9c5XJ0ZdtEHpWjrctvS3waYRbphk41XUJ+Qmf3/+e GVljwoyrY+a4r1e0gWI3uHwnMb175SKKbxVOmfIS1JjlkodQKGQrfy2wALqsxmYk1DOu UYVZ9duECkxPniSX7hE7Pj73yVjonjHKGH3s3UhY+Auaezm/joxCpC16Yqf7SDBk4OQ8 Zf1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Uv5SsfQu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e2si2326959pgb.321.2022.02.14.05.56.42; Mon, 14 Feb 2022 05:56:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Uv5SsfQu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243445AbiBNLtI (ORCPT + 99 others); Mon, 14 Feb 2022 06:49:08 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352043AbiBNLja (ORCPT ); Mon, 14 Feb 2022 06:39:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2151EE0EE; Mon, 14 Feb 2022 03:29:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B2B3D611AF; Mon, 14 Feb 2022 11:29:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D912C340E9; Mon, 14 Feb 2022 11:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644838192; bh=X/vj9bZ7G1cVDoVme5LRY1sPodeCFxRDwg34D93ziYw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uv5SsfQuTXs2i2R1L8ykWa/fJBxk/gBL4Sh+B28sSyioGyDt1WYw0BULm3wuSExGJ j5dm8CUpeYPJpQv0a8NhxxyFyAeoX5QczTroGqwGWw+L4/Ii3WrABUWpVS6l0UTLxV LQP3eEbzrmSOZFmPhZ5fMop+O12c7LGD8IaqZSlo= Date: Mon, 14 Feb 2022 12:29:49 +0100 From: Greg Kroah-Hartman To: Daehwan Jung Cc: Felipe Balbi , linux-usb@vger.kernel.org, open list , quic_wcheng@quicinc.com, quic_jackp@quicinc.com, Thinh.Nguyen@synopsys.com Subject: Re: [PATCH v2 1/2] usb: dwc3: Not set DWC3_EP_END_TRANSFER_PENDING in ep cmd fails Message-ID: References: <1644836933-141376-1-git-send-email-dh10.jung@samsung.com> <1644836933-141376-2-git-send-email-dh10.jung@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644836933-141376-2-git-send-email-dh10.jung@samsung.com> X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 14, 2022 at 08:08:52PM +0900, Daehwan Jung wrote: > It always sets DWC3_EP_END_TRANSFER_PENDING in dwc3_stop_active_transfer > even if dwc3_send_gadget_ep_cmd fails. It can cause some problems like > skipping clear stall commmand or giveback from dequeue. We fix to set it > only when ep cmd success. Additionally, We clear DWC3_EP_TRANSFER_STARTED > for next trb to start transfer not update transfer. So is this two different changes? > > Signed-off-by: Daehwan Jung What commit id does this fix? thanks, greg k-h