Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Feb 2022 14:36:37 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Yun Zhou <yun.zhou@windriver.com>
Cc:     "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Xue, Ying" <Ying.Xue@windriver.com>
Subject: Re: =?utf-8?B?5Zue5aSN?= =?utf-8?Q?=3A?= [PATCH] spi: disable
 chipselect after complete transfer
Message-ID: <Ygpo9YT9PrQAAIH3@sirena.org.uk>
References: <SN6PR11MB3008AF5619B0B026836FD7429F2F9@SN6PR11MB3008.namprd11.prod.outlook.com>
 <YgU1+cIlANAkJCAL@sirena.org.uk>
 <19c69765-8584-2e6b-25b8-7053a5afa5d4@windriver.com>
 <YgVH310gQ1sK6dlr@sirena.org.uk>
 <a5aa6dcf-e3dd-e8ff-edcb-edad96f8ddfe@windriver.com>
 <YgpOzw2rq+vAIPBU@sirena.org.uk>
 <8fd9c3ef-df64-b8ad-de6e-ef86806d53b5@windriver.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="72Gu1XoZSGNCURKI"
Content-Disposition: inline
In-Reply-To: <8fd9c3ef-df64-b8ad-de6e-ef86806d53b5@windriver.com>
Precedence: bulk


--72Gu1XoZSGNCURKI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 14, 2022 at 10:20:21PM +0800, Yun Zhou wrote:

> I can't see from anywhere that when cs_change is true, we must keep CS
>=20
> active. If an individual controller needs to keep CS active after the who=
le
>=20
> message transmission complete, I think we should set cs_change to false
>=20
> rather than true, because cs_change means to change CS, not keep CS,
>=20
> otherwise let us rename cs_change to cs_keep.

*sigh*  Please also look back at how this has historically been handled,
this is not new behaviour.  I'm not saying that this is the greatest API
ever or that it'd be done this way if it were new but that doesn't mean
we can just randomly change the interface and potentially disrupt users.
Whatever else is going on the current behaviour is intentional.

--72Gu1XoZSGNCURKI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIKaPUACgkQJNaLcl1U
h9CO1Qf/SC6MsM85RZDC2oqwT9XGNHnNUR8k9EPhEH+we3qFs2cv3N5L/5twaJHq
8aRJrzYs0WQ4BQyzlD72pJpNJOJu0XGHV/hN7seoaS1S4BNVi/C+z8ZqpeKSEXmg
3uq6LAnTC4dGklhP9Uvl7nwEgLVH9NULVN1xCUnNBFRP8g4mcQGegtPV+LM+M4Nd
7mOcwLzbsRwsG5XuLV0NeGWcNKYBWu79rqHY9f4Addz1x2NSJL100UlmqeEiT4Bv
75t8zjyTFr6EG9roywTHrKk1tDF+97WrCpTQeIG0xMPwHfPkEVDOV2o3vh+IOqIF
Bcd/6oYu94DXuNNuWY3IlhvhLQNI/Q==
=ko9Y
-----END PGP SIGNATURE-----

--72Gu1XoZSGNCURKI--