Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5892716pxb; Mon, 14 Feb 2022 10:00:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwfURVuV018CCO9iFz9JHgwGJRtC0KVHNB1wsL9NIl184guZVL8LcJSQXZ+DHXb6o7Viwva X-Received: by 2002:a17:902:b089:: with SMTP id p9mr9571plr.93.1644861600533; Mon, 14 Feb 2022 10:00:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644861600; cv=none; d=google.com; s=arc-20160816; b=0g4b/MRhAMjRwhjmb2ru300xSMMmM9IEXZeDJmF8ubr37jKJafYLhYwFWdRWZFb/ZC 0DWiIxdEKVBW9U8zxB8mwtdduxP+BF2hax33/pqP7lqgRFelBA8ZK2JMunuWwPqDUDmf 9GI4K00oPCTdA6Xd/0l5zUgw7afihOS1VQZ4ZbtEwudd2dea6TyaG8ajwuC263MymgPZ fWjJ+K+u8EHY1Gf4b5z6XzQLsAQVT7qwn1l6oOexWwhD7seaGCt8eKyedN5wwmoLxOHF /69rvUsTLBLMV/+bZAytePUiW3foGJ61n5VtPS/JCVGI1Dv0FsOOfsNvdrvmYKvwOSqb Jaww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=XupNKR4GyscaQKgFluEmcElSg7eR+bZl/zOrMV/9geY=; b=HeJ2j6GtEVn3RmFqwy8Y3QXzJ/a27gO4dpUJOw56zeObxI9ufcg2nCY+imwmQCCJ2j N5Q92BBX1vasazpPm8rezz9zBMfxOYyxH1rRtbvAy4oJK42pq5w3crSLaB9e/+MOiwCo EzJaqqUI3uqiDHIBH5yAVXM+lK5WA6lNAa4CfHX6rxW9DrvrcAC97GAqNr+iwlRQT6Rv bbVswpFN3RiFcXHv7xumbWFEQmaHXio60HM8PcYULuUGsDjGiS3KCCMe5YHWy8HIyaLr xZv6ejy47rH6ZLtwBGU0BioVO7i/8FdnkmOW4u5DBvureFhD1oiOgk9gcj+26X1ZtheF u6Ng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l7si15313468plh.398.2022.02.14.09.59.44; Mon, 14 Feb 2022 10:00:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353886AbiBNNFW (ORCPT + 99 others); Mon, 14 Feb 2022 08:05:22 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344837AbiBNNFU (ORCPT ); Mon, 14 Feb 2022 08:05:20 -0500 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AAF74D609 for ; Mon, 14 Feb 2022 05:05:13 -0800 (PST) Received: by theia.8bytes.org (Postfix, from userid 1000) id 18F206BF; Mon, 14 Feb 2022 14:05:12 +0100 (CET) Date: Mon, 14 Feb 2022 14:05:10 +0100 From: Joerg Roedel To: Robin Murphy Cc: will@kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, baolu.lu@linux.intel.com Subject: Re: [PATCH] iommu: Remove trivial ops->capable implementations Message-ID: References: <8413578c6f8a7cf75530b00cba8f10f5b88f8517.1644495614.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8413578c6f8a7cf75530b00cba8f10f5b88f8517.1644495614.git.robin.murphy@arm.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 12:29:05PM +0000, Robin Murphy wrote: > Implementing ops->capable to always return false is pointless since it's > the default behaviour anyway. Clean up the unnecessary implementations. > > Signed-off-by: Robin Murphy > --- > > Spinning this out of my bus ops stuff (currently 30 patches and > counting...) since it would be better off alongside Baolu's cleanup > series to avoid conflicts, and I want to depend on those patches for > dev_iommu_ops() anyway. > > drivers/iommu/msm_iommu.c | 6 ------ > drivers/iommu/tegra-gart.c | 6 ------ > drivers/iommu/tegra-smmu.c | 6 ------ > 3 files changed, 18 deletions(-) Applied, thanks Robin.