Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Envelope-to: dwmw2@infradead.org,
 mdf@kernel.org,
 trix@redhat.com,
 linux-kernel@vger.kernel.org,
 robh@kernel.org,
 devicetree@vger.kernel.org,
 yilun.xu@intel.com
Subject: Re: [PATCH V1 Create empty OF root 1/1] of: create empty of root
To:     Xu Yilun <yilun.xu@intel.com>, Lizhi Hou <lizhi.hou@xilinx.com>
CC:     <devicetree@vger.kernel.org>, <robh@kernel.org>,
        <linux-kernel@vger.kernel.org>, <maxz@xilinx.com>,
        <sonal.santan@xilinx.com>, <yliu@xilinx.com>,
        <michal.simek@xilinx.com>, <stefanos@xilinx.com>,
        <trix@redhat.com>, <mdf@kernel.org>, <dwmw2@infradead.org>,
        Max Zhen <max.zhen@xilinx.com>
References: <20220126054807.492651-1-lizhi.hou@xilinx.com>
 <20220126054807.492651-2-lizhi.hou@xilinx.com>
 <20220211153801.GA1273192@yilunxu-OptiPlex-7050>
From:   Lizhi Hou <lizhi.hou@xilinx.com>
Message-ID: <14bd131d-c978-e669-df55-45b58ff3bf6e@xilinx.com>
Date:   Fri, 11 Feb 2022 17:02:56 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <20220211153801.GA1273192@yilunxu-OptiPlex-7050>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2022 01:02:57.4720
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fd3b50e-efba-432d-8c3d-08d9edc36867
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT054.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7743
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yilun,

Thanks a lot for your feedback. I will revise the comments and send 
another patch.

In the meanwhile, based on our previous discussion,

https://lore.kernel.org/lkml/20220111070000.GC979169@yilunxu-OptiPlex-7050/

I will propose another patch to add an of_pci interface which can be 
called by pci driver probe routine to create device node for it.


Thanks,

Lizhi

On 2/11/22 7:38 AM, Xu Yilun wrote:
> On Tue, Jan 25, 2022 at 09:48:07PM -0800, Lizhi Hou wrote:
>> Add OF_EMPTY_ROOT config. When it is selected and there is not a device
>> tree, create an empty device tree root node.
> Maybe add some description about why a empty device tree root node is
> needed. Note that the Patch #0 will not be present in the repo when the
> series will be merged, so add your description here please.
>
>> Signed-off-by: Sonal Santan <sonal.santan@xilinx.com>
>> Signed-off-by: Max Zhen <max.zhen@xilinx.com>
>> Signed-off-by: Lizhi Hou <lizhi.hou@xilinx.com>
>> ---
>>   drivers/of/Kconfig         |  3 +++
>>   drivers/of/Makefile        |  1 +
>>   drivers/of/of_empty_root.c | 51 ++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 55 insertions(+)
>>   create mode 100644 drivers/of/of_empty_root.c
>>
>> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
>> index 80b5fd44ab1c..42afb126f91a 100644
>> --- a/drivers/of/Kconfig
>> +++ b/drivers/of/Kconfig
>> @@ -94,4 +94,7 @@ config OF_DMA_DEFAULT_COHERENT
>>   	# arches should select this if DMA is coherent by default for OF devices
>>   	bool
>>   
>> +config OF_EMPTY_ROOT
>> +	bool
> Also some descriptions for better understanding?
>
> Thanks,
> Yilun
>
>> +
>>   endif # OF
>> diff --git a/drivers/of/Makefile b/drivers/of/Makefile
>> index e0360a44306e..c65364f32935 100644
>> --- a/drivers/of/Makefile
>> +++ b/drivers/of/Makefile
>> @@ -12,6 +12,7 @@ obj-$(CONFIG_OF_RESERVED_MEM) += of_reserved_mem.o
>>   obj-$(CONFIG_OF_RESOLVE)  += resolver.o
>>   obj-$(CONFIG_OF_OVERLAY) += overlay.o
>>   obj-$(CONFIG_OF_NUMA) += of_numa.o
>> +obj-$(CONFIG_OF_EMPTY_ROOT) += of_empty_root.o
>>   
>>   ifdef CONFIG_KEXEC_FILE
>>   ifdef CONFIG_OF_FLATTREE
>> diff --git a/drivers/of/of_empty_root.c b/drivers/of/of_empty_root.c
>> new file mode 100644
>> index 000000000000..5c429c7a27bd
>> --- /dev/null
>> +++ b/drivers/of/of_empty_root.c
>> @@ -0,0 +1,51 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2022 Xilinx, Inc.
>> + */
>> +
>> +#include <linux/of.h>
>> +#include <linux/slab.h>
>> +
>> +#include "of_private.h"
>> +
>> +static int __init of_root_init(void)
>> +{
>> +	struct property *prop = NULL;
>> +	struct device_node *node;
>> +	__be32 *val = NULL;
>> +
>> +	if (of_root)
>> +		return 0;
>> +
>> +	pr_info("Create empty OF root node\n");
>> +	node = kzalloc(sizeof(*node), GFP_KERNEL);
>> +	if (!node)
>> +		return -ENOMEM;
>> +	of_node_init(node);
>> +	node->full_name = "/";
>> +
>> +	prop = kcalloc(2, sizeof(*prop), GFP_KERNEL);
>> +	if (!prop)
>> +		return -ENOMEM;
>> +
>> +	val = kzalloc(sizeof(*val), GFP_KERNEL);
>> +	if (!val)
>> +		return -ENOMEM;
>> +	*val = cpu_to_be32(sizeof(void *) / sizeof(u32));
>> +
>> +	prop->name = "#address-cells";
>> +	prop->value = val;
>> +	prop->length = sizeof(u32);
>> +	of_add_property(node, prop);
>> +	prop++;
>> +	prop->name = "#size-cells";
>> +	prop->value = val;
>> +	prop->length = sizeof(u32);
>> +	of_add_property(node, prop);
>> +	of_root = node;
>> +	for_each_of_allnodes(node)
>> +		__of_attach_node_sysfs(node);
>> +
>> +	return 0;
>> +}
>> +pure_initcall(of_root_init);
>> -- 
>> 2.27.0
>