Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 14 Feb 2022 12:30:32 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Daehwan Jung <dh10.jung@samsung.com>
Cc:     Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        quic_wcheng@quicinc.com, quic_jackp@quicinc.com,
        Thinh.Nguyen@synopsys.com
Subject: Re: [PATCH v2 2/2] usb: dwc3: Prevent cleanup cancelled requests at
 the same time.
Message-ID: <Ygo9WMCVRNp/4/Ry@kroah.com>
References: <1644836933-141376-1-git-send-email-dh10.jung@samsung.com>
 <CGME20220214111149epcas2p29b9e39b84d7203572422531beb3c39ed@epcas2p2.samsung.com>
 <1644836933-141376-3-git-send-email-dh10.jung@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1644836933-141376-3-git-send-email-dh10.jung@samsung.com>
Precedence: bulk

On Mon, Feb 14, 2022 at 08:08:53PM +0900, Daehwan Jung wrote:
> We added cleanup cancelled requests when ep cmd timeout on ep dequeue
> because there's no complete interrupt then. But, we find out new case
> that complete interrupt comes up later. list_for_each_entry_safe is
> used when cleanup cancelled requests and it has vulnerabilty on multi-core
> environment. dwc3_gadget_giveback unlocks dwc->lock temporarily and other
> core(ISR) can get lock and try to cleanup them again. It could cause
> list_del corruption and we use DWC3_EP_END_TRANSFER_PENDING to prevent it.
> 
> 1. MTP server cancels -> ep dequeue -> ep cmd timeout(END_TRANSFER)
> 	-> cleanup cancelled requests -> dwc3_gadget_giveback ->
> 	list_del -> release lock temporarily
> 2. Complete with END_TRANSFER -> ISR(dwc3_gadget_endpoint_command_complete)
> 	gets lock -> cleanup cancelled requests -> dwc3_gadget_giveback
> 	-> list_del
> 3. MTP server process gets lock again
> 	-> tries to access POISON list(list_del corruption)
> 
> [2: MtpServer: 5032] dwc3 10b00000.dwc3: request cancelled
> 						with wrong reason:5
> [2: MtpServer: 5032] list_del corruption,
> 		ffffff88b6963968->next is LIST_POISON1 (dead000000000100)
> 
> Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> ---
>  drivers/usb/dwc3/gadget.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

What commit id does this fix?

thanks,

greg k-h