Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <3caa56dc-ec80-a172-a632-42689aaf6f0b@redhat.com>
Date:   Mon, 14 Feb 2022 18:22:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with
 mirrors
Content-Language: en-US
To:     Peter Gonda <pgonda@google.com>
Cc:     kvm list <kvm@vger.kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        Marc Orr <marcorr@google.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20220211193634.3183388-1-pgonda@google.com>
 <a3008754-86a8-88d6-df7f-a2770b0a2c93@redhat.com>
 <CAMkAt6rLafSikpQEKkbbT8DW4OG_pDL63jPLtCFiO1NNtTRe+A@mail.gmail.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <CAMkAt6rLafSikpQEKkbbT8DW4OG_pDL63jPLtCFiO1NNtTRe+A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/14/22 16:52, Peter Gonda wrote:
> On Mon, Feb 14, 2022 at 5:57 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 2/11/22 20:36, Peter Gonda wrote:
>>> +     list_cut_before(&dst->mirror_vms, &src->mirror_vms, &src->mirror_vms);
>>> +     list_for_each_entry_safe(mirror, tmp, &dst->mirror_vms,
>>> +                              mirror_entry) {
>>
>> Is list_for_each_entry_safe actually necessary here?  (It would be if
>> you used list_add/list_del instead of list_cut_before).
> 
>   I don't think so, I think we could use list_for_each_entry here. Do
> you want me to send another revision?

No, I can do that myself, thanks!

Paolo