Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5937708pxb; Mon, 14 Feb 2022 11:09:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxyZtyTUbFxpjFFpf7RjDpRVYqM7ZPSG2mtFcOFKB8+67P1Qx091RrKbo+lmTkYcFAD6wFa X-Received: by 2002:a17:90b:1b51:: with SMTP id nv17mr73895pjb.226.1644865769123; Mon, 14 Feb 2022 11:09:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644865769; cv=none; d=google.com; s=arc-20160816; b=O2ho+AC6HscxUTAyHGgI5fM/Op0xwdW6XxRLb73O4vLgtpyss26nQaS0tBhTaImwws XwDL+VFG0D9shif93/G3BW6It4wpNy8JmXq79D0fibFsiSOzUia16h9H7kF7xD0RFbJk dHSMyORFiawEWiRzmNgdDNKob93L7uBKj93h5FCP8o1O0/fa6gCG89jSAWs7y2AfWgz/ bvVIAZvhCD5/ujpS2oAc39nzpLCeYVxW3rdUuhkO0BNGYGVMCDpBLSFV/aJ+/svTpuIw tMlyKFMXWJG7EBGyijd0NptM+uiwtzGZ1+qznO54ORhlJXgKmR9I0Mc8TQu9zzQzQ0QY q3dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=iZZdEQb8ApgOq2Oa4zYREdK2wCjW7xz1kvSRvb9LbwM=; b=0PukYPNH35Am7YMryj/V41cvUCmbXSioRWXY7yWcXo8tmBYocDszQOmYeaf+Hkb0C/ 6TjooR5XOjG4ICfa1ij2Rb3oMGc8P4SyfFKvy4ARzfhdHY9I+KkYzNDfmnygJNi+hgLk B3m6WZTH7YJmnqVNVpzyXKFoQOcxBK5rRlRTPhdtvX62A7qsAuHvdhe2+ipziSZ88xRF pDQ7PSo7ODoTo0WJV0evB8biWg/ZotrSCbQw+cI3pgvRxITOuABzHR8yyR7BFN+OJP5Q J71I9XxFTcGbTFEr0oo4TFhqoRSlurtf/fysNLYWwQYQ5Bw8LWUdzRkFceatD2yiFqnO vo+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qMnTnK9a; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u71si113102pgd.225.2022.02.14.11.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 11:09:29 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qMnTnK9a; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3CE2C888CB; Mon, 14 Feb 2022 11:05:25 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244444AbiBNJju (ORCPT + 99 others); Mon, 14 Feb 2022 04:39:50 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245519AbiBNJgt (ORCPT ); Mon, 14 Feb 2022 04:36:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A758D6DAB4; Mon, 14 Feb 2022 01:34:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 052B6B80DC6; Mon, 14 Feb 2022 09:34:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E23FC340E9; Mon, 14 Feb 2022 09:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644831280; bh=81aYpI91jq53HB2t3OGicrrculO2wPexrRicI87XbMQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qMnTnK9ar2fmhqXGj8Yx9mWTafUitwWLl1BBEGc8+Z5Ts4PyFmSp96DZFgoO+n0ww D9TBMDd9FoMAeTMcUv3ZptV2iV6IHr0s8Su1lDTRF4R6qHYWEMLFqSgv8hPdQQDbXi 7Z7uQr4wr+XYaUIc/z3Ke1oBjOGD7MqWgcp5CvuU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jon Maloy , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 32/49] tipc: rate limit warning for received illegal binding update Date: Mon, 14 Feb 2022 10:25:58 +0100 Message-Id: <20220214092449.355989042@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220214092448.285381753@linuxfoundation.org> References: <20220214092448.285381753@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jon Maloy [ Upstream commit c7223d687758462826a20e9735305d55bb874c70 ] It would be easy to craft a message containing an illegal binding table update operation. This is handled correctly by the code, but the corresponding warning printout is not rate limited as is should be. We fix this now. Fixes: b97bf3fd8f6a ("[TIPC] Initial merge") Signed-off-by: Jon Maloy Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/tipc/name_distr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/name_distr.c b/net/tipc/name_distr.c index 836e629e8f4ab..661bc2551a0a2 100644 --- a/net/tipc/name_distr.c +++ b/net/tipc/name_distr.c @@ -290,7 +290,7 @@ static bool tipc_update_nametbl(struct net *net, struct distr_item *i, pr_warn_ratelimited("Failed to remove binding %u,%u from %x\n", type, lower, node); } else { - pr_warn("Unrecognized name table message received\n"); + pr_warn_ratelimited("Unknown name table message received\n"); } return false; } -- 2.34.1