Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220213063151.3321331-1-hsinyi@chromium.org> <7efb2a87-1b8e-5bab-651f-ffa21ea8d716@collabora.com>
In-Reply-To: <7efb2a87-1b8e-5bab-651f-ffa21ea8d716@collabora.com>
From:   Hsin-Yi Wang <hsinyi@chromium.org>
Date:   Mon, 14 Feb 2022 18:17:56 +0800
Message-ID: <CAJMQK-hCD7sCTODV_WPxC_eX27XQ3dWyhHJjp96KWNjzuPvquw@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel driver
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     Sam Ravnborg <sam@ravnborg.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 14, 2022 at 6:10 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 13/02/22 07:31, Hsin-Yi Wang ha scritto:
> > From: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
> >
> > Add STARRY 2081101QFH032011-53G 10.1" WUXGA TFT LCD panel
> >
> > Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>
> I have no way of testing this driver but the code itself looks good to me,
> so, strictly for the code:
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>

This driver is used by ASUS Chromebook Detachable CZ1 [1]. The dts
will be accepted after this panel is accepted.

[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20211213162856.235130-1-hsinyi@chromium.org/

> > ---
> > v2->v3:
> > rebase to next-20220211
> > ---
> >   drivers/gpu/drm/panel/Kconfig                 |   9 +
> >   drivers/gpu/drm/panel/Makefile                |   1 +
> >   .../gpu/drm/panel/panel-innolux-himax8279d.c  | 515 ++++++++++++++++++
> >   3 files changed, 525 insertions(+)
> >   create mode 100644 drivers/gpu/drm/panel/panel-innolux-himax8279d.c
> >