Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5945865pxb; Mon, 14 Feb 2022 11:21:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzOff6z9cetYuwMNPqvi3PkwWkSsEQyioBUGqkif8rKmZAPwbT5mNFQtUDNQxIwkzacjsVu X-Received: by 2002:a05:6a00:1a50:: with SMTP id h16mr567311pfv.74.1644866497905; Mon, 14 Feb 2022 11:21:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644866497; cv=none; d=google.com; s=arc-20160816; b=i39lXQbF6IsA8uaIwn//QxyzhQHE1UQWgpyWlOhJhvY21H0orU1MQrDugj35ik/A2T 9WZEGvhHHZQNNGxBhE6+niSBujDVMIoF9aUGSrCdbCMVH4smNoFy93yF/ddvSnPoA0Uw bQryobWIG46MhD9qUq0cLOZ8YRPACgk+L29KrWVJKNAlJyuO72onD9MGpLsNLiD0QhRN sGSbfu1KC/UIW62pRNKgaTLQSnQWWlUR1LPYt+ao9WYU6v+aR6M058Pfhi7GMzQ9BGSZ hB4I86+p7PT7c6A9QRvK3I/TJZRXQxKjaifoACpec56lwhRaHfFwJF5gAkA6HSfTENqQ hlow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=za1XMQmDSvo1tI1nYjjULb15Ic/yfPGol3r5k5Fjeac=; b=PZf/UZ+5L0ngdf7TGEfsi9Ujc2ReQjmLHRMQA+wrWdd0zwDdTO2x0tTjD/pO/gh4sV 3XRVSOlAnrrA3fbHXzhXi4HDspoamtuBQk0X6vDkq8NVURgNE96k7yXSllxVYRPiAP5S GK36swfcqgavfjH+8oU7GYDT2rW0bZW7+P2OshbcZrI0q2zsRWY8PfX7XA2hHKwpHvSU 4H3u0IV/no+pKAAdPrz9M+p8YEUKEK8X2+z1FflL0a1mOHTmXu1UHVR57EipXYyRCXgL xM78Ks3yEvILb0NmYyczQoXwTHdPWGt+2gdGNj8OIcwLgvrCSep+8RW8ZdX27J3phQY7 dyVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=V+B92DzL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id x15si12683229plg.314.2022.02.14.11.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 11:21:37 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=V+B92DzL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DBEA8C12D5; Mon, 14 Feb 2022 11:12:45 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357375AbiBNSO6 (ORCPT + 99 others); Mon, 14 Feb 2022 13:14:58 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:58998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357371AbiBNSOz (ORCPT ); Mon, 14 Feb 2022 13:14:55 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C35F6541B for ; Mon, 14 Feb 2022 10:14:45 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id bx31so23509748ljb.0 for ; Mon, 14 Feb 2022 10:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=za1XMQmDSvo1tI1nYjjULb15Ic/yfPGol3r5k5Fjeac=; b=V+B92DzLSwMBpjaeppdbk+sAoKjZyUQ/OkQuTlh+advSeJZ9o8fPIxWeIx7+AxQKpB ycAXqXNyBB+AapMyKSNHaZJ7HL1Va+uEb7lfmh2AV1MfBNopCD+DWsY9qFifDO0ZbPLZ 8xSB5iHB35K56klYlTL1Ne9fKNWQWwPZd7Po3/ExMzbeYVsXqZujuaCJm/Wz0c5r6Xes a27j6r44Juz6t5pHXiUP2Fw6QXMGWpnFEhCPPS7xXrhEb63E7ymJjYtUU+e9HZwCMPIv eiFsgOCKmk12fLU4lBG8QNAuU65+Ch1IToVC9poY2QlUZYBuVpX7hIJylVRnbs0mi/qe JgRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=za1XMQmDSvo1tI1nYjjULb15Ic/yfPGol3r5k5Fjeac=; b=4W7ZPbpIIrL01Gbv2jCKYQyRcbESYSsUSZ4mY8V8JFd0ol/nV56dMyqu4eEa5dxCfG kch8gD633DtpW0M9qXf2t/k269Ry9Z/IhnqNdeCsKeHIjkET/HIPjG+HYqH+yERx4q8F fOsrdFzuJ2ymSlFKsDf2Zt7hmv4pequ2iPUDa9fiaenY4+XedHq4A8ajQi1jWykc5jqI gKLOuP9qI6qLInzf5+qkOhw5KP59rIltPo4/jfA6yVq5k9ng4hDs1zAv7AwH0vBcVTQt 3Pzz7Z8zc132uBUc/S2l8IBpVO6e1EEFle9vX8cxok2eiofgivgCYvP3I7ahOxxCN4sW cGRg== X-Gm-Message-State: AOAM532vGFP8WT2O5pMpeXjV1ffQJkhM0XNOxA6xjDwjKkOb7R+o/xGQ QF+99zH0aavwE4pd2QLLJBIApvCC7BMkWQ/4NE6zxw== X-Received: by 2002:a05:651c:1a22:: with SMTP id by34mr645542ljb.331.1644862483359; Mon, 14 Feb 2022 10:14:43 -0800 (PST) MIME-Version: 1.0 References: <20220204115718.14934-1-pbonzini@redhat.com> In-Reply-To: From: David Matlack Date: Mon, 14 Feb 2022 10:14:16 -0800 Message-ID: Subject: Re: [PATCH 00/23] KVM: MMU: MMU role refactoring To: Sean Christopherson Cc: Paolo Bonzini , LKML , kvm list , Vitaly Kuznetsov Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 9, 2022 at 2:31 PM Sean Christopherson wrote: > On Fri, Feb 04, 2022, Paolo Bonzini wrote: > > KVM: MMU: replace direct_map with mmu_role.direct > > Heresy! Everyone knows the one true way is "KVM: x86/mmu:" > > $ glo | grep "KVM: MMU:" | wc -l > 740 > $ glo | grep "KVM: x86/mmu:" | wc -l > 403 > > Dammit, I'm the heathen... > > I do think we should use x86/mmu though. VMX and SVM (and nVMX and nSVM) are ok > because they're unlikely to collide with other architectures, but every arch has > an MMU... Can you document these rules/preferences somewhere? Even better if we can enforce them with checkpatch :)