Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 14 Feb 2022 13:50:54 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 16/24] EDAC/amd64: Define function to make space for
 CS ID
Message-ID: <YgpQLnTd4TyiehS/@zn.tnic>
References: <20220127204115.384161-1-yazen.ghannam@amd.com>
 <20220127204115.384161-17-yazen.ghannam@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220127204115.384161-17-yazen.ghannam@amd.com>
Precedence: bulk

On Thu, Jan 27, 2022 at 08:41:07PM +0000, Yazen Ghannam wrote:
> +static void expand_bits(u8 start_bit, u8 num_bits, u64 *value)
> +{
> +	u64 temp1, temp2;
> +
> +	if (start_bit == 0) {

As always

	if (!<variable, etc>)

for 0/NULL tests.

> +		*value <<= num_bits;
> +		return;
> +	}
> +
> +	temp1 = *value & GENMASK_ULL(start_bit - 1, 0);
> +	temp2 = (*value & GENMASK_ULL(63, start_bit)) << num_bits;
> +	*value = temp1 | temp2;
> +}
> +
> +static void make_space_for_cs_id_simple(struct addr_ctx *ctx)
> +{
> +	u8 num_intlv_bits = ctx->intlv_num_chan;
> +
> +	num_intlv_bits += ctx->intlv_num_dies;
> +	num_intlv_bits += ctx->intlv_num_sockets;
> +	expand_bits(ctx->intlv_addr_bit, num_intlv_bits, &ctx->ret_addr);
> +}

void functions but they return values through their pointer arguments?
I'm sure you can design those better.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette