Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5963079pxb; Mon, 14 Feb 2022 11:48:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8b65o5gYRYGGz1kAFV0/EwI+V05qP8zWGCH6H/VpIVZ0EAf1OijPbARBgHVKqEPNFBOvT X-Received: by 2002:a17:90a:e618:: with SMTP id j24mr230229pjy.75.1644868134274; Mon, 14 Feb 2022 11:48:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644868134; cv=none; d=google.com; s=arc-20160816; b=lNRzdaUFLX08coKryZN03YQ4QTNb94FPYVaM7s3T0FvKrbfRaHH/piC4nJhFiPLayi g1pJMILEymAYEWLHPnp1liu7etGi239bCRWGvLZyO+vYGRXQDHpTMnbAQ75DfhgwMcKR 954WWwux26LqPLPWeFOBUloquWn/s/LS44NSLidzJCoqtCEFiKax9tlNiqDpl5YHP6vZ TC3cPg30+UhC1qA/l94sXuag2bzE7+/jkgr999dLw4E3P+hRZVrA8iM445MpW6yXEumT L2x2di66jJPQtttGkGJLGO5V62QJrMkAWm15N9Vlguxy4H2ffPpC+5cCVxFfMxwCYrfm bH1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8ipHCMa7LmT9iqOXceOSx0tRn78bEMi+hFRX32Mcgcc=; b=LCF3+ceKlBizXboxf4CWZDW7zFEOpgTQOm9HdP0rHWp5MAcP9Lt68kwqoxkVg5Tzkf HKLh1wrsos4LlZ4dnyeiVZd+G5KC1vuGwlZyxzicq/qr1OWCSBi0eCvGtcd7jhbSVwYW b7WIWOFLyUqcvs1MiTgtugo+nzFUmSYcrRwmtndZXd72U1iUOcDxJK3vrLHcU9Sou3tj qNjeCp7gz/fQdztIcHeuhHYZshqTq3V4AnIVZ5tEpNGhEB5HDadI4YMiqMQEdjhyBkZ/ yLIDVEj+MtLOmB4KB8mSRMrQNglKz/OxQcGr1ggLqYlSMbP9+QYvVW3NMKNpNQLRUska RWhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h11si12446148plf.242.2022.02.14.11.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 11:48:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 56BABB9D72; Mon, 14 Feb 2022 11:32:06 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354206AbiBNNVU (ORCPT + 99 others); Mon, 14 Feb 2022 08:21:20 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232754AbiBNNVU (ORCPT ); Mon, 14 Feb 2022 08:21:20 -0500 X-Greylist: delayed 311 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 14 Feb 2022 05:21:12 PST Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7126A483BF; Mon, 14 Feb 2022 05:21:12 -0800 (PST) Received: by theia.8bytes.org (Postfix, from userid 1000) id E97D86BF; Mon, 14 Feb 2022 14:21:10 +0100 (CET) Date: Mon, 14 Feb 2022 14:21:09 +0100 From: Joerg Roedel To: David Heidelberg Cc: Andy Gross , Bjorn Andersson , Will Deacon , ~okias/devicetree@lists.sr.ht, linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/msm: simplify with dev_err_probe() Message-ID: References: <20220206202945.465195-1-david@ixit.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220206202945.465195-1-david@ixit.cz> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 06, 2022 at 09:29:45PM +0100, David Heidelberg wrote: > Use the dev_err_probe() helper to simplify error handling during probe. > This also handle scenario, when EDEFER is returned and useless error is > printed. > > Fixes warnings as: > msm_iommu 7500000.iommu: could not get smmu_pclk > > Signed-off-by: David Heidelberg > --- > drivers/iommu/msm_iommu.c | 24 ++++++++++-------------- > 1 file changed, 10 insertions(+), 14 deletions(-) Applied, thanks.