Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5964058pxb; Mon, 14 Feb 2022 11:50:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJyr4zNr/HcQfnRkA/j5Zbiw9GPzgfhXawaZS49diowGoj84075UNFiQDUQeWreaeZOdMJMj X-Received: by 2002:a17:902:fe83:: with SMTP id x3mr330339plm.117.1644868227310; Mon, 14 Feb 2022 11:50:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644868227; cv=none; d=google.com; s=arc-20160816; b=eh+ESPYm/7EIvcKBi6ndpj8TTE15qC275T/N8Wn65l17maAnXoJXM+LNMDnyS52wGM h8m7mu+GZy1zlJ7aaX4TT5b7VoJCDsmyMB0kswCt0Ay1BKsa+JQadmgQHwsWPOBGUuQk 5W5HmxHBOu3XTZeZPCMYedv1+XBmwiFPTQ1KFgVHUZqCsKH1bWr0X+ZXVeIYlajpoZw8 8i8+PgrpHLpL15YST4MSubgWWniPoAs7kS/efgW+dOsa7vnQQH3jNT24nRVKNyK8XHVI h8H1eWX/iEALmCogTgZVjwQom1cpKL0m4oGMYcznfyn/PORVD5jD5YL//gUUQhuBSNfz S7zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5Vcgmwu6GV1Ng5bKbLO13t3Y73XwcUYyPhbnha8JCAs=; b=wcVvhcjTswEYaRurY9SCMe1iJj0LWN5vucjNFBikAiAEgoUY0HqrBGQTV9dbjuXr9j ClRLLzj/bdAMy+wI4t2YCzrrEhfoaT3cMsQ4gg7pW1oLkgt0yH28VbDiXXT0VPYYBl1E SncrAToXpar+ZYlmzsRpFEtSxAbol/MyuHCML0eqhomcRsGg7e+j0FenBSI4OLZUfkRw KYWi+/KwXAazyWUeWklMVVOTYrVO3ft1WtCJ7+xyJl9Y4DV/aymyyVcbxoXhILANx/6g mCRBLuvI+B034ndigD+LrGEYS1DvEY4hkzpmeAs6J3s5se+IIC+0FLdG/4hv/fcd3JeG 9axw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zK+9tquE; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id z9si14019988ple.488.2022.02.14.11.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 11:50:27 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zK+9tquE; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0A554125CA7; Mon, 14 Feb 2022 11:33:39 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233715AbiBNJfC (ORCPT + 99 others); Mon, 14 Feb 2022 04:35:02 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244138AbiBNJej (ORCPT ); Mon, 14 Feb 2022 04:34:39 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AA751ADAC; Mon, 14 Feb 2022 01:32:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B73F4B80DCB; Mon, 14 Feb 2022 09:32:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0386C340E9; Mon, 14 Feb 2022 09:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644831159; bh=lP/9XNjr06Zs66IlC10yUo62yXsw8hTcr3FXGl4Gv0I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zK+9tquEIf8mhLXMESEKB4fF5OHGronT7URif/hszHLR2vVOWdfcWOTYtrXT57vmA phP43JRzCsGol72xyZN97O4DXEbDK5rnvpOZES0DY79Wz2VLpjp/gYgNFX2QboK9kk VU1NaSSI4/45NEM4kAXR50gaxW5qFmxElrBJUqtA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jisheng Zhang , Jernej Skrabec , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 17/49] net: stmmac: dwmac-sun8i: use return val of readl_poll_timeout() Date: Mon, 14 Feb 2022 10:25:43 +0100 Message-Id: <20220214092448.862377055@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220214092448.285381753@linuxfoundation.org> References: <20220214092448.285381753@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jisheng Zhang [ Upstream commit 9e0db41e7a0b6f1271cbcfb16dbf5b8641b4e440 ] When readl_poll_timeout() timeout, we'd better directly use its return value. Before this patch: [ 2.145528] dwmac-sun8i: probe of 4500000.ethernet failed with error -14 After this patch: [ 2.138520] dwmac-sun8i: probe of 4500000.ethernet failed with error -110 Signed-off-by: Jisheng Zhang Acked-by: Jernej Skrabec Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 4382deaeb570d..0137cba2cb54b 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -712,7 +712,7 @@ static int sun8i_dwmac_reset(struct stmmac_priv *priv) if (err) { dev_err(priv->device, "EMAC reset timeout\n"); - return -EFAULT; + return err; } return 0; } -- 2.34.1